From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0074.outbound.protection.outlook.com [65.55.169.74]) by dpdk.org (Postfix) with ESMTP id A4600ADC7 for ; Wed, 22 Jun 2016 15:43:01 +0200 (CEST) Received: from BLUPR0301CA0019.namprd03.prod.outlook.com (10.162.113.157) by CO2PR03MB2375.namprd03.prod.outlook.com (10.166.93.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12; Wed, 22 Jun 2016 13:43:00 +0000 Received: from BY2FFO11FD028.protection.gbl (2a01:111:f400:7c0c::184) by BLUPR0301CA0019.outlook.office365.com (2a01:111:e400:5259::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.523.12 via Frontend Transport; Wed, 22 Jun 2016 13:43:00 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD028.mail.protection.outlook.com (10.1.15.217) with Microsoft SMTP Server (TLS) id 15.1.517.7 via Frontend Transport; Wed, 22 Jun 2016 13:42:58 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u5MDgtCi020760; Wed, 22 Jun 2016 06:42:56 -0700 To: Neil Horman References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-1-git-send-email-shreyansh.jain@nxp.com> <1466586396-22618-10-git-send-email-shreyansh.jain@nxp.com> <20160622132752.GA6785@hmsreliant.think-freely.org> CC: , , From: Shreyansh jain Message-ID: <576A9606.8080506@nxp.com> Date: Wed, 22 Jun 2016 19:13:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160622132752.GA6785@hmsreliant.think-freely.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131110765789257938; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(377454003)(199003)(189002)(24454002)(2906002)(105606002)(97736004)(23746002)(19580395003)(36756003)(19580405001)(47776003)(81166006)(8676002)(80316001)(230700001)(87936001)(81156014)(7846002)(65806001)(110136002)(64126003)(33656002)(189998001)(77096005)(11100500001)(4326007)(83506001)(85426001)(6806005)(586003)(2950100001)(93886004)(59896002)(50986999)(86362001)(8936002)(65956001)(92566002)(76176999)(104016004)(87266999)(4001350100001)(68736007)(50466002)(106466001)(69596002)(65816999)(54356999)(356003)(575784001)(26583001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2375; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD028; 1:owxEXlDWi7Z0qs01ABw96JL1mH+6wxhG9Wlc+uJU16UlK4XZfhyYOuuWoXyQuNxcr7nWS9EQV6fXbMsCgYYhkAOZeYcq0QRnj0TOHlX2Ia4fOO8NyQS9lGsJZjmMmp8LLL8hj0rhoEK33QfVcZQkMziv43IYlcQVfX71q9XoS9mc88/1xuaiG1LqiNYZvf0qp782sdpb8R2LqiYcMPIpiu9DSVK5D4zybHRkNKCmPaTihJ1BCIQUwsXdr7vmPHrcVZ+jegW5pRZXVjUJwdC4v3hG95oRNZSGg9Jxg1B28YiIrxOMv6rmLPcMal7LSjeD5RKmXb9KildKjpDvr1ewFEtZtYEkfHoocoqJb4bVmL/J/0XH7OqAQ06oVX7s8BbuvzDkI42fEAg3Jg+XBO8992Hf0Vg1U4k7qWA1YpPVX8fOeZFZ4Bq0A4qL3N5veW7zHqxZDEhgaW+lHgsUSNJlTIFvuYKiEayv/QKDXNWX0VlZlsLQSn+I9XrxMNvBo4asfkmUj2DIQJhKMk9ocoRVuENrxHFfrACIj2sb2qQqQhAZulz8JVLmolyyW/tZFrYI X-MS-Office365-Filtering-Correlation-Id: 3f4150b9-6983-4490-20d2-08d39aa31f90 X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 2:G5MA2re7AVI2kMNKkPoiyuTbLduzx3t6w6MT7ZH5YhIijhFTh50ymC0fEWAjofCqDlpbr1M+SuCePh16ypVAywPOM+1FqvjbvmBENmH8GYQ07yPOIQunLulUm+rGfurkyG51bHOT6hcfiSWRU2KCYV+/Q7PujZt9wSkOKX2u0csdPjIDGrztEuXlJ6RUvf3/; 3:55hrZZSHI6GWvqfWDuueLNcFl6N+yAstCU1ksPPeFQgkodRs3omEGylTsqyLyDdT1/VaHSAJxtBKN2KMP6Lh6aO/2ll69ukbYNiE6GI3NmfpSPc7zz9HrGE8FetcbAWZwICA4Ry8Q+m/2KZRX8zKktoJC2eyTq/5+5bZYrNTGeELr+plx1Eva65IJe/VfwkTDPYYJQVKEdciJmeaav/mVMWy1Sv+TLOWoNFT0wR5LTc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR03MB2375; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 25:WQzco0LbDYxr4s8gHY9nX4WXksJ9vW1m52bMchHyaLP2u0XXduJs+pV7V2pDAbuO7kN1cmoySdCKFqa/8MKL0VeqauPzLDZBVrw105/lMNtwV4m2VWXzy/f8nlr9eh1hvg8+TlSrY2lB+gaD+iwaLVMti5igLqYcL0bbkEl9Gyl23W/QctbL/5k5xHQMwXfbGgeUAnkgZJ3xgXKAQ62PzlLbXGQYtWKtpjVDJ3WalZ+w+/efyK9kh9l3wYfijKTj4DrR9aBmYqoUsKioHNlwdO13LlcXDVgPyCuHTnv3JFFAUzG4J2ag5TfGqmKiVRz3zIJBUPnugUP3kPo5y5D88BqIlyn6Z8Qh+rigVstiB6gLWKRfBvVG4Szxz8JDFsIvmGBiLcf3ISN6WkQMZI8mAk0qa+Vw4csJhU1YJb4M4IOGcaprlWKwF6WGz6X6PBUZLtJhIDzkdtACIqW4Ko5/LifmblcMBF3dpKuBU/OG/dlCHTWaDr5qWAIRSjqnd3pRlps9Wx8PG4yHtxZvSxlM846t1uwWcq/aitcm+uE2hpr8qNJuXwzNvTAbOmdZU2yN0N9G+Mbl9MaJhAsIt72ciKdLdHpwOYYkgtkmrpzoGyCDKJaUqX2qm65vw70mewzgmQ4l7FNPreCAbddYHjag1dWgHP0Zot+/WRCaZp0EOvA4Q/4gd9Mbt5bRsWZ67oXywTRjH3oaGyI5zhqzZAo6OZKKWTQ4QOoM4WzQZpqrPSI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(8121501046)(5005006)(13024025)(13023025)(13015025)(13017025)(3002001)(10201501046)(6055026); SRVR:CO2PR03MB2375; BCL:0; PCL:0; RULEID:(400006); SRVR:CO2PR03MB2375; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 4:IYScZ58S96/q6hs8MAo1mgdDVVt97Tq/b8spL/3WfYM0rBr2Zh+vaqt5loE11LgaVqniUrfTJWt8D8GwdaQglkzqclldw6aD5fdFI+V/PxvUpIrC1uAXUIjd6vBeJguJujWbbJZtyCybMKMOHACuPOQn9Ut0/7t0zRO4K11K3BWk2GfTMBdcP1IW68B09S15ql6TNJojTua3qsKi0nGeqohDPQHi91sI4P/gOMMqf3MssuaIbeMFFWj12scRcUxQvu1bE7WU+CWhgGJLVitBp0WdxzBbYWfptwk/kxpSFUHVViKi0U4wVfXknPcTenCFUxzAAfUCW+xJxEA39/Z63QaVAAG6m1ynOb+geGZLRiY7XR7LngwyYdCxcIfsD5HWoq24+Cn1rJTB/pNiZu6CqieDVX98Gr80sS5AiAGmNffvCiDeAeu0qnU04bZJUD4sCXHBEu10nlpg/4f19ExxZd5ml7RU2+II13SgT7qkv4+PgZ1rQwkrmcdHwMia1OBtl80OjFAC0v6kUI3vdWr9gg== X-Forefront-PRVS: 0981815F2F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CO2PR03MB2375; 23:p8g3g0OjFodkDJ8Rxf/R297eIZbk04mobRBp6?= =?Windows-1252?Q?3673UZOW115IVagLXdQYF9zrorNIBgprBmxWemquMsVHbmZDebfLtgCi?= =?Windows-1252?Q?5BHGSaJZV1vhqssjYEjNLytKuP1htSoXvz7bsRbRThhCKCeN45d8juiz?= =?Windows-1252?Q?HXyJSlT5j8HeljzjMqN3dKUJwlPJrJ31egyu0ZRCd7UiK4PlC5zHYgyK?= =?Windows-1252?Q?2od+gqzwh1ITJbAzaAqet+3cfdKPpNeyi/wjnYymWAxWIGHVAbjUcHMd?= =?Windows-1252?Q?NlbVYp5gW4n0AQlcUsaWmxXRHvACGS11BuJ59yBWg8s0AbQdBf01yTaN?= =?Windows-1252?Q?KeKRB9RrfymKnuQNSCb9HG6PVj//mijfkSz89lfXS7HUvVSPjYeOmOak?= =?Windows-1252?Q?jHU0G9z+fKiuyDQ5LjRLqxX153DZe3KYmhjJBL+MrSCVxO6V/+ENQkBj?= =?Windows-1252?Q?m5TimIg0POkcvFEkKZ6/2ec2gIjx9xsax5GhpeARpYuLaBS+DqkvGIFx?= =?Windows-1252?Q?XtU/PUVRX+kLJEbzcL55UjvdOR6d8k4HhGCNwbly/2KnmobmaVzTOyAH?= =?Windows-1252?Q?cT+mWV/TAUsM12wKRrr1TSfaLQc7hpsVN2KPVbj1SY1xylIESToNvsQ1?= =?Windows-1252?Q?gQtER1hEhloMBvrMjxpJPha1Fnh2hm1/O6hl0khDX+aHfD0STX1y4AZi?= =?Windows-1252?Q?6h7tfd6Qj1Y08cajEseh6nbEadTgJSi1UR6XITmSNsCp7V8skYPPzMmS?= =?Windows-1252?Q?6K5WmGxKtrqyAOQiTl8NskJvxdnUHmtWPEt4nnQS8guZciyhYvWMzPtq?= =?Windows-1252?Q?zFF+jZbxGJOgSfq6iYLq7kSxFtKyS8GSfxji7EmEcKfiwexxWtc09x63?= =?Windows-1252?Q?I0cIqSVHFeXE6pvxnAcGxJ6tQ4hfSwCvKmHGvQLvRQbM1PshJAruVLOi?= =?Windows-1252?Q?EUuuDhrAe61Oe6FuD54154MwndQPuZNUpTVRjq0lglTaKldHfjX4KVwB?= =?Windows-1252?Q?GIYUU6xrD7Lsfhwlh8kfAvnACm5mcdrDVZIuCuyzfp/UlVSqfvj1t73p?= =?Windows-1252?Q?ByI9OOIFI3zrtThUniOJUxDflfVC7YW0ABLMSIZc7V6i5sRLNsSwtnbz?= =?Windows-1252?Q?rxB43HsYckKuISwnSzQmJvJnuDNWGse0vABg1575wS7X7FfaBvOnh9wD?= =?Windows-1252?Q?13C8UAZxOusdTmX63Y+O8KztTDgE5FV7Da+/tpdR5XOgLsPUPZD2Cr1Y?= =?Windows-1252?Q?VVaoXYB8NjHKNRxIJlZAYtTKuhF+oxGJlavbiCnw+Vt2jYMIOK46I/69?= =?Windows-1252?Q?WAw2Npb4saRhVUcGgycz84RQ007ZLadf+4d4CQ+H0joaFfq3V7CohucP?= =?Windows-1252?Q?y2X02Mvw73vzkQYWYJDJHNWOWepN5Oe8BDLCdOWPamQ4GlAZW9KXeUWK?= =?Windows-1252?Q?l0OX+wcSxsDy8+Fivegp9aE6Kv7/joNX4VrXQWrDcw8cscvrMfz3Rigp?= =?Windows-1252?Q?7nQ/GM=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2375; 6:CHKwLwK1rLvvmSLzjVt/VlgpThnretPEW/tf2g3knfdgVKS7oevzlgWqw6FxF78h+VQja0nfSDn1fkAQgLXTYYrpJ1BqSb6Iva4a2vZ6Xynl8rHynVoK3yAkb2pJ4R10oO6w76yWt6epuOZoe68Va1X10HONog7/NpuZVqpdFyr/cAEIEVD50/KnncPmiTfIDFKAxLTRg7HXcFu2U43KhP2Qf5Kv6/C2Y7a3KtzWxK25b9ZF0VHd9//al0Ny3Tjl+owdttiYmB0uHKbJcp/LVm0B+n127z3y9TkULJgaoqsN+HWkZnkIXtsnCPXCg/oS; 5:mAvpwkBbo85EOVRtz8g67v5PMINz/8z1irItX6CrqYzJa8F45AwHOCGfyEdYFouw7xAa+rHiU6+8xNgqeSm+Y7Zj7y+JQwydmpkGdRBi34vtESioDIDHSzsh9VYW1pTVVqi3dkkn7BGFThFD/zkqgGAT2RXsGFK1nVV9P+jifHM=; 24:1O4R6+7ZAM2LOOPZOUdn8AJ23PILcRRs1ud45ziO8dx7oRZ1nxBISPvB6k1GNQ6ZKx2sTw3KiCJ8fi0wpWERQz0/pUN94tP6FzyklejPdTE=; 7:21PLa0iVRoCxfPY3iJsnBwondvxvSdzwx2waChXgMylkolNNmrDlf6qurN9qs4Ge9M4tFeFN0xny8VzX58kBZ2wkv0EPipIjv40aZHwqsarkbUY2mpAUgS+rpUIoyuC334+2dIDLVFy3u63FnJMw7pv3Lf4qoiCd+NvkK8Z1Kcge68/0KkNH/Q86UH8JppdJAoongEKKMxb7NadZUbZbcOBje2FZJNFUa3dmrarzReKxMpM9UUBgaiKnDtqffFvWESX7veh2HZwQsn5s9EywxQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 13:42:58.6137 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2375 Subject: Re: [dpdk-dev] [PATCH v5 09/17] crypto: get rid of crypto driver register callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 13:43:02 -0000 On Wednesday 22 June 2016 06:57 PM, Neil Horman wrote: > On Wed, Jun 22, 2016 at 02:36:28PM +0530, Shreyansh Jain wrote: >> Now that all pdev are pci drivers, we don't need to register crypto drivers >> through a dedicated channel. >> >> Signed-off-by: David Marchand >> Signed-off-by: Shreyansh Jain >> --- >> lib/librte_cryptodev/rte_cryptodev.c | 22 ------------------- >> lib/librte_cryptodev/rte_cryptodev_pmd.h | 30 -------------------------- >> lib/librte_cryptodev/rte_cryptodev_version.map | 1 - >> 3 files changed, 53 deletions(-) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c >> index 65a2e29..a7cb33a 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.c >> +++ b/lib/librte_cryptodev/rte_cryptodev.c >> @@ -444,28 +444,6 @@ rte_cryptodev_pci_remove(struct rte_pci_device *pci_dev) >> return 0; >> } >> >> -int >> -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *cryptodrv, >> - enum pmd_type type) >> -{ >> - /* Call crypto device initialization directly if device is virtual */ >> - if (type == PMD_VDEV) >> - return rte_cryptodev_pci_probe((struct rte_pci_driver *)cryptodrv, >> - NULL); >> - >> - /* >> - * Register PCI driver for physical device intialisation during >> - * PCI probing >> - */ >> - cryptodrv->pci_drv.devinit = rte_cryptodev_pci_probe; >> - cryptodrv->pci_drv.devuninit = rte_cryptodev_pci_remove; >> - >> - rte_eal_pci_register(&cryptodrv->pci_drv); >> - >> - return 0; >> -} >> - >> - >> uint16_t >> rte_cryptodev_queue_pair_count(uint8_t dev_id) >> { >> diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h >> index 3fb7c7c..99fd69e 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h >> +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h >> @@ -491,36 +491,6 @@ rte_cryptodev_pmd_virtual_dev_init(const char *name, size_t dev_private_size, >> extern int >> rte_cryptodev_pmd_release_device(struct rte_cryptodev *cryptodev); >> >> - >> -/** >> - * Register a Crypto [Poll Mode] driver. >> - * >> - * Function invoked by the initialization function of a Crypto driver >> - * to simultaneously register itself as Crypto Poll Mode Driver and to either: >> - * >> - * a - register itself as PCI driver if the crypto device is a physical >> - * device, by invoking the rte_eal_pci_register() function to >> - * register the *pci_drv* structure embedded in the *crypto_drv* >> - * structure, after having stored the address of the >> - * rte_cryptodev_init() function in the *devinit* field of the >> - * *pci_drv* structure. >> - * >> - * During the PCI probing phase, the rte_cryptodev_init() >> - * function is invoked for each PCI [device] matching the >> - * embedded PCI identifiers provided by the driver. >> - * >> - * b, complete the initialization sequence if the device is a virtual >> - * device by calling the rte_cryptodev_init() directly passing a >> - * NULL parameter for the rte_pci_device structure. >> - * >> - * @param crypto_drv crypto_driver structure associated with the crypto >> - * driver. >> - * @param type pmd type >> - */ >> -extern int >> -rte_cryptodev_pmd_driver_register(struct rte_cryptodev_driver *crypto_drv, >> - enum pmd_type type); >> - >> /** >> * Executes all the user application registered callbacks for the specific >> * device. >> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map >> index 8d0edfb..e0a9620 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev_version.map >> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map >> @@ -14,7 +14,6 @@ DPDK_16.04 { >> rte_cryptodev_info_get; >> rte_cryptodev_pmd_allocate; >> rte_cryptodev_pmd_callback_process; >> - rte_cryptodev_pmd_driver_register; >> rte_cryptodev_pmd_release_device; >> rte_cryptodev_pmd_virtual_dev_init; >> rte_cryptodev_sym_session_create; > NAK, you can't just remove exported symbols without going through the > deprecation process. Better still would be to only expose it for DPDK_16.04 and > hide it in the next release Agree. I will fix it. > > Neil > >> -- >> 2.7.4 >> >> >