From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 724B04236A; Thu, 12 Oct 2023 03:59:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBDB5402BA; Thu, 12 Oct 2023 03:59:24 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 0E25D40279 for ; Thu, 12 Oct 2023 03:59:23 +0200 (CEST) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4S5XlZ1rMxz1kv0l; Thu, 12 Oct 2023 09:55:22 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 09:59:20 +0800 Subject: Re: [PATCH v5 37/40] app/proc-info: fix never show RSS info To: Jie Hai , , Reshma Pattan , Vipin Varghese , John McNamara CC: , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-38-haijie1@huawei.com> From: fengchengwen Message-ID: <57700977-8694-6093-8bcb-7676910b0b79@huawei.com> Date: Thu, 12 Oct 2023 09:59:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231011092805.693171-38-haijie1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2023/10/11 17:28, Jie Hai wrote: > Command show-port should show RSS info (rss_key, len and rss_hf), > However, the information is shown only when rss_conf.rss_key is not > NULL. Since no memory is allocated for rss_conf.rss_key, rss_key > will always be NULL and the rss_info will never show. This patch > fixes it. > > Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > Acked-by: Reshma Pattan > --- ...