From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 483CF5A31 for ; Mon, 27 Jun 2016 15:07:32 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 27 Jun 2016 06:07:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="984062176" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.17]) ([10.237.221.17]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2016 06:07:30 -0700 To: dev@dpdk.org References: <1466860257-4068-1-git-send-email-thomas.monjalon@6wind.com> <1467032551-14979-1-git-send-email-ferruh.yigit@intel.com> Cc: Thomas Monjalon , Olivier Matz , Cristian Dumitrescu From: Ferruh Yigit Message-ID: <57712511.3020806@intel.com> Date: Mon, 27 Jun 2016 14:07:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1467032551-14979-1-git-send-email-ferruh.yigit@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 13:07:32 -0000 On 6/27/2016 2:02 PM, Ferruh Yigit wrote: > Fixes: 19b16e2f6442 ("ethdev: add vlan type when setting ether type") > Signed-off-by: Ferruh Yigit > --- Hi Thomas, I got the duplicates with following command [1], does it make sense to add this into one of the check scripts, -not sure which one? [1] # for m in $(find . -name *_version.map); do for l in $(cat $m | sort | uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";" -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l; fi; done; done