From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 6D8D82C5A
 for <dev@dpdk.org>; Tue, 28 Jun 2016 10:56:05 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 28 Jun 2016 01:56:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,540,1459839600"; d="scan'208";a="984686665"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.47])
 ([10.237.221.47])
 by orsmga001.jf.intel.com with ESMTP; 28 Jun 2016 01:56:03 -0700
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
References: <1467044166-31912-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467044166-31912-2-git-send-email-jerin.jacob@caviumnetworks.com>
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57723BA2.6000002@intel.com>
Date: Tue, 28 Jun 2016 09:56:02 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1467044166-31912-2-git-send-email-jerin.jacob@caviumnetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 2/2] net/thunderx: fix unused function
 nicvf_mbox_msg_str error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 08:56:05 -0000

On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> Fix the following error with clang
> 	error: unused function 'nicvf_mbox_msg_str'
> 
> The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> compilation option selected. Mark __attribute__((unused)) on
> this function, to inform compiler that this function may be unused
> 
> Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>

...

> -static inline const char *
> +static inline const char * __attribute__((unused))
it is possible to use __rte_unused macro here, although not required,
and moving it before return type can prevent checkpatch error


>  nicvf_mbox_msg_str(int msg)
>  {
>  	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> 

Checkpatch gives following error:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
+static inline const char * __attribute__((unused))


check-git-log gives following errors:
Wrong headline format:
net/thunderx: fix unused function nicvf_mbox_msg_str error