From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id A8FB82E8A for ; Tue, 28 Jun 2016 18:05:31 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id h129so14796733lfh.1 for ; Tue, 28 Jun 2016 09:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xKpTtEuA7QPnldgXfyNRksA8WGzk3IoflTELaH3bM7o=; b=KVG65FMGoCgLlc6+fpJ80XBdKCOZOaCFruOKX7LWYGA/krDwIi/WGppk25LeqdeO1t mE2SpTUP1bCpaSb8AErGQOmqp4lWThWaa4v01CCkAbuDT69SdIb86hJC2kwk5uI+uGnO 00ZSi3fWgjQxgG4Zf0oIfnNiDF0NoUpcaVnyffw+x/XnGYRGb2SM1XD2HT59yVLB2oAz oFsX8CPXXhsiTsn2z0NnugfKvKd+UcCh2gosm8Yop1El81IRDWr0rjzuok2ogCK6npto 2ayntR78Iz+Lbaj6zu91s+pwbTnfW+O5TMPoR+iP1w0O07Itdg5TVNtbAKt8sM+Yy+sD qK0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xKpTtEuA7QPnldgXfyNRksA8WGzk3IoflTELaH3bM7o=; b=TVtiFrhul9F3ALdciaTcVE7odvrjwfIAIh+T6Ng6c8ue25SNkVWXRAUqLZEQlva0Yh 206xde+ofHVxEuBy6jkXNBXjxyPBD9MVqv2t/6Qv30tJMifiLiBYfWrhmruiQa6KVyF0 iWBWelo0dNFpaGBCq8hAZ5YjTfJaa52WoMwJboNAPhbE5LpURU5GThMXufcRY3i90CJC unu5cCjhiHHwVtt44UTrWqVk8M/7nbUUNqtTIRngXZR58Q7WYi6BJTybBiDobLysYCAx s4ZcB4y7Nu3iIoKs2wD3cm73u7HTPHfImVob7hp/OUfALwwUA193u5xzTIspa9y6qJmK 5D/g== X-Gm-Message-State: ALyK8tI/BfbNdYUUogNM2q6l83jCRGQVQ7m6N3NkajQb4ua3q5jB6/a5UHe2/bWU46kbfQ== X-Received: by 10.25.142.2 with SMTP id q2mr1274316lfd.11.1467129931377; Tue, 28 Jun 2016 09:05:31 -0700 (PDT) Received: from [10.0.2.212] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.googlemail.com with ESMTPSA id 10sm4296998ljf.5.2016.06.28.09.05.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 09:05:30 -0700 (PDT) To: Thomas Monjalon References: <1466688410-13826-1-git-send-email-zr@semihalf.com> <2151797.UCVmFz2S8u@xps13> Cc: remy.horton@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, dev@dpdk.org From: Zyta Szpak Message-ID: <5772A04A.9000805@semihalf.com> Date: Tue, 28 Jun 2016 18:05:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <2151797.UCVmFz2S8u@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: remove get_reg_length callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 16:05:31 -0000 OK On 27.06.2016 17:19, Thomas Monjalon wrote: > 2016-06-23 15:26, zr@semihalf.com: >> From: Zyta Szpak >> >> Version 4 of fixing the assumption of that device registers >> are always 32 bits long. rte_eth_dev_get_reg_length and >> rte_eth_dev_get_reg_info callbacks did not provide register size >> to the app in any way. It is needed to allocate proper number >> of bytes before retrieving registers content with >> rte_eth_dev_get_reg. This commit remove rte_eth_dev_get_reg_length >> callback and adds width parameter to reg_info struct which makes >> it possible to call rte_eth_dev_get_reg_info to get attributes >> first. The drivers using this callback fill width and length >> when call to function made with data=NULL. >> >> Signed-off-by: Zyta Szpak > Please do not mention patch revision in the commit log. > However you can add a changelog below the three dashes (with --annotate). > And please use --in-reply-to to keep revisions in the same thread. > Thanks