From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 6B25028BF
 for <dev@dpdk.org>; Wed, 29 Jun 2016 13:35:15 +0200 (CEST)
Received: from [10.16.0.195] (unknown [10.16.0.195])
 by proxy.6wind.com (Postfix) with ESMTP id C04A7246CB;
 Wed, 29 Jun 2016 13:35:14 +0200 (CEST)
To: Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com>
 <1569745.6sBGvsO00c@xps13> <20160629101552.GE4720@bricha3-MOBL3>
Cc: konstantin.ananyev@intel.com, dev@dpdk.org, helin.zhang@intel.com,
 amint@icsi.berkeley.edu
From: Olivier MATZ <olivier.matz@6wind.com>
Message-ID: <5773B273.3030203@6wind.com>
Date: Wed, 29 Jun 2016 13:35:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160629101552.GE4720@bricha3-MOBL3>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compilation when offload flags
 disabled
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2016 11:35:15 -0000



On 06/29/2016 12:15 PM, Bruce Richardson wrote:
> On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote:
>> 2016-06-27 17:44, Olivier Matz:
>>> The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n
>>> because the macro has not the proper number of parameters.
>>
>> We really need to understand why this build option is needed.
>> Target: zero build option.
>
> Agreed. However, we are where we are right now, and this build option is there.
>
> Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since
> the code in question has actually moved on that branch.

Sure, will do.


> Out of interest, can you perhaps also give a little more detail on how to
> reproduce the issue, as turning off the setting fails to show up a build
> problem for me with either gcc or clang, at -O3 or -O0.

That's strange, I just set CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n to
reproduce the issue. I'll check on dpdk-next-net/rel_16_07 and add more
details, like the output of the compiler.

Thanks,
Olivier