From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id DD5172BA8 for ; Wed, 29 Jun 2016 14:13:32 +0200 (CEST) Received: from [10.16.0.195] (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 8EA182513C; Wed, 29 Jun 2016 14:13:32 +0200 (CEST) To: Lazaros Koromilas , dev@dpdk.org, Thomas Monjalon References: <1467042637-22907-1-git-send-email-olivier.matz@6wind.com> <1467157658-28935-1-git-send-email-l@nofutznetworks.com> <1467157658-28935-4-git-send-email-l@nofutznetworks.com> From: Olivier MATZ Message-ID: <5773BB6C.9070707@6wind.com> Date: Wed, 29 Jun 2016 14:13:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1467157658-28935-4-git-send-email-l@nofutznetworks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: allow for user-owned mempool caches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 12:13:33 -0000 Hi Lazaros, On 06/29/2016 01:47 AM, Lazaros Koromilas wrote: > The mempool cache is only available to EAL threads as a per-lcore > resource. Change this so that the user can create and provide their own > cache on mempool get and put operations. This works with non-EAL threads > too. This commit introduces the new API calls: > > rte_mempool_cache_create(size, socket_id) > rte_mempool_cache_free(cache) > rte_mempool_cache_flush(cache, mp) > rte_mempool_default_cache(mp, lcore_id) > > Changes the API calls: > > rte_mempool_generic_put(mp, obj_table, n, cache, flags) > rte_mempool_generic_get(mp, obj_table, n, cache, flags) > > The cache-oblivious API calls use the per-lcore default local cache. > > Signed-off-by: Lazaros Koromilas > Acked-by: Olivier Matz > --- > app/test/test_mempool.c | 73 ++++++++--- > app/test/test_mempool_perf.c | 73 +++++++++-- > doc/guides/prog_guide/env_abstraction_layer.rst | 4 +- > doc/guides/prog_guide/mempool_lib.rst | 6 +- > lib/librte_mempool/rte_mempool.c | 66 +++++++++- > lib/librte_mempool/rte_mempool.h | 164 +++++++++++++++++------- > lib/librte_mempool/rte_mempool_version.map | 4 + > 7 files changed, 308 insertions(+), 82 deletions(-) > Thanks Lazaros for the doc update, looks good to me. Thomas, as discussed IRL, could you please remove the deprecation notice and add the following note in release_16_07.rst when applying the patches? * **Added mempool external cache for non-EAL thread.** Added new functions to create, free or flush a user-owned mempool cache for non-EAL threads. Previously, cache was always disabled on these threads. Thanks, Olivier