From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 871ABA0C46; Fri, 6 Aug 2021 17:08:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45849412AD; Fri, 6 Aug 2021 17:08:31 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 5628B4014D for ; Fri, 6 Aug 2021 17:08:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 95F165C0159; Fri, 6 Aug 2021 11:08:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 06 Aug 2021 11:08:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= NlCV7PuewNOqEvLBVMi51jtIOMD5qkON35HqonU5Ssg=; b=csDsMiLzlr09AabW E+HyiIKdSkFAgd8whNCNGQQf2fSClBSyR6PiBWi2JjaAAd+CdpBFZfTexkuEcDJa LeD5X0XfxOGrW1h0DhdmXdj/pa4yfVRT3EwsF7KAiBILWqTmEwNWr8dof8PaYC1h zWYEjMd0BO5c5NxcgTNtFkQ+9DfHDNhfkJmlIVI6CIP6MUET5HuD0JR1e137N7zc NGsp7/omLhsygoeBhwyB8ylK+CKFjPWYNaVrojg7Wc1UmalUAGTt47zVavuz6Idx fUPsf3Jo7NOKC7vmn6HUVXd734dfKxBzndyh4j7pRamOibSvVUyJxR6IvkUtwzNg yxF28A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=NlCV7PuewNOqEvLBVMi51jtIOMD5qkON35HqonU5S sg=; b=IGjndOrXkxWv6P8gG4s25LUXLHY0L4OCteobkfATp3Tr6XdtcZo4OhXV5 BLVDwwvejdHcjbz/ueCcFupeoiEv+m7YzdYyq+eA5QNQ/qLJ8GDjP61K4vT0WbV5 wnnztJEpFchZPitps66buc7siaRjOtZbBJhB/9hznmMdzd7RZCNCpPepDqL3UFYg 6ee+8c4BdGVRbj1y5B7CsIxy7Sx6M0Z8W4eaYCDzuyPf3tGcKt+rMBPDrkb8a3Mx QwpHUp28zSD/tD55Z5eATbTn8t1mqqPCO7pQyX/JQXgTesqZw3G45Or6lvjO1rol 6Qavr0m2aU8dv/0pobkJti7ShK+fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjedugdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 Aug 2021 11:08:27 -0400 (EDT) From: Thomas Monjalon To: Tomasz Duszynski Cc: dev@dpdk.org, jerinj@marvell.com Date: Fri, 06 Aug 2021 17:08:26 +0200 Message-ID: <5776256.FH8VHCdSZe@thomas> In-Reply-To: <20210727131917.120743-1-tduszynski@marvell.com> References: <20210727131917.120743-1-tduszynski@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: relax headline prefix check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/07/2021 15:19, Tomasz Duszynski: > In order to avoid code duplication common code shared across drivers > is stored under drivers/common. > > Currently if one needs to introduce changes to common and particular > driver i.e common/driver and net/driver separate patches needs to be > prepared otherwise warning about wrong headline prefix gets printed. No please don't split patches just to make a script happy :) We can tolerate few warnings if not meaningful. But I agree it would be better to avoid such wrong warning. > In order to avoid that script should allow cases where changes to > drivers/common/driver and drivers/group/driver belong to the same patch. > > Signed-off-by: Tomasz Duszynski [...] > --- a/devtools/check-git-log.sh > +++ b/devtools/check-git-log.sh > @@ -80,6 +80,10 @@ bad=$(for commit in $commits ; do > drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) > drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then > + if [ $(echo "$drvgrp" | grep -c "common") -eq 1 ] && > + [ $(echo "$drvgrp" | grep -cv "common") -eq 1 ] ; then > + continue It means you allow one common subdir and exactly one non-common subdir. I think it is too much restrictive because it makes sense to change a shared code and several related drivers. Thanks for working on such improvement.