From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 529C62BA0 for ; Fri, 1 Jul 2016 14:16:18 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 01 Jul 2016 05:16:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,556,1459839600"; d="scan'208";a="1008909313" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.37]) ([10.237.220.37]) by orsmga002.jf.intel.com with ESMTP; 01 Jul 2016 05:16:16 -0700 To: "De Lara Guarch, Pablo" , "Ma, Pengyu (Wind River)" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" References: <1467363156-70973-1-git-send-email-pengyu.ma@windriver.com> From: Ferruh Yigit Message-ID: <57765F0F.10602@intel.com> Date: Fri, 1 Jul 2016 13:16:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Fix misleading indentation in ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 12:16:18 -0000 On 7/1/2016 12:29 PM, De Lara Guarch, Pablo wrote: > Hi Pengyu, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pengyu Ma >> Sent: Friday, July 01, 2016 9:53 AM >> To: thomas.monjalon@6wind.com; dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] Fix misleading indentation in ethtool > > You need to add the library that you are fixing in the title: > i.e. kni: fix misleading identation in ethtool > > >> >> gcc complains about: >> build/lib/librte_eal/linuxapp/kni/e1000_phy.c:3303:2: >> error: this 'if' clause does not guard... [-Werror=misleading-indentation] > > Could you tell me which gcc version you are using? > >> >> Code indentation is misleadingly indented as whether >> the following content is guarded by if or not. >> With the reference of the context, add the curly braces. >> >> Remove unused const variables too. > > You are fixing part of a library, so you should add a fixes line here. > Please refer to the following document to know how to do it: > http://dpdk.readthedocs.io/en/v16.04/contributing/patches.html > >> >> Signed-off-by: Pengyu Ma >> --- >> lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_phy.c | 9 ++++++--- >> lib/librte_eal/linuxapp/kni/ethtool/ixgbe/ixgbe_82599.c | 8 +++++--- Also these files fixed with following commit: "cba50f6 kni: fix build with gcc 6" Thank you for the patch, but it seems all issues addressed in this patch already solved in master branch. thanks, ferruh