From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9D0A319F5
 for <dev@dpdk.org>; Fri,  1 Jul 2016 17:54:52 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 01 Jul 2016 08:54:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,557,1459839600"; d="scan'208";a="838748407"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.37])
 ([10.237.220.37])
 by orsmga003.jf.intel.com with ESMTP; 01 Jul 2016 08:54:49 -0700
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
References: <1467372912-31113-1-git-send-email-ferruh.yigit@intel.com>
 <1467385678-16205-1-git-send-email-ferruh.yigit@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973C984C1A@IRSMSX108.ger.corp.intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57769248.3010209@intel.com>
Date: Fri, 1 Jul 2016 16:54:48 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C984C1A@IRSMSX108.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: fix possible mmap failure for
 Linux > v4.3
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2016 15:54:53 -0000

On 7/1/2016 4:52 PM, De Lara Guarch, Pablo wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Friday, July 01, 2016 4:08 PM
>> To: dev@dpdk.org
>> Cc: Stephen Hemminger
>> Subject: [dpdk-dev] [PATCH v2] igb_uio: fix possible mmap failure for Linux >
>> v4.3
>>
>> mmap the iomem range of the PCI device fails for kernels that
>> enabled CONFIG_IO_STRICT_DEVMEM option:
>>
>> EAL: pci_map_resource():
>>          cannot mmap(39, 0x7f1c51800000, 0x100000, 0x0):
>>          Invalid argument (0xffffffffffffffff)
>>
>> CONFIG_IO_STRICT_DEVMEM is introduced in Linux v4.4 and not enabled
>> by default:
> 
> This was introduced in kernel 4.5 (change the title as well ;))
"git describe" mislead me but you are right, I will update

$ git describe  90a545e
v4.4-rc5-2-g90a545e

Thanks

> 
>> Linux commit: 90a545e restrict /dev/mem to idle io memory ranges
>>
>> As a workaround igb_uio can stop reserving PCI memory resources, from
>> kernel point of view iomem region looks like idle and mmap works
>> again. This matches uio_pci_generic usage.
>>
>> With this update device iomem range is not protected against any
>> other kernel drivers or userspace access. But this  shouldn't
>> be a problem for dpdk usage module since purpose of the igb_uio
>> module is to provide userspace access.
>>
>> Fixes: af75078fece3 ("first public release")
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>