From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A6A9DA055D;
	Wed,  3 Mar 2021 09:30:57 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9454F40693;
	Wed,  3 Mar 2021 09:30:57 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id BBEE140691;
 Wed,  3 Mar 2021 09:30:56 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5148D7F589;
 Wed,  3 Mar 2021 11:30:56 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5148D7F589
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1614760256;
 bh=N8BD+O5XXG48n3eqL6n1S8HZJbR+wmLJd6UIbcxifTY=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=jLShkPY4bKC/LWgeRy/jwEZjWYWV7jYmNojScL3ro923rc1JhXfbJFzTK3QsuD8xd
 5Z26tbDeX2o2y+HhXzBfmGmPPHHqwWp/Z9/6LQkeb3E9V04V9+3LVZB75f7ojCXBW/
 nohawD33o2lbg7j/gcx9Stl/7dt0iOL2vSof2oM4=
To: David Marchand <david.marchand@redhat.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Andrew Boyer <aboyer@pensando.io>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
References: <cf6bb1eb3f5e4740b462998df559ce3b2247a3bb.1613757281.git.anatoly.burakov@intel.com>
 <CAJFAV8zkzLuTYdpWsiMFLBXMg-nwPpqX6Dj-SmJE-Y4uUBH_jQ@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <5778cbae-87ab-1aee-ea6f-e5964c796fb2@oktetlabs.ru>
Date: Wed, 3 Mar 2021 11:30:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8zkzLuTYdpWsiMFLBXMg-nwPpqX6Dj-SmJE-Y4uUBH_jQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/3/21 11:17 AM, David Marchand wrote:
> On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
>>
>> When file truncation fails, the log message attempts to print a path of
>> file we failed to truncate, but this path was never set to anything and,
>> what's worse, was uninitialized. Fix it by passing path from the caller.
>>
>> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
>> Cc: stable@dpdk.org
>> Coverity ID: 366122
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Andrew had reported it too, and proposed something close:
> http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer@pensando.io/

Not me, adding Andrew B. to recipients list

> I prefer Anatoly's version.
> If no one objects, I'll proceed with this one.