From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0070.outbound.protection.outlook.com [104.47.36.70]) by dpdk.org (Postfix) with ESMTP id E81903F9 for ; Mon, 4 Jul 2016 16:26:41 +0200 (CEST) Received: from BY2PR03CA039.namprd03.prod.outlook.com (10.141.249.12) by BLUPR03MB582.namprd03.prod.outlook.com (10.141.79.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.528.16; Mon, 4 Jul 2016 14:26:40 +0000 Received: from BN1BFFO11FD017.protection.gbl (2a01:111:f400:7c10::1:139) by BY2PR03CA039.outlook.office365.com (2a01:111:e400:2c5d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.528.16 via Frontend Transport; Mon, 4 Jul 2016 14:26:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD017.mail.protection.outlook.com (10.58.144.80) with Microsoft SMTP Server (TLS) id 15.1.534.7 via Frontend Transport; Mon, 4 Jul 2016 14:26:38 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u64EQZkc007849; Mon, 4 Jul 2016 07:26:36 -0700 To: Jan Viktorin References: <1462542490-15556-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-29-git-send-email-viktorin@rehivetech.com> <577397EF.2080300@nxp.com> <20160704150451.1a61fbbd@pcviktorin.fit.vutbr.cz> CC: From: Shreyansh jain Message-ID: <577A7245.700@nxp.com> Date: Mon, 4 Jul 2016 19:57:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160704150451.1a61fbbd@pcviktorin.fit.vutbr.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131121159991640525; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(24454002)(377454003)(189002)(199003)(83506001)(64126003)(93886004)(356003)(4001350100001)(68736007)(110136002)(586003)(85426001)(92566002)(2906002)(81156014)(4326007)(8676002)(106466001)(105606002)(230700001)(81166006)(65956001)(65806001)(69596002)(19580395003)(19580405001)(47776003)(97736004)(6806005)(87936001)(305945005)(86362001)(23746002)(54356999)(7846002)(50466002)(65816999)(76176999)(50986999)(104016004)(77096005)(33656002)(2950100001)(8936002)(36756003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB582; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD017; 1:dyB2FLL1/fLdLJ3gbqo0fztdxp/UjyhSGx4Na0lBykLMjaTgsIS1uExUq98sPbSNZzZenmA8z4T2jwCdrpb9UlY8O0IEQPStnKMif7CTrjpZkb8yCaUiryrAOkY+wD9wRr0As7obUt5TgyoMd4o3qhZdgQbrkf7SugAqMguE39fiKmVQ9DDDR+QwHlGGAx3bKBS7iL/CEG4h1/qq56JfC5FLiH+635DZtzNIarT2XIYGXVCJFLbYQCwjHqWRW2Jl0SgHIUsVC03ts/w3/xbfXmmum7KB5m27DJmN2nyEncUHEYFg25gYlAPNIReJVVxxNXEJo0Jk8d33WWuR7EprDluzttsUH1a1PENiAzcSTbKuyIgHHhR7JtIyNumM0TliAapHytc/0FpwYP/kWTPT/HLk0LqdtJn25w4rEpGFXd5WKfNF3NRYw26NYeWp06xF2d9gDk0fnqv0BHTqoXlsvCA/cY2L6YdRlJX7r0zXc8HkEBf26fQWwE15DGlkQS+HVDjsMLnUBZ4nTjwII79ekeMvA+4r0xAQ4xRQhB8r3G3EZJWKIQmdhjo0jkw23z0mNI8g1nn5tTRzLWyhBv4F7w== X-MS-Office365-Filtering-Correlation-Id: 851a3ef1-7940-4ef4-606d-08d3a417364b X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB582; 2:yDyJAn3O80EEMBAqInPezPzK8s8lnSzwTdEqkBMaYa2/Sbr1MVzOlVSJ3FhDNAtzGbDntDC9v8leEJeQaPY4rv9KU8S7+awBGL4uBFA2uqEm0QBg2uG4QnfB6W3iE3E9BuSSjJuK6DcrGCD+o5t8zFAlG9Ap5ZNnHCsLDwIbFC8KS6ZX6fIEuqcOqrp3QuW2; 3:NNpfUgog+9vP6V/Z/QNN4wnRNa0psleqlBylMGBegWPmKSnqtTDqP1sjnBmPBQWVv4spx0IQ0ahoyaIuofDfmrQBeN45PPvpxKc8cpvx9JFBn4M+Nq3h6ac/MyN9QB8uUcm6w1AKqaEXvGBhXfiCfw76uqR6/AW1M1gq9Y6hrF25m0nAW5tqvJJi7n0WZszspO0HstAqO3UAN6WH8hxjixdd/Q3ObZ0bWcVZR7jB2us= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB582; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB582; 25:9agiG6VYwf06coUEeZRlHaugPgLGLK6pTigt5zQCZSkUQ7+sLkJUlm4qrwhSJkalKLv5V9KobLGF50Sgcl4sFN4/E0Y8bngy7Yb1zfk1XwrYW1q3oaiTDyZMioeY8C4tjRyKam/EN0NTmysvL5pl1P3ZyTZrrLpXWS7XEb/GBuFHpCkIn8Qgnp9kLcAjmE5OjOM1U72dtCL374R4IgCt9681M5tZySQjeyCdQO76GH6SD/Gt8Ddga766bdeqTwnWnpOkjzxd74DbTR9Q+RQjdZn2uTC/gS0yF6djgrddg6jtrcTUTERAU0WW3tSxnv4o+B57GoTDsVRredaC0If9Auc6AMgIae1akeu6apRGh/l2JeqvERAtrXDRchYz5cl26nOZvhAjLpa/NCtuJF9YHxT/HVKxkCZwtT40C5WSN6f2yR67lp7NDjpvv/FsbV9wk45za/efA4HkaYXodsJgSeZwisaW9xmftXV6GVSNhaJsnFKziSqnKrqOnO0bgQDUm7cf4mm501dElJ2iMegCJ0XVhCTxmfha4dN9zDhofZ4MaLROgH9xbJ8A2HYFexOJOCKtQBNox98UNr2fo+hT7p5ogSwj1T2DOkavLKyV12eUiWyvSXAu+e2khzHbsZjf1GRaT+3its06zDMnP/7Ri8tRuNSUFz+Z+LLBYv5KwCiYIY2D/Hlgi5IR+XEg5czMXtIMfcxJ9l81nRA3otirelTSFZti2IW22LafdTSooq8=; 31:eGl5nMomBdutj8TwSFXKChlPKrzS7UkWHKQxK7hT8LJR/lB+8EQyZQlWlYt5zpAastDqmiLgl8/fpt3XE5OpTU1VsL0sx0LmDMYN87zJ5RLVPd3eSireHMayB1qK9XTSwVCSvy9sBivEcbH3u1sJImOxdCzrf4JZObKdQHkTBqHhJKQSZJfbM24ugQul0rtzOMK9pj69/aeZqES6C0EOng== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13018025)(5005006)(8121501046)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026); SRVR:BLUPR03MB582; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB582; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB582; 4:jjqqNPZc9NxOq50PDS9alqTjWCjMdR/lbBHjOHrx3QTlriOlj3vhj7kuOpevOYsXNXLKDW3uOnzCSLPzn2XKWO66ntCWUHS9Pu6p0lqUfDaj2Ne3rJLy3kqluJFSdu51z9EizxFaTH2EX5vFiXcxKPduQGEYB6yFUAGI0dIE0KLdMcFqRFopQl8pSLf5puLEPMevxD7tSFHtWMGQYtQ4qBRriwN6AktW1s0DUnqdvhlcla0Wk+r7CGhWE56BdjUCLiHB2+z5n9Au1h/3PEo+8QvQaUOzYdFz5qpxJsEUXhQAfJ+fOEUKiAZ1Ti6E+LtzCoPrrorRE8f6QqVvUeRYQDYqVwWDd9eK1qtsR9W0I29m52Hg56Zp18a2F1sDRB7fsgf05hzpfdZKXVT1wblZZTOG50VZIxnnl6N4lQL3vx05MDhjfLOykhA6WnB6B4KL4Tsi5QI2Pf8p/BPMwWJFe86/7pmoqz4/u43YsKHh3BDHECl9HUcy5lPCjhXGcEalyG2lTjmyKCZAMv0ChwNfUw== X-Forefront-PRVS: 0993689CD1 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR03MB582; 23:UEpsBOhlCFN33aAj9KQLFH7gV3jLHf0lmwDjbF?= =?Windows-1252?Q?A8ZVY6NBo8ao0XfKz18kua2As3DEeHkZINGokIVk4RYtL7We/RfkmNLk?= =?Windows-1252?Q?1W/FycLKxOoX76Zjfdy3Vmiyj8Pm6RkW30JDTEVwRLoYOva1iWOmm71o?= =?Windows-1252?Q?z2rZK49hJ42gRqReilSYgNx5PjAHA0BlyW6erLSYYi+5K07gCseTCszB?= =?Windows-1252?Q?Qi6+DeROxeBCkCFWIbyKf8/Acu02iF0XD1/qfbXUtBcRQNQy6Y3IT6b+?= =?Windows-1252?Q?FU7zZ9w4MHH+7PUqYnEUH7DAsPFWq1vbOuHQu7rDaPH7y/5E1XEp3BlP?= =?Windows-1252?Q?jCZ7kDKK9SQyoYC3lHnoGiko3TrGI2Psi5TfAOJse4/VWoPC34rjF3MN?= =?Windows-1252?Q?HqlM+Ckgo/fxefaKlEjEYXPlxQqYvVfUfZLfGPR2+r5egueIjASXkSa7?= =?Windows-1252?Q?Rug5mvqIQtO7JX+mJDVaCmjHrLXvM1q/lpHcL72oMyYRmTuEKCixgCVK?= =?Windows-1252?Q?qungtt/tbERKvIgRS5j34DwHyiK3MU5BabVRXQ2j84RmVJ6JHer61R6Y?= =?Windows-1252?Q?+Irimy462pKkWSpr1Bk0T8dSePMY3VHXFM0q2F8aEa864hY0otRBKB6o?= =?Windows-1252?Q?fF8QLFnls/Hc6X6rj8PnqjUG9JMqlmi54+sXS5z4l7ASqQ74mwv/Zory?= =?Windows-1252?Q?BX/j2Wc5qvRMZOl8dMMzYtXaINvGIiPlrLdfEqSGu6MwYPv6Tdyfz8rv?= =?Windows-1252?Q?wJDORX6TNkUfu/YLY7ro9RyXXl6XuCiNzHjYAMPwRf/SNLAlagG9mOCk?= =?Windows-1252?Q?USulzbwNSMa+2zjvktUj37ywiWmExqSTQIqLM+bzWLgOqjJhnLUz4b1B?= =?Windows-1252?Q?7u9ir3Y8k0JycIjOU421UK7d+DepFMrU55I6870USliaHA9uc7roYBYR?= =?Windows-1252?Q?c2ljCXVzy5OXMd5lY07LF8D6bmUFGXvkO8hE+HAV//k/5GCG/1gRS3pc?= =?Windows-1252?Q?V3xe28qCVAad7TCHoKqw4mh0fIzNF6Dm6uGNrckqBYcvf7jltcPSC8Ws?= =?Windows-1252?Q?GtNI5PW+MUrj97q4ic7LPfJk3ta6520h+S2wgLxbQqjT+0mxq4ev8nLS?= =?Windows-1252?Q?0JaXGZvBSroFKCD1AkoVmkK7dZWNGG8KrUzwCf2HKVVUiz3E6ls1uI4M?= =?Windows-1252?Q?00dGnuhE+2hRMup9Z915F1H48ixQxoQ5I1LFPV0dm2cY+JIjslFFznGt?= =?Windows-1252?Q?/9te//xasIJSoCm42Kk8DjngK5p6LgSQPfWTpPHNTTuVnzZ6mv7M7BXQ?= =?Windows-1252?Q?gsTfD2DtQeojPdGyVrf1J0HlwjSnC+eCGxr/iDlwacffbni8slPGyvIc?= =?Windows-1252?Q?bbvpfC5RiD?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB582; 6:oCYluRcrNlwCHHnxVDvhMRH8ot+BsnktF1F7CDIAO/4u+bHODXqdb6VwIaH/6SQQrYUO2BcVjkJnbpQzv4DO4SqVAV9cp16S3b6WuIblYfnGLQc0Ui/jx9A0FGo2cneF2iTllbMDthRM8Md/4qVPgdVPaWeBgsLdeniE2VEvop+tjJ+BWF5S8sqxaAJDM9rszvugDOC0nF8krzdV5PLXxuDKD67G0h96a9yaHo2DnpoLbMl9xqS0r98PmyU62msm9qjAlbXvcZS2wlGZlnHWhB30c+pCihAtrzDKxlMgNYU=; 5:QcH0QGtfph9mGB14RlmWUrkF16ZsiHwEMea3nzB3HIIUPJeYwkqjhbtKRhQ0ccvyMi9MzSwIu/VOx5fMm6zcr4vtaiZHRi1uNAswn3mm5lQvZDU/frXjpBSCkuWOjDWJ50/QE+sN+ALQHij+/Hm8B6dvm2+FqNDmBxoJHpvJfY8=; 24:oraMvOFGKbd/2Rs90Yh1tMzXqMrT4p8oE6Rv9SpyKQcr6p9lo1sscDl79nD/mFmds3Mr0D6OPvqL9rfYV8rEjy3fSURYI66HLGryF4q+So4=; 7:ck9xpto4jXkN61uafJeQRRos7oOBLKrPAwYddChO1ruQQlgkhQfq3MOnZo+d+6Inlms5jlTyeDZXqV4AiSea5SluKoodH92d895Y7PSyc89ui1obvbWu9FFXEl5h8+MSrsfzrv/6prwEp5kfdIoJyKdbyokKNetblRWX29epGcoX+1tcRRVFPWfFuWjlvr621NTdc2+IXiIoVlSEpPpBo8M6peK8G9wORr80+y+KKyGQknTN/GxuzfA0MC3X7MPd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2016 14:26:38.2592 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB582 Subject: Re: [dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2016 14:26:42 -0000 On Monday 04 July 2016 06:34 PM, Jan Viktorin wrote: > On Wed, 29 Jun 2016 15:12:07 +0530 > Shreyansh jain wrote: > >> Hi Jan, >> >> On Friday 06 May 2016 07:18 PM, Jan Viktorin wrote: >>> Signed-off-by: Jan Viktorin >>> --- >>> lib/librte_ether/rte_ethdev.c | 127 +++++++++++++++++++++++++++++++++++++++++- >>> lib/librte_ether/rte_ethdev.h | 31 +++++++++++ >>> 2 files changed, 157 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >>> index 4af2e5f..9259c2c 100644 >>> --- a/lib/librte_ether/rte_ethdev.c >>> +++ b/lib/librte_ether/rte_ethdev.c >>> @@ -320,6 +320,99 @@ rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev) >>> } >>> >> [...] >>> +int >>> rte_eth_dev_is_valid_port(uint8_t port_id) >>> { >>> if (port_id >= RTE_MAX_ETHPORTS || >>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) >>> >>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>> - dev_info->pci_dev = dev->pci_dev; >>> + dev_info->soc_dev = dev->soc_dev; >> >> I think both the members, pci_dev and soc_dev, should be updated by this call. >> Is there some specific reason why soc_dev is the only one which is getting updated? > > Yes, looks like a mistake. Thanks! And sorry for delayed reply. No problems - thanks for confirmation. I have gone through almost complete series and as and when you rebase it, it would have my ACK. rte_driver patchset which I sent last are broken - I will publish an updated version very soon. > > Jan > >> >>> dev_info->driver_name = dev->data->drv_name; >>> } >>> >> [...] >> >> - >> Shreyansh >> > > > - Shreyansh