From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0060.outbound.protection.outlook.com [104.47.41.60]) by dpdk.org (Postfix) with ESMTP id 8C531902 for ; Tue, 5 Jul 2016 06:42:02 +0200 (CEST) Received: from DM2PR03CA0008.namprd03.prod.outlook.com (10.141.96.18) by CH1PR03MB1897.namprd03.prod.outlook.com (10.164.115.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.534.8; Tue, 5 Jul 2016 04:42:01 +0000 Received: from BN1BFFO11FD014.protection.gbl (2a01:111:f400:7c10::1:188) by DM2PR03CA0008.outlook.office365.com (2a01:111:e400:2428::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.534.14 via Frontend Transport; Tue, 5 Jul 2016 04:42:01 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD014.mail.protection.outlook.com (10.58.144.77) with Microsoft SMTP Server (TLS) id 15.1.534.7 via Frontend Transport; Tue, 5 Jul 2016 04:41:58 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u654fteL001933; Mon, 4 Jul 2016 21:41:56 -0700 To: Jan Viktorin References: <1462542490-15556-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-29-git-send-email-viktorin@rehivetech.com> <577397EF.2080300@nxp.com> <20160704150451.1a61fbbd@pcviktorin.fit.vutbr.cz> <577A7245.700@nxp.com> <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> CC: From: Shreyansh jain Message-ID: <577B3ABE.4040709@nxp.com> Date: Tue, 5 Jul 2016 10:12:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131121673197058501; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(377454003)(189998001)(47776003)(93886004)(59896002)(2906002)(11100500001)(81166006)(110136002)(81156014)(586003)(19580395003)(65956001)(305945005)(19580405001)(7846002)(64126003)(8936002)(80316001)(50466002)(97736004)(4001350100001)(69596002)(65806001)(356003)(106466001)(23746002)(105606002)(87936001)(92566002)(33656002)(83506001)(85426001)(4326007)(86362001)(6806005)(36756003)(2950100001)(68736007)(65816999)(230700001)(77096005)(54356999)(76176999)(87266999)(104016004)(8676002)(50986999); DIR:OUT; SFP:1101; SCL:1; SRVR:CH1PR03MB1897; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD014; 1:IvVhyUQaA1hhQzoHKvEHQ4uItI5yRor7Mc8sGmyCoCBJRB+NUkPMo/dPAsxRuhO1f4M6gbqQMw6XHkeOH/LLJYDw/3wdeNJSJEXxs3P3kru2joppiJMh/SOOqUT8exFNEnfQkfCZSfg+Dh6lfXMiv/OhBOue3f8lnZdfi3kWp5jxpVRNu1UDR1NsZkSRdUaOB5TykHChOopWaY1Rn1jjulriAdephJj4zvGQvHm52adYQmCppzVc1/kh+shBzLydcLsu3t1OIBVDVg3UVO/nEbQwiL4zPPKnlfceX3Aj+jIGY9UOuR1Od7rO6oao1NRVZPO2HQRwZcIr0L4KBGKbqbYg5xxSWjL87Jel6hrk6CmcVI8CW6sTQaprwH1TFoFnE/y3G6YI4FzdkozAUfH1jv+4LWFJcCPwMvdoNKYAE3cnnNk7NoRz4661ybsHqJwvXkq1ppWiMnb0YY2UleVYyVogsDWaDDedBtV7Xz9T9uPLeDs5g8qn3OYMOql72+vVtObIt+QcJAFBN/W3mCSOJXkdppkuYuFzojakuCqNu72IY4gvWWRS40dt5P6BkITwtLStmqihKI09qAprlj1Kdg== X-MS-Office365-Filtering-Correlation-Id: b712b797-5ec0-4f90-9864-08d3a48eb3b8 X-Microsoft-Exchange-Diagnostics: 1; CH1PR03MB1897; 2:dSHjej/J2gV7f2FO1ySlhnrjZakdUxxHv0aaFDZJCkAuaSwkAL9x2yGLPtlqcLpnHrIPULfYi7zDQjluVD9z9cARUwPEx1WX4EOQslKsG67ozDUyuWCqqPS9LeRqSB8fOCl6dmC8ZVTffCrDG8l80Id4nLoqUaqMqaEuZrbQ/I4CHkOWtcAXPK4p7j3Lf9Pd; 3:jq/QyTVOyvj0jumjdPayjB9KGVFY//QS6rIXzkMbhKA2VqIB+PbpQuVzU68z7j1auIKQfVbzvH3sqfo4VorOstyCywAz6BZFHXPLDt5ddO57CBgUIwXllyKkGHqzq8Lb8kiG6HOlzu2VOIzrpT4B+ab0dONKcW3ALN19eMgaU+RM1cnii/qdBadN/1LfHI5uL5V5rsrLnmtTI2o5VQNPojzXH9KJWpacHTIsKP9mMQ8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CH1PR03MB1897; X-Microsoft-Exchange-Diagnostics: 1; CH1PR03MB1897; 25:g6mJPrfHeB3hksEi738j+KXxu+JISnM2WDl6QMfYwwlHA+3fCMoIoI7pftgxwSO+Q30EJE3h5oKnsZp5esyb5LxMWdqjrLTMTtBwb4+oHtDmMRLY8CKA8zdy8Fi/AZ1vWKzndoxPHuG17afebzAjrVqwTid1XgCvfKs4m8UlcJhtdOPKiEpjEX4rO/TW51WxluimMBW9jkkxi8JdZynXgyzNWWcyVR9DHR9Ui+v9G7kzIErw1VtznvGZH1MOtskgPlIduWbMFu6GvbPbXMXR1082VwmtzENOYwpHRmocvd1Foh7NGIn/AvNRldIQWkVaIrDymveMZBnEBsXXbMJOfYGOQpY/EXHzrGyjweo32um/eJrzZPhLGqPuicOsJI9OphYfS2dYvJc3puIxE1E5jj0igd03duKm+L0XqQcsJ+w8en5prwQoHuMda5jEOmIsrv/TuOGLF1RRNWwFw9Nv08CiEN6EENxrBkbslpzvJ7L3fgeO07c1JLdIP30ifYprv052JvKnfI4OQx56QsUzroUDBN30X7RIZciSu1cs/LXD46WODG4K3CYg6606V2G+gkiDNa8Z3r52eoxZ9aMX6ST5cMmAMtkeC9tACE1iQMgR1Wo65tGht6pSfPwk+hDZBgYBkuT7F69VkXv67M8DB/1Q4y4BDz+Iao/aaNRyLz66GjWrY56/ihASxcmuszl5pS2F6JE5c+wVsopZgyTbDEOOcmH/gCeeWNTmoDjqnNU=; 31:g+BEjLoNvpCyCjO1dn7A8L+g0GuruGMIH+VoTmMJjKkMSLsRBrxyxaBJHgUCjVhJDKneeGMETy4teKzE/L1dVXBbeXS2n6ES8T2acoJMgzTl7ozynMZlEfug/yNI2+nSaBaLO4ywfpXNPdwy5DbzXUyydGqYyDY5hMael0ZqxoaEAqWax2ujp419hT6HUt2FogTGWTCSj3WAviYe8H17VA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13024025)(13023025)(13017025)(13015025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026); SRVR:CH1PR03MB1897; BCL:0; PCL:0; RULEID:(400006); SRVR:CH1PR03MB1897; X-Microsoft-Exchange-Diagnostics: 1; CH1PR03MB1897; 4:eCxjjuSlebqtllpRJmYrKvgQXaeJULk7Wzd1EPFVIgl5BaOCBDI7cX+dzqx0mdSZgYPFbqahZSHRbIm0daH652kLA04cNAk6rYX37cyv+GskqmLeqppjVkIN16aHLGMqmpk8GqW0TTbZ9pfXiAp9v1DOcgNqDu1fvwx4GItp7+CUhWyju4aS5NqmB5bsv4thEfDa9zGviYCnDjunKhyl9ZU44JFo/0lviqqN3xA1l5T4LFZzEn1UGSpKnJDTK6L+QzZqwwjPiz6HpKciOVp4tyvKtRjlO1Urb2b4tfdo3UFeATTgZpbMnkSuEimpAiHVA3rg/gYvY4pIcJ5mdte7uYDfkM9MjLC2PNc4D0cy5O8HfZ9d02IKwk9hQ/XZ26PMk2H75cAA+D6euNeE1SKe6CTvyBfNsoeMedhUTulO77ccALn3AnGLWLI/yfIRAGT9Av60PHVMvr4EAXUEkbzwwJmHcjW6TokGRinnLCt6ky/dSb5nuGyi07TZGfTP9JK5ksQbIMh32xgaSlGottGnSQ== X-Forefront-PRVS: 0994F5E0C5 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CH1PR03MB1897; 23:9bskUOJ/9nTi/mve3wN0G3ds8DEJ/6+aS11vh?= =?Windows-1252?Q?wQASFXTeBpPdyzIR+rCiBDPOr7JPY7Nd8kJN0hT4TPR7o1rbYM7akYTy?= =?Windows-1252?Q?Iy3L0sH/clNR13Ephx9Qm9JMqXnspv+gaFKfJJLYek5c28mrOdvH2mmf?= =?Windows-1252?Q?0QMwDjIYl9ZoljJ6zYsONcZmLHvkUIrNIcNWeY1rhwrOPx5ufqPeQmo1?= =?Windows-1252?Q?MW5fhXCKrhhZx57JP2cb/UWihvQjAdEOiOdRZvB30VkoM6803C/eejJI?= =?Windows-1252?Q?vSFz5JJbAOaw/NwR8m9nqC8ZZp7uD6/sI+1shCg+gFdGtl9s/xZ2Kb7R?= =?Windows-1252?Q?iusMqxzFYHmVsYXM5Gyj7XVLXUNObvhJ+aFkC867w9HePLWJTtLgIStO?= =?Windows-1252?Q?FV5bAVTiKe6ez0p/7XhcqY30/KzPb/aYsliu0OEgTaA5YaEPwqxXNI0e?= =?Windows-1252?Q?TavoaFajX9V8NprTGbQKpEea2dziYDHHk7IkucK1G0XQ6LbHfZJTD61k?= =?Windows-1252?Q?6n5eg0PyMJ5ONkfL3kKMJVlBiQJrdX/2BczcUFCN3PmJIcX+DoKhkyFQ?= =?Windows-1252?Q?sHdQxTANBq6pgSDkQRaLx4DWCR7SM197U/ey7s7ds4m462RqICQCZ+Bc?= =?Windows-1252?Q?04Uo4EsqL6W7ZM9voO+4T+9O0pihxhbjw5P8XGoQOYYo0oJmQ4Dnojge?= =?Windows-1252?Q?9Sz8j9/ZM02lr1wpd1Qj2kSCxVTvLiD2CGv5tAk+txa1iyrarsHestGV?= =?Windows-1252?Q?Mui2DsCPsv43PzkFWEUbNeG23oM5kG54ruVZHWkYWqQCkfnRM/CpU8QK?= =?Windows-1252?Q?Wi1UVQ/kO0tUmtf46dRWb6i0CxGpTIc4G6nEpmA/9oCp7oXp7mEqPTBa?= =?Windows-1252?Q?vW9JAJTYUpf2doLsF0YyrretLl++VsarXVyJ3PNDCBhEnCrzJI9pnz9r?= =?Windows-1252?Q?0NN2MswTb1qkyKY408Ne6flVzg+9uTMSAaHaxMjVtYbeMwnZFIQYldax?= =?Windows-1252?Q?Bx8RMi5ZPQG8bnaQAGcYil3IHcAC0vO7noJArQ8z8DctwhKYN98u4lyo?= =?Windows-1252?Q?t4asXKOSHZaMVGRfCiyvUQCC6xRT78MGxu2gUltECzY+3bCWVIOXPL61?= =?Windows-1252?Q?UIro7UmInp+2c/VWWbJjr7Q89i496j/gMetNv4qX3EL8f9hZwTNbQtCl?= =?Windows-1252?Q?kwYAof0zKoaOTS/s6nkC3nYXqBd77r8Mszq88WQNpQ6KEsSoJCBA9h9L?= =?Windows-1252?Q?voa2bOKLDB40nyo93VEQ2FfY+ZZHaVDdynnmHIPT/H807BrjrsC3dDVb?= =?Windows-1252?Q?cN39pqkK1vjZj9SJie2IkkKGj2AFbshsMacYLMdMC3fuz0S4QMJ0SFhJ?= =?Windows-1252?Q?M7fYMY4zNVaWN3WB7zFmh3k0gre4c+HeuMhEk/Oo+KpRbXnX3ORdjV4W?= =?Windows-1252?Q?3/ynGfJF7GL3XtuWb5PqtpyZuNS+WQKAz4VnJxkGg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CH1PR03MB1897; 6:eGfFbC+pFouMKuHkpFayyBSYuPqeK1rwGydetK5T8EcX8lPTqCf24SZLiZUjxFC5xWcqZdo342xoy0OsPa7/tibGtlsJEiCiQTiT0V9N/cvhjw3PBy7rgMvkr6nEM4F6EAlbgppWtM6QqM5F/9iGAJWSzBFOb0v7C986kfRW3SmIiGChgD6AuIQhB52GyMeqwz1HIXI2bK9jkctbLGlNhWRjUzflFi0tTbHqF7CRvAtExlSW11++ZBZQ5Yoi2Cp/ntrktqHCX745Bsni2aWpQ30Qwr7UGru1k2rDeAVPFD0=; 5:5I/chme++k034sulFErxfzgNkSjbIBxWq+YnVMnuVZKpY0ezDEgfevpfTMgcFZ/4YF7jtrNPsJJZC2rcdekRDvBzXhJFhJN3V8ld3IbtX3fIk9znDFYjYmYuOzYDiOvb8SqDSGFwdCTwfOarnvpuN+PjXSN9xOPVlwSvdNwxg9s=; 24:sR9h9cSux46EkzSbvjRcJIS5088CGJAx0R3FSX5V43WFu9JaXWpyU14m/I2glmNrz7LJjsDoIVjo88BAd4pO2y9HjDQ5ebUNv/r0bxQNgh4=; 7:D4OkgRwTj2xOE+Fg897KkEaedzC2H255URkFtxUQMIXBMsYdxFOcw55E9zD30vkiF16lJxKQpYygDYj+ClUUX4iKywZ7QH+dL96sFSXu2tDHuz91pHqNZwNGP83XAminEtXVPMnq99u08MMLuTDDszi4UV6IhXHeiKyL6qsixukzPH/x2FX8HcUjnHJEZry64BRVuRgf2FWDv6lC0D52nJuHRBnFjSxacw9qiqgkdtJkqgS9VSteZX4x2bMIzXRj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 04:41:58.8010 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PR03MB1897 Subject: Re: [dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 04:42:03 -0000 On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > On Mon, 4 Jul 2016 19:57:18 +0530 > Shreyansh jain wrote: > > [...] > >>>>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) >>>>> >>>>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>>>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>>>> - dev_info->pci_dev = dev->pci_dev; >>>>> + dev_info->soc_dev = dev->soc_dev; >>>> >>>> I think both the members, pci_dev and soc_dev, should be updated by this call. >>>> Is there some specific reason why soc_dev is the only one which is getting updated? >>> >>> Yes, looks like a mistake. Thanks! And sorry for delayed reply. >> >> No problems - thanks for confirmation. >> I have gone through almost complete series and as and when you rebase it, it would have my ACK. > > OK, thanks. That's what I am playing with right now. I've rebased on v3 of this patch. There will > be some more tests in my v2. > >> rte_driver patchset which I sent last are broken - I will publish an updated version very soon. > > I am surprised that you've changed the args to RTE_EAL_PCI_REGISTER... Are you sure about this step? > I wrote that I'll change it myself for v2 for SoC to accept name and pointer as it was originally for PCI... Really? Then probably I understood it wrong. I don't have any issues with the first one as well but just for slightly cleaner approach I thought of going with your suggest (or, suggestion as understood by me). Anyways the patch is broken and doesn't apply on master. I will push a new version (with revert EAL_PCI_REGISTER arguments) within today. > > Jan > - Shreyansh