From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 33778379E
 for <dev@dpdk.org>; Tue,  5 Jul 2016 10:52:17 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 05 Jul 2016 01:52:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,579,1459839600"; d="scan'208";a="1001118326"
Received: from nnguy21-mobl3.ccr.corp.intel.com (HELO [10.255.149.189])
 ([10.255.149.189])
 by fmsmga001.fm.intel.com with ESMTP; 05 Jul 2016 01:52:12 -0700
To: Jan Medala <jan@semihalf.com>, dev@dpdk.org
References: <1466510763-19569-6-git-send-email-jan@semihalf.com>
 <1467299099-32498-1-git-send-email-jan@semihalf.com>
 <1467299099-32498-7-git-send-email-jan@semihalf.com>
Cc: bruce.richardson@intel.com, Alexander Matushevsky <matua@amazon.com>,
 Jakub Palider <jpa@semihalf.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <577B7539.3000007@intel.com>
Date: Tue, 5 Jul 2016 09:52:09 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1467299099-32498-7-git-send-email-jan@semihalf.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2016 08:52:17 -0000

On 6/30/2016 4:04 PM, Jan Medala wrote:
> Signed-off-by: Alexander Matushevsky <matua@amazon.com>
> Signed-off-by: Jakub Palider <jpa@semihalf.com>
> Signed-off-by: Jan Medala <jan@semihalf.com>

The compilation error to fix is [1], it may be good to add what to fix
into commit log.

[1]
== Build drivers/net/ena
  CC ena_ethdev.o
/tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): error
#188: enumerated type mixed with another type
        struct ena_com_create_io_ctx ctx = { 0 };
                                             ^

/tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): error
#188: enumerated type mixed with another type
        struct ena_com_create_io_ctx ctx = { 0 };
                                             ^
...

> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,
>  			      __rte_unused unsigned int socket_id,
>  			      __rte_unused const struct rte_eth_txconf *tx_conf)
>  {
> -	struct ena_com_create_io_ctx ctx = { 0 };
> +	struct ena_com_create_io_ctx ctx =
> +		/* policy set to _HOST just to satisfy icc compiler */
> +		{ ENA_ADMIN_PLACEMENT_POLICY_HOST,
> +		  ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 };

Trailing "0" are not required, compiler will take care of them.