From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1A3915921
 for <dev@dpdk.org>; Fri,  8 Jul 2016 11:57:02 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP; 08 Jul 2016 02:57:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,329,1464678000"; d="scan'208";a="842683613"
Received: from lcteoh-mobl2.gar.corp.intel.com (HELO [10.255.150.176])
 ([10.255.150.176])
 by orsmga003.jf.intel.com with ESMTP; 08 Jul 2016 02:56:59 -0700
To: "Wiles, Keith" <keith.wiles@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <cover.1467715254.git.adrien.mazarguil@6wind.com>
 <cover.1467905466.git.adrien.mazarguil@6wind.com>
 <10B01822-557C-400A-A6BE-DBFF60AF90E4@intel.com>
 <20160708080543.GB7621@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <577F78E9.8020705@intel.com>
Date: Fri, 8 Jul 2016 10:56:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160708080543.GB7621@6wind.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 00/11] Fix build errors related to
 exported headers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jul 2016 09:57:03 -0000

On 7/8/2016 9:05 AM, Adrien Mazarguil wrote:
> On Thu, Jul 07, 2016 at 06:33:17PM +0000, Wiles, Keith wrote:
>>
>>> On Jul 7, 2016, at 10:49 AM, Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:
>>>
>>> DPDK uses GNU C language extensions in most of its code base. This is fine
>>> for internal source files whose compilation flags are controlled by DPDK,
>>> however user applications that use exported "public" headers may experience
>>> compilation failures when enabling strict error/standard checks (-std and
>>> -pedantic for instance).
>>
>> Do you try compiling these changes with CLANG and/or ICC compilers?
> 
> clang/clang++ yes, works fine. I did not try with ICC however.

I tested with icc, getting following error [1], compiler warning seems
valid, but didn't investigate what in your patch cause this.

[1]
.../app/test/test_table_acl.c(487): error #2405: array of elements
containing a flexible array member is nonstandard
                struct rte_pipeline_table_entry entries[5];
                                                ^

.../app/test/test_table_acl.c(492): error #2405: array of elements
containing a flexible array member is nonstandard
                struct rte_pipeline_table_entry entries_ptr[5];

> 
> Note that considering "({ ... })" is a GNU extension, compilers that do
> support this syntax also support the GNU __extension__ keyword. As a result,
> those that do not support this keyword most likely already cannot compile
> DPDK at all.
>