From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0076.outbound.protection.outlook.com [104.47.36.76]) by dpdk.org (Postfix) with ESMTP id 658F8914 for ; Tue, 12 Jul 2016 10:44:43 +0200 (CEST) Received: from DM2PR03CA0046.namprd03.prod.outlook.com (10.141.96.45) by BN1PR0301MB0771.namprd03.prod.outlook.com (10.160.78.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.539.14; Tue, 12 Jul 2016 08:44:42 +0000 Received: from BN1AFFO11FD036.protection.gbl (2a01:111:f400:7c10::173) by DM2PR03CA0046.outlook.office365.com (2a01:111:e400:2428::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.528.16 via Frontend Transport; Tue, 12 Jul 2016 08:44:41 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD036.mail.protection.outlook.com (10.58.52.240) with Microsoft SMTP Server (TLS) id 15.1.534.7 via Frontend Transport; Tue, 12 Jul 2016 08:44:40 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u6C8ic7S032430; Tue, 12 Jul 2016 01:44:38 -0700 To: Jan Viktorin References: <1462542490-15556-1-git-send-email-viktorin@rehivetech.com> <1462542490-15556-29-git-send-email-viktorin@rehivetech.com> <577397EF.2080300@nxp.com> <20160704150451.1a61fbbd@pcviktorin.fit.vutbr.cz> <577A7245.700@nxp.com> <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> CC: From: Shreyansh jain Message-ID: <5784AE1D.1010707@nxp.com> Date: Tue, 12 Jul 2016 14:15:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160704163646.45d1f0f8@pcviktorin.fit.vutbr.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131127866805414718; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(377454003)(24454002)(7846002)(8676002)(87266999)(230700001)(36756003)(50466002)(4001350100001)(356003)(65816999)(80316001)(81156014)(15395725005)(15975445007)(8936002)(19580405001)(47776003)(105606002)(19580395003)(104016004)(81166006)(33656002)(77096005)(189998001)(65806001)(64126003)(86362001)(76176999)(54356999)(50986999)(305945005)(65956001)(23746002)(2906002)(4326007)(2950100001)(83506001)(87936001)(85426001)(68736007)(586003)(97736004)(92566002)(59896002)(106466001)(110136002)(6806005)(93886004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0771; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD036; 1:xXNKU6YAuz6cvIB5Nxvi9/ZsLn67wKCFq8e2oUsMztJdlmegKDNXfJuDLFl/VWCo1PmgxAsYHL3FDh2kqDSfmpUr8CKlkVtzOUsSdQkd2Kfj9eUsRZ3Od/FAq4lcymIvyOvhm4PmYSiWsoBQ74pwo9jfY1gvq1o4G+XORAJUbTxl9BKGBpB6+iaPGJ2ZcXmFGMB4+PWu6YQ4IyOSOQt49Qn61Xo5eJHsMbfjkOcD96AmJS6j/X++l4pkFNdY4bNxLnb1sDVJEYd3pZSxS35x6eMv1lx5o8bD4rRrJFs4RtwNu8iuy9Eb2j9pyOW2NYIiqBEE0bFrL3SnM7jHcVGEOhnRVRC7lt9iTTeDVeIUn+/dJ531FraVqUsnB4Mo0EWNQdMJuYUUmkl5UnkGOfEWg+HKDzE0tiVsOvCqz3PAdxwuoACnnHiIwtUxpQqA4DCBn/fIF1s/fRUnxSNENuyXyVyuFOUXHQVLFT853GNghmlCmVTv2hpmRDdqKdV6D1xf8WDHXFzlgoWPAV4fyfmust0wRVnwMEiD9IRrReuZTz7W554EXydLbsPDEuGbh95sOjDTIKsPzhcMYU6GlGpodQ== X-MS-Office365-Filtering-Correlation-Id: 006709ad-c82c-4425-09dd-08d3aa30c38c X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 2:/Q76DD+EYEWS7akOPvmBtTrcxCQZ1tjNVGTnHt3w03V4Bh3My2so+9fvvEpRr2fMStVEwEt4LN3P2LjEvozXo3dtvtxfBeGoUwR4uhPnC2EzmwQ8tbTxUxZKf6K3jGd8NQC8tiGN9OiDks03FpGnCtk3RVA6KF5gSlO6TkXvBXIZejY2XUH04FtwZCuOQ68j; 3:LU61ZvP1cXFYDPSPU9ROrhEFwnrKozixw4MuqucTallAFeSoNhvjcCxkbAytnNLJQ2O3g+h4ZwhzkgMJDgGC/CqlP9e/4bgkp9JsmcJY5z+JWSOgPvJ54zP9e49bw4u5j9Ma+uzcmfbzxwPUxDEVOmhWjpMCHw6IEbnkcGRGO7x2qMf4PJTWjOjSK12BVov+XJmThZWtIPY+c5x6G0kEqXSa8cmuKm7YvExs4kj+mFY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR0301MB0771; X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 25:9BDkDtdM/Fgr1Vd66Ei3vf8ypFHwjAUhFKn4e2q0IFKbBBC5KhhX6jFp8EhG+9A0XO+5lMoEAk4uKhqPB0CyX9OH4FFaZrqzmDpB4MIo4BbdeKprBKJNZTGy2VeFDawFaayr4XwMgZBBAos+UhbfpeWhkEdMxFScWgKDCafgGUWJrvZgYCItt6NaQnRmRrgoH9aGnD2azCndFyibhksCoWK/1aSvx2rEph3ywyFeh7QC/l2FSCbM9RCwt+P4kQNSYmc/nYiF7/4ORvAa8N0rVfLzEmClVRb4OLX1Y2pawUhRAT8PNcdZTVQfFkWE3uNIWonkua2K6FQ6tWazQA1b7OuXRiLV1JtCaCohK24jctCSDTwvzxFQwMcwzvUMCTW3L8S0EGV6mwsgG7a++6i3DLwJ8JqK3xstMeMRsGCxW1fuXKCAgzutqiSCLSEIpXff6X2ehb2V2/Gcj877SHY3lUbuZ7BG0LgSFsdB2uaw1HBnE+Alo4bhvMnAEgpG2woQV59aY8OOSpooC6TYJNSdk0QUnWeqMwNtIBIu9qIqO+RVbGITQM41wP8Q9NgE3WwYxJtmClQ6NvFeVpUvCioeSDpiH6aoh3O33z/l9+eavWxKEl9ToCpMIA5T1WAXMUFWzmBDR2dHauZFsxTJqTl/vM78/GXyqcrrPwHV9SVCn8E2IP0JqKSAELxZUbgFSP/bQO+O8uz84YBpf9tnC7e6XSgyopBbXH4+ux9q9vRyOZxr2AXphJDG067Vk0YbsjZJrNCKm02J0AcP+aH5rcaUrwyl0iKhYd+v0nwXiAgJCksWD8DTt/4saAVt7ZXIG2ZD X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 31:/I//YKGVqcJEdwUThDe16DQ5cvKZe0+6Xb4dk+b3L6I8qz7+7yvRC6Ne0y6qYAhCthRlmcZJMKnYluzbrGI96WdV4jus+0jA3TINHCmUD8w/hWJY8nuQAWTI9d2wmfHVL6PSBfbJJKN8FKY9IBs1FJZGST6U3vlbErpwuxnpLPz8n8aq6TgNxZi03FidMH9l1rRKw+0vw8VC+ixRHx4/bw==; 4:Tn0AWAvKUHMwyOCw3L1i8X9uvkA5A7dSSs7QbFQayLpBryoodUTXyMfnuZa0P1pVXbCWCP3VPLyOKUN/6GqHJ9Gpbjolvkns1oVfzY3rcsKkxd1LJIaWAC66M5Q1KCS5hkFSaeKSubM362EqnmAgig5Bz6ARmZRMabFmcNYqQoD91BrpLOntTefrV8PfehArcEcVuU0g5DqNU/+xs35NEQldb304S+hVUEC/PA8X4hvyfr0F3sY64QCuj81YWJMtZ1m8AZEeeJ33+wmWd6qbMwZdYvrvUSD76xGmEjYexm+yJ3hX6e9x8QpvLDhkTK8xFNc13yf5JnXJsyXvIA1IQp+5oGVdte93p2piBMISbI5yPH8oqI/if985jc+pVRy7+rgnG3/n+SWc+WrOtYWpw4IYB0VJSyV0RePFwurR582Z6VhaJQ0RhslBo8t9q0JoPZqlZVFqTo59AqacE/nD0Pf0Xrdkp9FdpM/GvvRCN7gofmmFrhW8n/eIWxcgZlkYkPCg/nV9z9CE/pNLq2ZMbA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13017025)(13018025)(13024025)(13023025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BN1PR0301MB0771; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0771; X-Forefront-PRVS: 0001227049 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0771; 23:VQ8cXAZTJg1shBRBsFJuT6MYeWCjq79hZPE?= =?Windows-1252?Q?/ofGBE02BN7TSYb7yFLD0b2Fda7yi2lPBs3F82j14qxWRu4C8BYBm3Tt?= =?Windows-1252?Q?r/CUzmowgyIzImFR5kvjkS8cGNwil4n0lw33fk6CjKzKWhIybJUzav06?= =?Windows-1252?Q?dC/hBoIMRRZp/qu56QEfgN2OsNcxonrA2p+AI+Sde7AEr2lnQc5I5AgD?= =?Windows-1252?Q?AJCzjsZWzYwwZWpPml5B1diTWwI2+MfLVh98nbDvYVuauFeXjyEiACXg?= =?Windows-1252?Q?t/BQHbWmgijqUYQIHuVt9fxJd0M/8iuYEd2wLhjSL+QM8UX/46TWy/yk?= =?Windows-1252?Q?aEkqLUmsNYfi5R4LWjRRl7CdpLGwMLdBEz1+nvRv9RxCXltkd9f/soih?= =?Windows-1252?Q?09CwJwDEy5mTUBMovxgrLuEM3ttFzx29eIwz/WizVItEZpd4M5hraW6o?= =?Windows-1252?Q?W32w03P4oPHyQT0jfhJFdQOW7ZoPN6xbnnzKWpAE6OFSkT1yBbvZOFYa?= =?Windows-1252?Q?5v6SBAsAgmRhh26ZUhVqdPp1hdrd8MHEKSb+6EMa0JQ2ZDHJDg2qA4UU?= =?Windows-1252?Q?BW1AHyAmg1ZpHYxPBOpaqgR0KRWQ6rBWHzx9ywDPn4HAyVDPs6Szzwor?= =?Windows-1252?Q?s80GNNCIjHbkQxYyObeRMDs0Ir9lbwDRq6I4ArmndPQ/EhkRia8l0xFc?= =?Windows-1252?Q?/WEKILG0t9S4d9/Z89DT9JCy5cTeYAqX3gcE7sfZWmN7gWoGnXG54l2N?= =?Windows-1252?Q?oggyrGn9h/FKVoKUR4yLJ3JR0EYJ1UnpS8AC7ExpyHu8uCrdTbdGO7GI?= =?Windows-1252?Q?MFCBy6HIu/F8TpAEHP5vhzr6ecxbDQVSJTfBic56t8kprWPAVuFvjlJk?= =?Windows-1252?Q?4/AEIfPvw6LjE+UIbOHPnD4obXDAlJOYs2hkTajWTsJt3qUMSMBoyEOF?= =?Windows-1252?Q?qSGUjmGLQ+fxXrpNuCNko/oilya5o4Jcv9v4h3yjVC5wEZkac4fyNvK/?= =?Windows-1252?Q?WNzYwAPviGZ+aqgfzrIGKfe0J4Twk3zDUbFf/HmQjAqWEjuRMP21FuMr?= =?Windows-1252?Q?pX4JGe7DEgaQozmoMF9IDoknbtpmw20Il6A3YEZkEQhWPaeE28M1NhHR?= =?Windows-1252?Q?olxrZxPb8f+eAXFbXdFJFx5HPS1CRdu1zm4ylmp/QhYiozu6IB0Mj65u?= =?Windows-1252?Q?7osv+qUjfwmvUQmq7TAUx1JtGKcxBEKNPTTJ/x++vr2YpPO+iKICT7h0?= =?Windows-1252?Q?M2lCA7uw0quRhhoiZ7Sn/ZysfnptfBRG5f4tBbr1GXDrC0HvkivFDZ+2?= =?Windows-1252?Q?Pe+phPFBGIQYq2hMZLajDovNMoMpQtJpJWc0MH+KxeXSyNI7WjgZxbOy?= =?Windows-1252?Q?NT9rMNYGr1ARZ44gg4UqA1UE/mHXJBycJOcbYieSUIoyJphUg9Zo7Fj0?= =?Windows-1252?Q?u6XWAH8FOsIyjAJu10V7MAQN/K0An6/gB0oU0Ct7Ndg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0771; 6:je4awzxlEuNmZI/rMK5lGu1lDsfr4HjeWwbS4DymlMQx0fRweL/zHHiq/XOyMZ5QZnnF1aNBqxrYJOmk5AAdBfxbCL0/T3kjTCfuAL4SRw6QmWmCAs1jl2NaVxRWmdXc25qd6wS8taHLEYJPQ2bpa4URdYlqGJz3QbIFbK7LOV3SlVa5JpinphiqwvuvYb6HIeNhdVXioQGzIpIRTPbgiyBXWqnXzWEpo0b+J6eIPc5vbihkJHeVwjc+NoCoFhoTdeJOQDDRY9o5Pz0C9C2I2bTjjN5KfYVmPORMakNOOIw=; 5:E3kG94Ov2LxtKC8bIzXeTvhfQQCP6qiizUlu1Ri/tVFchYL3Z/ak4L2o8ymhJtPDLpH79gvx5Uj9zYjP0UrThWC9Dq8pzm/VkvMA5pec5/gJ+tvUa14bffNd7k16ttmEXdgranhtRd8rUQZ9aUw8OkeU422We1aKEXUeh0+KDBI=; 24:02ig8BsTYGDqE/dnG1FYvrQI2VnXZ0PZ/raTu4QUSf21cwteff6phQNnbJffKClvR2hmlG74LqHVU5DLyIbq8ku7O3knAGN9Z5+6ZDKGTIQ=; 7:kUW/qASMI7/lwl/IZkVHCbYMn49k8hamN/Lf70ItdjEXuwHf7vOBaAJOFN6FjPtK/Voy1D8UN+058JVnpIwbYwvkt+z+d8UHSs2EOGAEEkTTKvwpwcOkz4YjmKMSe+BtRrk8uqse0eONbVBYIEPlfPHwlp6dI64z3/Z/JCbBDBBtW9Q5OWZPGpz1Gci6lNn0n5uFEQjgD6+wXFTskAmEcBabXEFQLwYRN8Rna2ZAtGa1GH+XVEPhJCKB6eRuXcjC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2016 08:44:40.3698 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0771 Subject: Re: [dpdk-dev] [PATCH v1 28/28] ether: support SoC device/driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2016 08:44:43 -0000 Hi Jan, On Monday 04 July 2016 08:06 PM, Jan Viktorin wrote: > On Mon, 4 Jul 2016 19:57:18 +0530 > Shreyansh jain wrote: > > [...] > >>>>> @@ -1431,7 +1524,7 @@ rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info *dev_info) >>>>> >>>>> RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_infos_get); >>>>> (*dev->dev_ops->dev_infos_get)(dev, dev_info); >>>>> - dev_info->pci_dev = dev->pci_dev; >>>>> + dev_info->soc_dev = dev->soc_dev; >>>> >>>> I think both the members, pci_dev and soc_dev, should be updated by this call. >>>> Is there some specific reason why soc_dev is the only one which is getting updated? >>> >>> Yes, looks like a mistake. Thanks! And sorry for delayed reply. >> >> No problems - thanks for confirmation. >> I have gone through almost complete series and as and when you rebase it, it would have my ACK. > > OK, thanks. That's what I am playing with right now. I've rebased on v3 of this patch. There will > be some more tests in my v2. > >> rte_driver patchset which I sent last are broken - I will publish an updated version very soon. > > I am surprised that you've changed the args to RTE_EAL_PCI_REGISTER... Are you sure about this step? > I wrote that I'll change it myself for v2 for SoC to accept name and pointer as it was originally for PCI... I have sent across a v6 of the rte_device/driver change set. Can you see if that is in-line with your expectations as well as the series [1] posted by you recently? I was making changes for vdev but for now I have ignored them as your series already includes those changes. I used your patches and based them over the v6 rte_device patchset - besides some minor conflicts, its seems to merge fine. [1] http://dpdk.org/ml/archives/dev/2016-July/043645.html > > Jan > - Shreyansh