From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78AA2A053D; Mon, 27 Jul 2020 18:36:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2EE21BFE9; Mon, 27 Jul 2020 18:36:43 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 2111B1BFE0 for ; Mon, 27 Jul 2020 18:36:43 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id A0B99580274; Mon, 27 Jul 2020 12:36:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 27 Jul 2020 12:36:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= kpJqXmZAUqEKl2JxW7EkKr7ooKIKCNwzF6NDOU/A1EY=; b=OsVD68k1HeRnVHX/ 3AUE5WdKW34+oAfUYh4D715WY38xd9IJm+W9XFtTO/we2lAgKivnm5BXirifPAwD Bot6CkfZg8Bi0vdI+VR7af2C/JY9cc5Smlp2tXdaGalAFdoJL+l/jzDb9RCeYlXp X3UP54dEAgF+/7yeJCQbdtna8Z5gO76Ae+Zk0uefuMXNuBP54QQw2+5vz4SjpDjM bhFsRFz7pg6PdThfA5zSDZp5wJlEDUbb1ZWYXEQ4qo5CYspxsAkf3iqnx7fcSI/u NqlMXvAYQ6XX7x0YhyoXpiDiS/oSUObGn7YUfAd8KKSMhngH+nwidZ0M8zEZ7W2c R6kXzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kpJqXmZAUqEKl2JxW7EkKr7ooKIKCNwzF6NDOU/A1 EY=; b=IVMgL/ltDxBWIBYEP3GF0gOcDQsam70DOMWT5jA4NKYBR3GogeXcsVdRt PFW0Y3eaCjV+iTaSMkDYQpH3CJIU3YBUsc4CgZsnO3WFVviLZIbQ8/rqF5OSw68W kKU0MAZg49OcBvu1gQm2Vopugr0G3iw6FW8Wa/7kGsyyyxV4nvsP2diAckkMOaAy 3i1A9zQRJcACtVs+OsKAfBttgI76iwukAD/xoR+99188VKL1hvkP0eRJNfFZZTWR G/NAtqwuRZjlqtzf8FSnwVmCS3TSeP/mbk2l3LMVda0J+R5STs3UpINySzuayFp/ eyXr2G3MhxeSOKkLAez1JjWm0qLvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedriedtgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8FF393280067; Mon, 27 Jul 2020 12:36:31 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: Jerin Jacob , dev@dpdk.org, Jerin Jacob , Wang Xiang , Matan Azrad , Slava Ovsiienko , John McNamara , Marko Kovacevic , Guy Kaneti , dpdk-dev , Pavan Nikhilesh , Shahaf Shuler , Hemant Agrawal , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , Nipun Gupta , "Richardson, Bruce" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , Jim Thompson , "hongjun.ni@intel.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Raslan Darawsheh , Yuval Avnery Date: Mon, 27 Jul 2020 18:36:30 +0200 Message-ID: <5786423.RfgClu5ASO@thomas> In-Reply-To: References: <1595793496-73205-1-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] app/test-regex: add RegEx test application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/07/2020 07:12, Ori Kam: > From: Jerin Jacob > > On Mon, Jul 27, 2020 at 1:28 AM Ori Kam wrote: > > > --- /dev/null > > > +++ b/app/test-regex/hello_world.rof2 > > > @@ -0,0 +1,45 @@ > > > +# > > > +# rof_version: 2 > > > +# > > > +# date:20200210_164643 > > > +# > > > +# rxp_compiler:5.7.18007 > >=20 > > Please don't check-in vendor/driver specific file formats in the main > > repository. > > See below. >=20 > I fully agree with you that in normal cases such files should not be part= of > the main repository, but this case is different from the regard that this= test > can't be run without vendor specific files. I expect that each vendor will > add its own file for this repo. I don't think it's "different". As an open source project, we prefer dealing only with source files. We must provide the tools to generate required binaries. [...] > > > +Running the Tool > > > +---------------- > > > + > > > +The tool has a number of command line options. Here is the sample > > > command line: In docs, it's better to have each sentence on its own line. > > > + > > > +.. code-block:: console If you end previous line with "::" instead of ":" then you can drop the code-block line. > > > + > > > + ./build/app/testregex -w 83:00.0 -- --rules app/test-regex/hello_= world.rof2 > > > --data app/test-regex/input.txt --job 100 Don't write too much long lines in verbatim blocks. > >=20 > > Instead of giving the binary rule format, Primary option could to be > > compile the rule by the application itself. > > If the driver does not have such capability then the application can > > look for binary rule file in such case please don't host > > binary rules in dpdk.org. >=20 > Like I said above, in Mellanox case the rule must be precompiled, > (I think the same goes for number of other vendors) and it doesn=E2=80=99= t look > complete code, if we will just give the code, > and the user will have to download files from other places. >=20 > I think for this specific example and since the file is small we should a= llow it. No > What do you think?=20 We should provide all the tools. If the tool is external, it must become a requirement to run the app.