From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id AF6C43772
 for <dev@dpdk.org>; Tue, 19 Jul 2016 17:05:46 +0200 (CEST)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga102.jf.intel.com with ESMTP; 19 Jul 2016 08:04:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,390,1464678000"; d="scan'208";a="141917705"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.81])
 ([10.237.221.81])
 by fmsmga004.fm.intel.com with ESMTP; 19 Jul 2016 08:04:14 -0700
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
References: <1468857995-130392-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1468935637-39937-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <CAATJJ0LaBF2Q=KMGzBFR7M2=j8JgwWfJ803b9tmbMiYUEDriwA@mail.gmail.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <578E416C.7020306@intel.com>
Date: Tue, 19 Jul 2016 16:04:12 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <CAATJJ0LaBF2Q=KMGzBFR7M2=j8JgwWfJ803b9tmbMiYUEDriwA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] mk: fix FreeBSD build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jul 2016 15:05:47 -0000

On 7/19/2016 3:30 PM, Christian Ehrhardt wrote:
> Hi,
> the order changed, but IMHO actually it improved.
> Things are now at the place they were before, but with the overwriting
> config value that came later - that is the best of both worlds.

Agreed, this is a good solution. Also fixes multiple copy of file
comment issue ...

> 
> Tested a few config runs pre/post patch and compared them sorted (equal)
> and unsorted - now configs slotted in where they belong.
> Thanks for updating Sergio
> 
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com
> <mailto:christian.ehrhardt@canonical.com>>
> 
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
>