From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id C4DB33B5 for ; Tue, 19 Jul 2016 18:17:22 +0200 (CEST) Received: by mail-lf0-f49.google.com with SMTP id b199so18855342lfe.0 for ; Tue, 19 Jul 2016 09:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=7/jJ5sKEb0cGLhB0HEOfEMTHja8j184WViFTwDpfUEM=; b=c49BVfMwSj/vbDq4BDPNTKE+B7m6s0uDWwuWcFuXQd9v0lSZAjZ+dWjK09UHXjSwYi We7vJC3jXK2IrO+QI13ObxXKHUxK4Y5SjAYTaTzxxtAmFiVGdb7t8VmXdGHAsHo53q0L IVYQsIGyTLn8csQe15TkVu8iOsX4MAtKYiapA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=7/jJ5sKEb0cGLhB0HEOfEMTHja8j184WViFTwDpfUEM=; b=P5s+esSFsYeHTvNYZ2Bs780/PcXXaseRD35T3aaFYb5jfAu95z3XNaIIPgzt3BsNey o1TWXkSt7LSaUPumgnLD/YkLJyErU9mptL+x42H0bSB/Mcnt31afb6W+Ph/CslLxQ76l hAkthrUL4TcTsD91gbvDW5q6SsccIeeAmUUgjknbXgqb51Ns/6LyVjmjx0up1Q0m9Ij4 bAaZJJgP21H2AMqTI4ZbAxnlAgYELrQW8nvKO5jDRYb+LqvFbOCow5XbIUJVcYQor/ep r8cYaiWoqnrqWh0qPzYp9DV/ix7aLynP0RKT+V2hNhku72VBjqU5lljRSpHo3smydb1C ocng== X-Gm-Message-State: ALyK8tJWntJmPSU0ApNRzQjZtjWMO3mq9AhxhiH+e/hU/vJbXXqgkX7dwL1HvTzXoCkFFcvI X-Received: by 10.46.33.151 with SMTP id h23mr17100676lji.38.1468945042397; Tue, 19 Jul 2016 09:17:22 -0700 (PDT) Received: from [172.18.45.108] ([195.11.233.227]) by smtp.googlemail.com with ESMTPSA id g11sm4142637lji.25.2016.07.19.09.17.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 09:17:21 -0700 (PDT) To: Olivier Matz , Zoltan Kiss , dev@dpdk.org References: <1468939061-19734-1-git-send-email-zoltan.kiss@schaman.hu> Cc: David Hunt , Thomas Monjalon From: Zoltan Kiss Message-ID: <578E5290.3070100@linaro.org> Date: Tue, 19 Jul 2016 17:17:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mempool: fix lack of free() registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 16:17:23 -0000 On 19/07/16 16:26, Olivier Matz wrote: > Hi Zoltan, > > I ran ./scripts/check-git-log.sh on your patch, showing some minor > styling issues: Thanks, do you want me to resend it, or could Thomas fix them upon commiting? > > On 07/19/2016 04:37 PM, Zoltan Kiss wrote: >> [PATCH] mempool: fix lack of free() registration > > "()" should be removed > >> The new mempool handler interface forgets to register the free() function >> of the ops. Introduced in this patch: >> >> 449c49b9 mempool: support handler operations > > The format should be: > Fixes: 449c49b93a6b ("mempool: support handler operations") > > >> >> Signed-off-by: Zoltan Kiss >> --- >> lib/librte_mempool/rte_mempool_ops.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_mempool/rte_mempool_ops.c b/lib/librte_mempool/rte_mempool_ops.c >> index fd0b64c..5f24de2 100644 >> --- a/lib/librte_mempool/rte_mempool_ops.c >> +++ b/lib/librte_mempool/rte_mempool_ops.c >> @@ -81,6 +81,7 @@ rte_mempool_register_ops(const struct rte_mempool_ops *h) >> ops = &rte_mempool_ops_table.ops[ops_index]; >> snprintf(ops->name, sizeof(ops->name), "%s", h->name); >> ops->alloc = h->alloc; >> + ops->free = h->free; >> ops->enqueue = h->enqueue; >> ops->dequeue = h->dequeue; >> ops->get_count = h->get_count; >> > > Apart from that: > Acked-by: Olivier Matz > > +CC Thomas, I think it should be included in 16.07. > > Thanks! >