From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 04E612C8 for ; Thu, 21 Jul 2016 14:42:57 +0200 (CEST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAO008AN0NJU8A0@mailout1.w1.samsung.com> for dev@dpdk.org; Thu, 21 Jul 2016 13:42:55 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-76-5790c34f9b9a Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 91.C0.05254.F43C0975; Thu, 21 Jul 2016 13:42:55 +0100 (BST) Received: from [106.109.129.180] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OAO00H560NIB720@eusync2.samsung.com>; Thu, 21 Jul 2016 13:42:55 +0100 (BST) To: Yuanhan Liu References: <1469089275-15209-1-git-send-email-i.maximets@samsung.com> <20160721093714.GD28708@yliu-dev.sh.intel.com> <579099BC.9050603@samsung.com> <20160721101311.GE28708@yliu-dev.sh.intel.com> <5790A5D4.1090703@samsung.com> <5790AEB3.2010708@samsung.com> <20160721114016.GF28708@yliu-dev.sh.intel.com> <5790BBA7.6070202@samsung.com> <5790BC5A.2010505@samsung.com> <20160721123524.GG28708@yliu-dev.sh.intel.com> Cc: dev@dpdk.org, Huawei Xie , Dyasly Sergey , Heetae Ahn , Thomas Monjalon From: Ilya Maximets Message-id: <5790C34E.9030403@samsung.com> Date: Thu, 21 Jul 2016 15:42:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160721123524.GG28708@yliu-dev.sh.intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xK7r+hyeEG9x6o2Hx7tN2Jotpn2+z W7TPPMtkcaX9J7vF5NlSFl82TWezuD7hAqsDu8fF/juMHr8WLGX1WLznJZPHvJOBHn1bVjEG sEZx2aSk5mSWpRbp2yVwZcw6uJGxoIm9or3VvYHxCGsXIweHhICJxLHuqi5GTiBTTOLCvfVs ILaQwFJGibX7SrsYuYDsF4wS097/ZwdJCAtYS0yb+AKsSERAV+LpnHWsEEXLmSXmH9rEBOIw C2xklFgw9TRYFZuAjsSp1UcYQWxeAS2J32e3MINsZhFQlXj13QckLCoQITFr+w8miBJBiR+T 77GA2JxAy2ZfOMsOUs4soCdx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjKKppckF xUnpuYZ6xYm5xaV56XrJ+bmbGCHB/WUH4+JjVocYBTgYlXh4E1b2hwuxJpYVV+YeYpTgYFYS 4RU/NCFciDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYwq 1mzPjmumL/Np2zQhJNDfQJdXNcjiv9OmYwWKD8R5OMLPmlqLz60sOnlF6O4cdu0Wg7ynOreC tT/utWWQOXH+8MTnGmyNm/e3lPTuVXDRPybktl4213qBs5IvD0OOhCmr6KTqYyZeB+S9rp9I myAbGnZePbbmdpHrcz0GXamku61VsXLVSizFGYmGWsxFxYkALUh9jmoCAAA= Subject: Re: [dpdk-dev] [PATCH] vhost: fix connect hang in client mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 12:42:57 -0000 On 21.07.2016 15:35, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: >>>> >>>> What do you think of it? >>> >>> I found that we can't check connection status without select/poll >>> on it. 'getsockopt()' will return 0 with no errors if connection >>> is not still established just like if it was. >>> So, I think, the first version of this patch is the only >>> acceptable solution. >> >> Sorry, v2 is acceptable too, because it always calls 'connect()'. > > So you have done the test that it works? No, it's just theory. I don't know how to test this. > I'm more curious to know > could your above case hit the getsockopt() code path, I mean, the > path that errno is set to EINPROGRESS or EISCONN? As I already told, I don't sure that we're able to get EINPROGRESS on our AF_UNIX sockets. In v2 'getsockopt()' check is unnecessary.