From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id 4C56319F5 for ; Thu, 21 Jul 2016 14:58:14 +0200 (CEST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAO00EOX1D0DFA0@mailout4.w1.samsung.com> for dev@dpdk.org; Thu, 21 Jul 2016 13:58:12 +0100 (BST) X-AuditID: cbfec7f5-f792a6d000001302-6b-5790c6e4eb04 Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 6F.7E.04866.4E6C0975; Thu, 21 Jul 2016 13:58:12 +0100 (BST) Received: from [106.109.129.180] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OAO00INK1CZ5ZA0@eusync2.samsung.com>; Thu, 21 Jul 2016 13:58:12 +0100 (BST) To: Yuanhan Liu References: <20160721093714.GD28708@yliu-dev.sh.intel.com> <579099BC.9050603@samsung.com> <20160721101311.GE28708@yliu-dev.sh.intel.com> <5790A5D4.1090703@samsung.com> <5790AEB3.2010708@samsung.com> <20160721114016.GF28708@yliu-dev.sh.intel.com> <5790BBA7.6070202@samsung.com> <5790BC5A.2010505@samsung.com> <20160721123524.GG28708@yliu-dev.sh.intel.com> <5790C34E.9030403@samsung.com> <20160721125843.GH28708@yliu-dev.sh.intel.com> Cc: dev@dpdk.org, Huawei Xie , Dyasly Sergey , Heetae Ahn , Thomas Monjalon From: Ilya Maximets Message-id: <5790C6E3.9030704@samsung.com> Date: Thu, 21 Jul 2016 15:58:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160721125843.GH28708@yliu-dev.sh.intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xK7pPjk0IN2iexWfx7tN2Jotpn2+z W7TPPMtkcaX9J7vF5NlSFl82TWezuD7hAqsDu8fF/juMHr8WLGX1WLznJZPHvJOBHn1bVjEG sEZx2aSk5mSWpRbp2yVwZexqiSho46xYcnQDSwPjdPYuRk4OCQETiakvHrBC2GISF+6tZ+ti 5OIQEljKKLG//Q0jhPOCUWLplfksIFXCAtYS0ya+YAOxRQR0JZ7OWQfWLSSwi1li/vd4kAZm gY2MEgumngYrYhPQkTi1+gjQJA4OXgEtie+bQkHCLAKqEufXz2ACsUUFIiRmbf8BZvMKCEr8 mHwPbBcn0K6j77+wgLQyC+hJ3L+oBRJmFpCX2LzmLfMERoFZSDpmIVTNQlK1gJF5FaNoamly QXFSeq6RXnFibnFpXrpecn7uJkZIeH/dwbj0mNUhRgEORiUe3h2r+8OFWBPLiitzDzFKcDAr ifCKH5oQLsSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQZG 8bRj0/kqum55TghgTTmzY6GxtcXvfGYe612x0zR+KrdfCuj84CXQWroqy3uN8JyINBXJwAcK LhsNKh+Z39Coex8Rv4hh5ctH5j9z8rY5aW1SKXpT+OvI3qNCRbly6gdy14Zeu9iWn2jnG/GQ 65/0ec8c5vKlFauC/Q5lbmpZwjpB92vqkY1KLMUZiYZazEXFiQCHTfezawIAAA== Subject: Re: [dpdk-dev] [PATCH] vhost: fix connect hang in client mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 12:58:14 -0000 On 21.07.2016 15:58, Yuanhan Liu wrote: > On Thu, Jul 21, 2016 at 03:42:54PM +0300, Ilya Maximets wrote: >> On 21.07.2016 15:35, Yuanhan Liu wrote: >>> On Thu, Jul 21, 2016 at 03:13:14PM +0300, Ilya Maximets wrote: >>>>>> >>>>>> What do you think of it? >>>>> >>>>> I found that we can't check connection status without select/poll >>>>> on it. 'getsockopt()' will return 0 with no errors if connection >>>>> is not still established just like if it was. >>>>> So, I think, the first version of this patch is the only >>>>> acceptable solution. >>>> >>>> Sorry, v2 is acceptable too, because it always calls 'connect()'. >>> >>> So you have done the test that it works? >> >> No, it's just theory. I don't know how to test this. >> >>> I'm more curious to know >>> could your above case hit the getsockopt() code path, I mean, the >>> path that errno is set to EINPROGRESS or EISCONN? >> >> As I already told, I don't sure that we're able to get EINPROGRESS >> on our AF_UNIX sockets. >> In v2 'getsockopt()' check is unnecessary. > > We then have no reason to keep it? You want me to re-send v2 without 'getsockopt()' check?