From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 44DF647CE for ; Tue, 26 Jul 2016 15:23:17 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 26 Jul 2016 06:23:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,424,1464678000"; d="scan'208";a="853752500" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.125]) ([10.237.220.125]) by orsmga003.jf.intel.com with ESMTP; 26 Jul 2016 06:23:15 -0700 To: Thomas Monjalon , Igor Ryzhov References: <1469030873-5966-1-git-send-email-thomas.monjalon@6wind.com> <5790EB36.3000604@intel.com> <1531021.TGlYe7obp8@xps13> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <57976442.5060702@intel.com> Date: Tue, 26 Jul 2016 14:23:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1531021.TGlYe7obp8@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 13:23:17 -0000 On 7/21/2016 5:41 PM, Thomas Monjalon wrote: > 2016-07-21 16:41, Igor Ryzhov: >> On Thu, Jul 21, 2016 at 4:33 PM, Ferruh Yigit >> wrote: >>> On 7/20/2016 5:07 PM, Thomas Monjalon wrote: >>>> The out-of-tree kernel code must be avoided. >>>> Moreover there is no good reason to keep this legacy feature >>>> which is only partially supported. >>>> >>>> As described earlier in this plan: >>>> http://dpdk.org/ml/archives/dev/2016-July/043606.html >>>> it will help to keep PCI ids in PMD code. >>>> >>>> Signed-off-by: Thomas Monjalon > [...] >>>> + >>>> +* The ethtool support will be removed from KNI in 16.11. >>>> + It is implemented only for igb and ixgbe. >>>> + It is really hard to maintain because it requires some out-of-tree kernel >>>> + code to be duplicated in this kernel module. >>>> + Removing this partial support will help to restrict the PCI id definitions >>>> + to the PMD code. >>> >>> KNI ethtool is functional and maintained, and it may have users! >>> >>> Why just removing it, specially without providing an alternative? > > Because > 1/ It is using the shared PCI ids that we want to move > 2/ It has a poor support (igb/ixgbe) and makes users confused > 3/ It is a big import of another version of igb/ixgbe drivers I agree it is not the best design, but this is a functional piece of code, and as long it keep maintained or completely replaced I am for keeping it. > About the point 1, if we decide to keep KNI ethtool, please could you > duplicate the igb/ixgbe PCI ids in KNI? Sure, I am not aware of exactly what needs to be done, please show me. >>> Is is good time to discuss KCP again? >> >> I think good alternative is rte_ethtool library from ethtool sample >> application. > > Yes I think so. > >> But I am wondering why this code is only in app, not in lib. > > It is an example lib because we were not sure wether we wanted to > support it. But maybe it is time to discuss its status and check > if it can be integrated with other DPDK libs? >