From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D7DB41BBE; Fri, 3 Feb 2023 17:40:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93F344067B; Fri, 3 Feb 2023 17:40:45 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 04D384021E for ; Fri, 3 Feb 2023 17:40:43 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6EAF15C020A; Fri, 3 Feb 2023 11:40:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Feb 2023 11:40:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675442443; x= 1675528843; bh=W0E9Pz+g2pRDnJhSwWc2Sy/u/tsvaqtfNcaHMiNlQdU=; b=u IRUAI2Gi3r1djF3HarRuitAHDerXhys9eW72hq5dW8K9n3cn/FHcc+AOgWHZUgo/ dM36my92LPiLaSd0ZZ5b7NivgKQqhKrDmxCHF7rl0O3UTzMWb/z8T7p9m0rjXcgj zpcPIqlGQLaGboMQNoT+ZqqL3osRTsSdiT99yS/zxDlJ2ECqYHHIdBliFmlYBFZM aKM/39XbpJyCZA7A1nbbhNIGSMaCFVU+jTwxUWwxuW0gWQ7+lWgxzHwI86/YJXgj Egj6EK+rEtIt0M018GUVXo3oet3f02vqCJNCR+2Syld4N9GZuEx/NrDsruCVwO2V KqWZzYBwcvhl9vljUA/MQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675442443; x= 1675528843; bh=W0E9Pz+g2pRDnJhSwWc2Sy/u/tsvaqtfNcaHMiNlQdU=; b=d 70qWR5j2kZRUQ21XHLIAPIRjUZUTSJ7gMTRj9QGlptV1EQcHaGvoTQ9rnZcJKOPA 4d3DAhTXvhrOmL1OGxhFMP2mk0dnRAeQRZs2KqbuqhA9UQweMOzDf30WmVDhNA/M I8rRkJOIxev9QCo4FhPOunVcDwdifcTYXIrQEtb+HM94UCUdV0qSeJQgYJwYKLNi +YLsKe3C51UAXCb8tZFQD74+c2UKXUNFkZDDErwB+f82RrGfYpqA4xMXQxwwynoU LqEQXp4JrwQH0BBfMYZoLkxt2ws3KtroM8RMchKo/ZbSPIOAQ4U5PF0D7iZqES/X XuRj23dzy4idMs/15Z1+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegtddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Feb 2023 11:40:40 -0500 (EST) From: Thomas Monjalon To: Nicolas Chautru , "hemant.agrawal@nxp.com" , Sachin Saxena , Gagandeep Singh , Sunil Uttarwar , Bruce Richardson , Conor Walsh , Chaoyong He , Niklas Soderlund , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Rosen Xu , Tianfei zhang , Honnappa Nagarahalli Cc: "dev@dpdk.org" , Ferruh Yigit , Andrew Rybchenko , "david.marchand@redhat.com" Subject: Re: no printf in drivers code Date: Fri, 03 Feb 2023 17:40:39 +0100 Message-ID: <5799302.MhkbZ0Pkbq@thomas> In-Reply-To: References: <3217725.44csPzL39Z@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/02/2023 17:18, Honnappa Nagarahalli: > From: Thomas Monjalon > > > > We have too many drivers using printf() instead of rte_log(). > > Please propose a plan to replace or remove the calls to printf(). > > If no plan, I could propose one but you may not like it :) > > Does it make sense to add scripts to CI to capture this issue? > In general, we do not want printfs in DPDK code (other than tests, sample apps?) It's difficult to automate because printfs are acceptable in dump functions, selftest, and testpmd code hosted in drivers directories.