From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B0DEE2B91 for ; Thu, 28 Jul 2016 17:26:45 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 28 Jul 2016 08:26:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,434,1464678000"; d="scan'208";a="1030888114" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.150]) ([10.237.220.150]) by fmsmga002.fm.intel.com with ESMTP; 28 Jul 2016 08:26:45 -0700 To: Wei Dai , dev@dpdk.org References: <1469081018-55300-1-git-send-email-wei.dai@intel.com> <1469618870-144592-1-git-send-email-wei.dai@intel.com> From: Ferruh Yigit Message-ID: <579A2433.1060701@intel.com> Date: Thu, 28 Jul 2016 16:26:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1469618870-144592-1-git-send-email-wei.dai@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 15:26:46 -0000 On 7/27/2016 12:27 PM, Wei Dai wrote: > With --lcores 'a-b@c-d', eal_parse_cores() fails because > eal_parse_set() fails due to the next character after > lcore set a-b, which is '@'and not ',' or '\0'. > There is also a right check immediately > after this incorrect check. > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > Signed-off-by: Wei Dai I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is supported and already working. It looks like a-b is only planned to use without @ and the usage a-b@c-d, like 1-2@4-5 implies to me: 1 -> 4 2 -> 5 but it doesn't work that way, it is always grouped after @, like it has parenthesis, what it does is: 1 -> 4,5 2 -> 4,5 Even a-b@c is not working, but as I said if @ will be used, using grouping seems more proper to me, like: (a-b)@(c-d) (a-b)@c So this is mainly about defining the syntax, more than implementing it. Somebody know more about syntax can comment better. Regards, ferruh