From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0057.outbound.protection.outlook.com [104.47.40.57]) by dpdk.org (Postfix) with ESMTP id 457992BDE for ; Mon, 1 Aug 2016 12:59:20 +0200 (CEST) Received: from BY2PR03CA059.namprd03.prod.outlook.com (10.141.249.32) by SN1PR0301MB2062.namprd03.prod.outlook.com (10.163.227.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 10:59:17 +0000 Received: from BN1AFFO11FD009.protection.gbl (2a01:111:f400:7c10::147) by BY2PR03CA059.outlook.office365.com (2a01:111:e400:2c5d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 10:59:17 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; rehivetech.com; dkim=none (message not signed) header.d=none;rehivetech.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD009.mail.protection.outlook.com (10.58.52.69) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 10:59:15 +0000 Received: from [10.232.14.199] (Tophie.ap.freescale.net [10.232.14.199]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u71AxC9I027069; Mon, 1 Aug 2016 03:59:13 -0700 To: Jan Viktorin References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-1-git-send-email-shreyansh.jain@nxp.com> <1468303282-2806-6-git-send-email-shreyansh.jain@nxp.com> <20160713112043.2fd847ca@jvn> <20160713193430.65b6df9c@jvn> <578722DB.3030900@nxp.com> <20160714175707.43755987@jvn> <5788BF88.3060607@nxp.com> <5799D20A.4020804@nxp.com> <20160730101455.612818ad@jvn> CC: , , From: Shreyansh Jain Message-ID: <579F2BC4.3060809@nxp.com> Date: Mon, 1 Aug 2016 16:30:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160730101455.612818ad@jvn> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145227573842498; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(24454002)(199003)(377454003)(104016004)(11100500001)(36756003)(80316001)(83506001)(19580405001)(19580395003)(92566002)(33656002)(59896002)(15395725005)(85426001)(586003)(105606002)(68736007)(189998001)(4326007)(230700001)(2906002)(23746002)(2950100001)(4001350100001)(77096005)(15975445007)(97736004)(93886004)(110136002)(87266999)(305945005)(106466001)(7846002)(65816999)(54356999)(50986999)(76176999)(65806001)(65956001)(47776003)(8936002)(81156014)(50466002)(81166006)(8676002)(64126003)(87936001)(356003)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB2062; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD009; 1:YmlzBoi0HX2irRDnDXvq469E7mo63BqNoH9d4mvcSQacS2F4cZ1h63FT6KBfWdPfEdDDEqp+AD+0sMddqW0+zA8RRR1YHEpqOZdIABusZOttcOU55VjX15zY/BlQjQgHekvytTtCwFsVwZmmqOoEkXnaHafo8f4Zki6UtDss6HtguO+/YyH+uDhQkC27sXxGtrQz2P57WVRo3osERLUu9eqH2ZlBciTNi9/+P8OmOkaHv2hi5nfl/YaMgR8NvCNv3wzfP11pUclmOOuvDOfPDNmv6fItVnKBAymGIrDm83fC02ApPCx1SoFIC09+TeVDCgz8IjPj2fRvzexJO0rdZf9qC2pIBfZtF4shAPOtGDut77rvyU/Dg4FctdfwptL9vwWwos98497nf/2UGQnwirws66cLckl7ZKy7hnPj8V/gjuO3E3elgX75iqGeXVIQySp0hbr9svcy/TpAi/6USrQkC5UlkOHoVanZu8WnZGSEhGQk/iIexDe2vbclEMf88rqUTjxikOnMTEnUnV2aHQbJ/BcNKhwSd/TWEefVVpNfZqAQ1s8WRxdocevdwdrHWJt0N9MV1esnNmy9hqqqNg== X-MS-Office365-Filtering-Correlation-Id: b668f76f-0a0b-4de1-70e1-08d3b9fae1fb X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 2:KKVEYRKIBspoQxwt47YDf1qdAWy9Ufeq+lJtBBz5KZOJZqr2lnE6lFFMpJPTAxVpb+LrZYB/+aJNsKa4yI2Yj6qM437ny8gPCyadZrXgNqaJDbBFvGokmooC0yKCiSK6c2FhapaaYFP5wW26ZxaA4vQE5miOpUjGw4LyFRGaAsHAFEflyXUL7Eghpxy6FF66; 3:KBPa2LgbW8hSbAfNOEXuBVEHKoPHz2Ui3h8aEoZGM/CXfP+AFAjFkyYUfuN4tLt9Lw0E3hUBoOjIdA+eaXcDfs/PLnRZsdHXSPUcPz4icjcTYOCg0UwbTNJ+v+GAf1BzrJq/i5ArcwiYPQcnnV8ylRYNSGEyINAtc7p3KwgOr5F+hEgFDQvjTf5jf8Q+vIZ01BH1jVy58+j1icZvF0T0V+3t/PPsW59Jdzj65pEP+PI=; 25:hFppFyvf17h1vpkmDrsy88WQ9p751QF5ptygUm5dObC11huCTqWfQH2LwSSQqCphY/4ic3WtfjxtKqX/IcIs+XdNn8Fv67BBc4ZI8RLF/bI0gKRtp0EtUQzf840uUOnjDw6OG5VBWAE9wdfCj2tDbZL/AcjALYDKEhuLjEO0U8VC6kxTgb85Hs7gGsdBZjh4cerm6FHbuBEuXMuXjcyaYkItmOigdt+gIIp4nmqeU1RpWXPcHRt3dS7Kj1CpysWrTgxmvmBjd0h4T2voMRvhmp7NoLyJx8Oyw+XqmqfBHfUY2FBxgxK7vKE6jR17IKoWZEzD7JYf03hRHOv1f6BYeohizGLE386O8Pw9719QNtg6fafkB+Phj1ausDM/IvCXEnd6ra99FKWRs5z3esczPSnMzc3gSZpW1uG3srnp6vk= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2062; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 31:43hqi5SJ7nrz7twoijS6OYqS/Gj+pKemurYS+N7K3iLPmlExT7XIHPsvfu1GAKVVuki9Vjb4EL+MKh3FA99arsSqtIlIh6FmrxBeUt3C4THyWJVGWnnTp8SpHHZJwh6qXS3SVi9gFuWtTy/sVIC0feK55034DrHc+1VwO7Y88ZzcaJmFtVt9+MwKTVZHyuAEqdtJ9r975lMjzo/FUua+ug==; 4:TlFzlypg6vHXCLGY+jcGiZcuFzBwK1bsbu6IaEZwHvp4UJc0XcdlcrO1fvLyIkKI3qlDs7fdlfqSZuGp5hcleDeUZ7vSQ8zr/MeS0p/Omh0PNfisBwtBfPBvf3WEbd8CMwC700AgtxcZfsOxQzrnHIYSG3Vn56bevjHeeB2HsUOdeUMXXBmZatyAuG1LFxVk9SRdZqCY/xuPQdHr8deMmePGF23ZjAv+2Vi2rxI8JvvII68x7qHspKGIu2hlo+BqVcEo/scKHJs7DDfwOiGPcseOIBBUessRkN3gyrpVvVXe/3GFaMrG+0paca423XC510OdXzSkyAMsdNUf47fTIp+KhQCcg3zhWMVB4HxKpdfOorQdSMhHcXJNeg6mz3pSwNZyCUABnIG5p5/5ykX6NUZmSqgGJpI5JDiaGLbhqBtLHlWtlvlg/59iFMX81iEQfzSQWCDUVeAN3b0uk6jP536r+77VDj8Oc6OcnZHNfK+YnzNd29iybBDDm6VVxh3VU6kxdcjzaK+6C8KNsnpJ7g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:SN1PR0301MB2062; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB2062; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN1PR0301MB2062; 23:3Aqall1v87PjiBR0FTuJuDPN0wX8dsdgZnA?= =?Windows-1252?Q?BFEkV0ny8zSmcKSdhvST34C0IRDyP//TL37KeFK9d0Na2bEP6lhW/KM4?= =?Windows-1252?Q?6VbrxO4kdJaLqSo1COQG1hJ5q3vab+Ald5KZGdpk+Yi8B2FHfYe0ZPl2?= =?Windows-1252?Q?5Xb/A9IkedwJmDO4leuJzL4FtWQpLHoGaLU6IOP73kbxba44H3Wtjtb1?= =?Windows-1252?Q?sYnPG1mF4YkSdTrmVTOssRXHRRTMIulx9CYJnxmL2TlnDt26fKO3Nrwk?= =?Windows-1252?Q?oEYG9S2V5sTtGDeTB/RVS+4m4vEUvSrla2jU93EPdN4l7B/9w98XVGjG?= =?Windows-1252?Q?4H6ahCMpUkozX9n+nYohVsr2qhfqGdm3CvE0aDk2DUUl5wFx3h440vpa?= =?Windows-1252?Q?CnD0eHD1ae/zuVLO1vRbdAVORPd7HUjBlxRWWYH9EOaJUj2m+h9tRwnO?= =?Windows-1252?Q?nVopRHVXG78StxFWviiLb3Mi7Y+xU+HJEYXr730pmMRnxJD0VAPDK4yU?= =?Windows-1252?Q?uuG0DETsVNiKpiBh1/OQlpNnyOi+BoIe08iI2jk6kYxfXrrEpm3UB79I?= =?Windows-1252?Q?yrtkpxB4hPCQLB+qnVauvpUpJbc9JXEAAUX4PihgqJPea6+9OW/wJHhP?= =?Windows-1252?Q?XopdAxi9Ir4+WPRFJz+rcFGV3weOnTt3UJNNgSKTQIeJnuvYqeow6lxX?= =?Windows-1252?Q?nPLFTAaMbOVzIaY1232JoyM6fnNSjA0wZOoHhfKp4aSSFpl83kpzVFwS?= =?Windows-1252?Q?egUI1I56KFIqsbeLI/55pPt5GpAMwHBBNNqx0OfNJ2bBQ4Zwkbdb8XgM?= =?Windows-1252?Q?iXXIkt8AVu1/Il4bfqxyOIQ29QEqF7clmVjx8qPTlPWtbFMfVLE2684P?= =?Windows-1252?Q?qKJxHngoq5qhu1GUrpQ5ieB6qzgdVEMimRgEmgI7s659Hr+oACxCP1mM?= =?Windows-1252?Q?95IC0bvDewgCL79vrK6S/T25iy8i05asNmRfmBZOnZbZ0cCV6H2GfFtD?= =?Windows-1252?Q?M5y52wDsd640jTN7fLF3kxZo6AmCmcKCOvvH6Xzof/YaeFrtn0Crhbgm?= =?Windows-1252?Q?IbTBihRwLe/mJY09qX8QuG//jJJqFoUAY35L6+e3wQtbQoUV4c5Sz2D1?= =?Windows-1252?Q?6yNwtpxxXjMIgxuNc/OZK1PZuKmmE45x1oJ78X96MoLRo5uNTwwTC35u?= =?Windows-1252?Q?vvYTVx2zZ2EPDWpAGO+GrKMdrQjd84TeRLptewSfk8BfbTuRqAomTGA7?= =?Windows-1252?Q?qGUyyXlk1gMDNhnpL9vRZ5KNbqNt1pVB2r0YECWNG53yqQTOYMQ6UoPc?= =?Windows-1252?Q?UovuMxYXqcm6gPXG+9XjIILkXapg3CuTIvDDHANgr9qioi8AVOwIpq09?= =?Windows-1252?Q?jM2On+0/eGLO2RAkbzeDIUvnNFV7hokEC9iWuQgFMyXp9HFta89mcNh6?= =?Windows-1252?Q?GEhiQ9Baq7PqbUJ7s8tiAZz3JoGs/lQVm0tLk12vB1B9VOhlbaTR4qpW?= =?Windows-1252?Q?38FrreCk=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2062; 6:zBl9yabjYeG+GyEl6Eor0woGg3efbI5r5HWSRzBX8RMasvbuVERN2Ows69LPxxwQU9GsnuZdI3yNmdrwpIvcpoJCxQ6B7ertV40CGi5Y8mYqR/uyNQGKelwz209WABDZJebDvv10VtyI7Fj6cG/XZ+qYCIsyWBojM284YIIpGrruH7phmPHbeDkT7viNcFMyzhIB0nWdWOX0JqKWuWskg1hGHBWIeqNkc/SbXwB9kqhSEOQpNb6D3X4BxPfpv7Z1x2mviWByHYDZL/K6RSoP5XL0YmNxyB9l0T3IDVi2o4g=; 5:K0gLYPTZM5dP0tMhczIAem/VE1oTJXlqmWgBLm2ZIjqKjlqORxxsIJdqN+Vg3Q00KKGh7DmD1iQmfbZ6Z77uBOBFE1v04Erl6O1TN1d4TaDp+FRVaQKS9i7C/bbOoF6e71ZwLbTHfoDKrB2ZyOsUiTg2COTeqU2HR2iq70tbhyQ=; 24:UO+v5e+zJSa3Xgzpf+9KdsTozucMAOZUa//++oZceEY6nJlMjsqWN+38ZJmzl8DCvfSHe1anbuKimYjSPg+TSdvcecyhVeNhNd9RzHB2KKg=; 7:qR2/LndDsDOA4XOzg0jkaJ+B/+FADrP3ZWYUfo97MNB4II5euRUMHDK2uvrJ+oI7FLaHHfe3TQjwEPM2Z20biUjmf3XLEyFOkr1h7lnJL1+FW52cguoC+tH7qRL/3G1a563L4MMlFJZ3VjS3dsSTGGC8Dggzz2J1J7YLHs2f25aZIfWvafOFCpeNLn5EG4D5gtpokU3tMHv+XOnLWLoCQp/clgLzTyTv5LISjZlfEdn3fEG5FbaRcJ8zxvOyVhwO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 10:59:15.9958 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2062 Subject: Re: [dpdk-dev] [PATCH v6 05/17] eal: introduce init macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 10:59:21 -0000 Hi Jan, On Saturday 30 July 2016 01:44 PM, Jan Viktorin wrote: > On Thu, 28 Jul 2016 15:06:10 +0530 > Shreyansh Jain wrote: > >> Hi Jan, >> >> On Friday 15 July 2016 04:18 PM, Shreyansh jain wrote: >>> On Thursday 14 July 2016 09:27 PM, Jan Viktorin wrote: > > [...] > >>>>>>> (drv).name = RTE_STR(nm); >>>>> >>>>> That is a miss from my side. >>>>> I will publish v7 with this. You want this right away or should I wait a little while (more reviews, or any pending additions as per Thomas's notes) before publishing? >>>> >>>> Please. The time is almost gone. 18/7/2016 is the release (according >>>> to the roadmap)... I have to fix it in my patchset, otherwise it >>>> does not build (after moving the .name from rte_pci_driver to >>>> rte_driver). >>>> >>> >>> I didn't consider 18/Jul. >>> Please go ahead. I will continue to send v7 _without_ the above change so that your patchset doesn't break. This way you will not get blocked because of me. >>> >> >> Now that we have already skipped the 16.07, I will fix this in my code and release an updated version as soon as 16.07 is officially available. Is that OK? > > Sure :). The thing is that during August-September, I've got significantly > less time for this then in June-July :/. That's why I was trying to fit in > the 16.07. Well, then lets try and get things out for review as soon as we can. I have sent across v7 of rte_driver set. Unfortunately, I forgot to add your sign-off. If the set works for you, can you bulk ack? > >> >> Also, I have fixed most review comments except [1]. I am still not sure of the impact of this change. So, I will publish the v7 without this and then probably a v8 in case this change has any impact. > > I have no idea about this. Hopefully, it's not a very serious thing. > >> That way we can have your patchset not blocked because of this series. > > Thank you! > >> >> [1] http://dpdk.org/ml/archives/dev/2016-July/044004.html > >> >> [...] >> >> >> - >> Shreyansh > > >