From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 701BE2C0F for ; Mon, 8 Aug 2016 11:10:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 08 Aug 2016 02:10:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,489,1464678000"; d="scan'208";a="745697201" Received: from unknown (HELO [10.255.144.170]) ([10.255.144.170]) by FMSMGA003.fm.intel.com with ESMTP; 08 Aug 2016 02:10:37 -0700 To: David Marchand References: <1470406171-24754-1-git-send-email-ferruh.yigit@intel.com> <1470406171-24754-2-git-send-email-ferruh.yigit@intel.com> Cc: "dev@dpdk.org" , Helin Zhang , Konstantin Ananyev , Wenzhuo Lu , Thomas Monjalon From: Ferruh Yigit Message-ID: <57A84C89.7050107@intel.com> Date: Mon, 8 Aug 2016 10:10:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: move PCI device ids to the driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Aug 2016 09:10:43 -0000 On 8/8/2016 7:36 AM, David Marchand wrote: > Hello Ferruh, > > On Fri, Aug 5, 2016 at 4:09 PM, Ferruh Yigit wrote: >> PCI device ids moved from common header into ixgbe driver itself. >> >> KNI starts using pci_device_id from kni/ethtool/ixgbe driver, this is >> only for KNI ethtool support, KNI data path is not effected. >> >> Signed-off-by: Ferruh Yigit > > Thanks for working on this. > > The only thing that bothers me using this ("unsynchronised") internal > pci device list is that, if people were using the ethtool part of kni, > there would now be devices that won't be recognised anymore. > Is it intentional ? I am aware that the list changed, but wasn't sure about updating the list in drivers or not. If a device is not listed in driver's pci device id table, it may not be supported, so ethtool may give wrong output, or it may just be missing, this is hard to know without testing (although this was the case before this patch) Since it is easy to add new id, and we are at the beginning of the release, I was thinking if somebody reports KNI ethotool support is missing for a specific device, we can add it instead of adding all by default. > If so, we should explain why in the documentation. > > Same comment for the igb patch. > >