From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EA85F5584 for ; Thu, 25 Aug 2016 16:46:55 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 25 Aug 2016 07:46:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,576,1464678000"; d="scan'208";a="870999049" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.30]) ([10.237.221.30]) by orsmga003.jf.intel.com with ESMTP; 25 Aug 2016 07:46:46 -0700 To: Vladyslav Buslov References: <20160816182455.4809-1-vladyslav.buslov@harmonicinc.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <57BF04D6.9040108@intel.com> Date: Thu, 25 Aug 2016 15:46:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160816182455.4809-1-vladyslav.buslov@harmonicinc.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: add module parameter 'bind_to_core' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 14:46:56 -0000 Hi Vladyslav, On 8/16/2016 7:24 PM, Vladyslav Buslov wrote: > Allow binding KNI thread to specific core in single threaded mode. I think this is good idea. But I am not sure about making this a module parameter, setting core can be more dynamic. There is already a kni->core_id field, which is only used for multiple_kthread mode. What do you think moving single thread creation into kni_ioctl_create() and use first kni->core_id to bind the thread? If there is no kni->core_id set, it will behave as it is now. > > Signed-off-by: Vladyslav Buslov > --- <...>