From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9AD5758D8 for ; Fri, 26 Aug 2016 10:39:43 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 26 Aug 2016 01:39:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,580,1464678000"; d="scan'208";a="753738765" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by FMSMGA003.fm.intel.com with ESMTP; 26 Aug 2016 01:39:41 -0700 To: Ajit Khaparde References: <1472123147-22997-1-git-send-email-ferruh.yigit@intel.com> Cc: dev@dpdk.org, Stephen Hurd From: Ferruh Yigit Message-ID: <57C0004D.8030706@intel.com> Date: Fri, 26 Aug 2016 09:39:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 08:39:44 -0000 On 8/25/2016 8:03 PM, Ajit Khaparde wrote: > > > On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit > wrote: > > This line printed for every application even if driver is not used at > all. Removing the line to reduce the noise. > > Signed-off-by: Ferruh Yigit > > --- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 3795fac..37d0322 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = { > > static int bnxt_rte_pmd_init(const char *name, const char *params > __rte_unused) > { > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > How about changing the log level to DEBUG? > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name); > > That should reduce the noise till the user explicitly changes the log level. This will give similar result, this log is useless if you are not debugging this driver, but debug log level can be enabled for many reasons. Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires specifically enabled in config for that driver. > > Thanks > ​ > > > rte_eth_driver_register(&bnxt_rte_pmd); > return 0; > } > -- > 2.7.4 > >