From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0FA622716 for ; Mon, 29 Aug 2016 11:38:53 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 29 Aug 2016 02:38:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,596,1464678000"; d="scan'208";a="2221431" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.32]) ([10.237.220.32]) by orsmga005.jf.intel.com with ESMTP; 29 Aug 2016 02:38:52 -0700 To: Vincent Guo , dev@dpdk.org References: <1472436734-5538-1-git-send-email-guopengfei160@163.com> <57C40200.6020009@intel.com> From: Ferruh Yigit Message-ID: <57C402AB.6000907@intel.com> Date: Mon, 29 Aug 2016 10:38:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <57C40200.6020009@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] Bug fix in module_init and module_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 09:38:54 -0000 On 8/29/2016 10:36 AM, Ferruh Yigit wrote: > Hi Vincent, > > On 8/29/2016 3:12 AM, Vincent Guo wrote: >> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set. >> >> Signed-off-by: Vincent Guo >> --- > > Thank you for the update, patch applies well this time. > > A few more small details: > > - Patch subject should start with a label/tag, that shows the > corresponding subsystem. For this patch it is "kni:". > > - In patch subject, after label, sentences starts with lowercase, so > patch subject becomes: > > kni: bug fix in module_init and module_exit > > > - "Fixes:" tag is a line in commit log, to reference the commit that > generated the error. For this patch it is: > > Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32") > > This line should go above "Signed-off-by", with an empty line between. > > - Replying to previous mail thread help others to see the history of the > patch. the option --in-reply-to of the "git send-email" can be used for > this. > > It is possible to get Message ID of the mail that you want to reply via > patchwork or from mail client. For example for this patch, you can see > the message id from: http://dpdk.org/dev/patchwork/patch/15506/ > > - Adding version number to the patch helps following history. Each > updated patch increases the version number. "-vN" option of the "git > format-patch" is useful for this. > > - When a new version of the patch sent, the status of the previous > version should be updated in patchwork as "Superseded". For this case > previous version is: http://dpdk.org/dev/patchwork/patch/15506/ Correction: http://dpdk.org/dev/patchwork/patch/15315/ > > > Thanks, > ferruh >