From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 3C01E29D1
for <dev@dpdk.org>; Mon, 29 Aug 2016 18:57:24 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga102.fm.intel.com with ESMTP; 29 Aug 2016 09:57:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.30,597,1470726000"; d="scan'208";a="1021837864"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.32])
([10.237.220.32])
by orsmga001.jf.intel.com with ESMTP; 29 Aug 2016 09:57:21 -0700
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
<1472219823-29486-18-git-send-email-shreyansh.jain@nxp.com>
Cc: viktorin@rehivetech.com, david.marchand@6wind.com,
thomas.monjalon@6wind.com, hemant.agrawal@nxp.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <57C46970.7020101@intel.com>
Date: Mon, 29 Aug 2016 17:57:20 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1472219823-29486-18-git-send-email-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v8 17/25] drivers: convert PMD_VDEV drivers
to use rte_vdev_driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2016 16:57:24 -0000
On 8/26/2016 2:56 PM, Shreyansh Jain wrote:
> All PMD_VDEV drivers can now use rte_vdev_driver instead of the
> rte_driver (which is embedded in the rte_vdev_driver).
>
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
...
> diff --git a/drivers/net/xenvirt/rte_eth_xenvirt.c b/drivers/net/xenvirt/rte_eth_xenvirt.c
> index 6b15381..fa00e52 100644
> --- a/drivers/net/xenvirt/rte_eth_xenvirt.c
> +++ b/drivers/net/xenvirt/rte_eth_xenvirt.c
> @@ -759,12 +759,14 @@ rte_pmd_xenvirt_devuninit(const char *name)
> return 0;
> }
xenvirt missing header file rte_vdev.h:
CC rte_eth_xenvirt.o
.../drivers/net/xenvirt/rte_eth_xenvirt.c:762:31: error: variable has
incomplete type 'struct rte_vdev_driver'
static struct rte_vdev_driver pmd_xenvirt_drv = {
>
> -static struct rte_driver pmd_xenvirt_drv = {
> - .type = PMD_VDEV,
> - .init = rte_pmd_xenvirt_devinit,
> - .uninit = rte_pmd_xenvirt_devuninit,
> +static struct rte_vdev_driver pmd_xenvirt_drv = {
> + .driver = {
> + .type = PMD_VDEV,
> + .init = rte_pmd_xenvirt_devinit,
> + .uninit = rte_pmd_xenvirt_devuninit
> + },
> };
>
> -PMD_REGISTER_DRIVER(pmd_xenvirt_drv, eth_xenvirt);
> +DRIVER_REGISTER_VDEV(eth_xenvirt, pmd_xenvirt_drv);
> DRIVER_REGISTER_PARAM_STRING(eth_xenvirt,
> "mac=<mac addr>");
>