From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBCB14564F; Fri, 19 Jul 2024 13:10:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1926427C6; Fri, 19 Jul 2024 13:10:32 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2048.outbound.protection.outlook.com [40.107.223.48]) by mails.dpdk.org (Postfix) with ESMTP id D5C22427BC; Fri, 19 Jul 2024 13:10:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G3ExyByd0ib1S8wcI0ch7f11cScAu8UB+fRNWnym2Zypsp4MHbkshB28dDt1vii4wBoXu/ggftkltMO1N2elGppOzdb6MiD7eAOMaNkZnbMbYa61tqdEkKqZwBWAR1fkwIa3qPbX9A5zRIzi1rDGRGVt3IWy4ZyHyj6ObjpExHLwpO89Vqdn9dUiGnynq1n3zTifv2pleKh1J+5VjmaHuzbIDPP2epnlO8Omtxk94KwgmBm7JZ4so/VKBstjgGQAWyRj1WKLchCMoxobiglgBTBtqGyKS8X7cSgICipmB8R+EuE+hgFj8G6COhz7x+NigZhqmTRfBimWhNrZsb2glw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ySgDB8eSt6/b2tDP8kjnZyEBtvg8GOYCtxeKDs5t7BM=; b=w1JPU8oYZUP4YyqRVMEUnHlCqLmc/LprUzHanR4CcDUUpp+UYyqox+maUoZP5uz0LIwxIaYo2/6nMzp9OX/HlApBe1dxyH4O8NyOWYzzuPWpiMmKfuIQPb8G4pox7I2qmBXmJwkgypqnJofCXxGKMj1rf+dItFY+xGK5Wgr5mI8ZbVVyElO7YWKFSOPwl+1UmKC6aWMnQJymY6IIEPRnAiJdbg4dEDeFaxC8qCyiJaSQ8/C7jobuEV4NmoOb8bpUdpNAVSdo6K5qa4p5R3brIhwjtsS0pws8mwlRAtevHpw95XeA6Kju50cB8lfQTgWVeh5OxmUDMOqj3EuXO3+QkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySgDB8eSt6/b2tDP8kjnZyEBtvg8GOYCtxeKDs5t7BM=; b=Ds0O1GUknnLa/jFbqgrOUq1ObRHkoiMipjzB7rQkMaVdU6H1VMW98XiIrfJd4mpD8ptYaqDToe5ILRrMEJZ7VZE+lLUE4dCtXCw4w7xzyjnZja81Ai+slXdjhjxFf+EdD8sM9RklfZZTonBeazgE53hNZExUZQZ8rq8mIUxUyc4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4311.namprd12.prod.outlook.com (2603:10b6:610:a8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Fri, 19 Jul 2024 11:10:28 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Fri, 19 Jul 2024 11:10:28 +0000 Message-ID: <57b08bdb-5f45-4343-a8d2-598d66d82fe8@amd.com> Date: Fri, 19 Jul 2024 12:10:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: fix device init without socket-local memory To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Padraig Connolly References: <20240711123500.483119-1-bruce.richardson@intel.com> <4f7e619a-0398-41cc-90a9-3c52b73d1c49@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0326.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:eb::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4311:EE_ X-MS-Office365-Filtering-Correlation-Id: ed4a6eb1-09d2-44a7-967e-08dca7e365a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U1R2Mm0weDJGdmVtMGJTSEd0YmpwNzV2R3o5Qk5IU1RSeEF4ME83NEtwYjV3?= =?utf-8?B?SENSS1I1QVdtWHBuV3NrYTZMSXRYM3ZvTW5aNG9NVCs5dU1FamloN2pLZVB2?= =?utf-8?B?QnROQzJwcEtoVEZ6WUhIVEpNNHg4ZUNVNkp1eldianJHeE5yYm5zdGswcTk2?= =?utf-8?B?VnFQa1ZJR2pRTDFPODY4cCtuVmJrbVZ2dUZMS0hTWlFRUXpCZTVhOGUwTkdR?= =?utf-8?B?TWtTZmxNWGVqbGFoOE43L2dCSFB4cWd6aWc5elpXRTNDeitsL3daVGZLb0pV?= =?utf-8?B?SE5XQkpMQW5oQWk0Qyt5MTZKcUU1ZW1BWEVrU1B5eGFZck82SGpVdkp6YXo4?= =?utf-8?B?ZUNUMDNuWGs0MEpKYlV1QzBYTnNFeDY0TVhJcHYveUFNc0ZLOW9aaFkzTVhP?= =?utf-8?B?WE42OFFURjI5M2hlWnc1RXJIbUFydWI1QjVXZEpJU3N3VVRSc2dWVTMvVFF1?= =?utf-8?B?REdrNHZ1TlZLVmRYMENZWUtHLzFscnNaazV4NHloMGZwbkgxYVhaeE84THRO?= =?utf-8?B?a0djTWxhcExaUTFZOE1EVmNkcnhSclJ5VG0wbzZJWTBjeUUxVkR4SWFCMVJH?= =?utf-8?B?NGFwMWVNRHV5NWU5NEp5QmFsNFNrYlVxenRPMVhJamMreUQ0YXFWWWdvcjQ2?= =?utf-8?B?UXlxQlJ0dy8xSm51TUpxRUxhSUduMGltU2RyNG1idTlHVnJZdGJwUDhkTjJQ?= =?utf-8?B?bXM2Y3ZQRzI2NCtXQ2U4L2t4L1VaUUhnbXJBeVZTL0hQOWhaNkU4V2tFZmpt?= =?utf-8?B?OUY0VGx3bm1sUDI2eXRtQitGa09LbUwveVlQNm5FakI3TXFHOVJtd0h6UkRY?= =?utf-8?B?dE5UNFpkZm4xY29ZdTRIaElnRWFKNkprcUV6Vm9iYUk5K25XWFdKbUlOTHpD?= =?utf-8?B?NFFwazVpMnNQOGlmY1FkM2MyclNwNExMWEJWVWczcnRnU093RkFMV0ZJNXRR?= =?utf-8?B?bEUxcjNLa0h4VitRcWJpQXB0SlNyNExaTUtqd1pkd1BiS3RuM1ZXeUIxcXEr?= =?utf-8?B?bTFhNUdXUlpOeUFMUG9mMGo3cDBjc3FxZldrWS9DODJtSEs2N2VqM3ZPaVJv?= =?utf-8?B?WERnVUIwR0ltWXJieCtDK2pvZ2ZCVU5XbDcyTEVqSDVhUG1PaW9JeEhOK3lN?= =?utf-8?B?MzJTUVdMRmtsN1FlSC9ZK0VLVTFobnkyUVlYUGt5dmsrbUJTN09INW96WjFm?= =?utf-8?B?ZnNrRSsrVEpNV3pIQm5kTmxISEFFVkZaZGQ4ano2aEVLd3B0dGYxZVhnR0RQ?= =?utf-8?B?VGFxUHRqN3hEU2lFOGxrTkhSRjFwQ21IaitPZ1dPNDA0d2NDNU5WVUU1UVRZ?= =?utf-8?B?aEVuNzRHMVZkQ3RMaWtRRnVTcHA0R01NYU0zV2hvWlcxNTFzRzdXeDYyTi9N?= =?utf-8?B?R253UUlRMFQxZFVZUldvdDhKQmxwM0tMYy9UN28rVTNjTVk4dEdJWithYjBU?= =?utf-8?B?ZTRuVzd4M1ZqZGpvUkhtZEJvVFhGeGRtbG15UFJCZlZmSEV0d1poMi95MVRH?= =?utf-8?B?MkY5ZXZvY1grWXlqNlhybFBzTTh1WERMdmtlSUo1K25ka0lkYVNFOTRnaUE0?= =?utf-8?B?NW1HRXZxb1V1Ri9NZ2hFN3hQU3JNckJxa3gyNUc1S085a0p1cXFSYjRCMk1V?= =?utf-8?B?U1RtM09sVmI3Y01EdUl4Q2VPTmZKcXJibzJic1V3NllRZjJsenVSZTBCMnNH?= =?utf-8?B?a2NTRjU3emR0K2RMMWNUUUFvcjAzTkg2V0g4VXhZRUxqMlhFUVpCZ2JHRkFk?= =?utf-8?B?YlpFSEhqNTB4bHArYXREaENTUW94Z3hyZExHMXUyby91NGxsT05BSDZZMk45?= =?utf-8?B?TDNpYzA0VlhpVGg4S0UzUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDh4T2VSVy8rSzM2cmVZcm10eGRDSU5CWjBRL1R5VGg1UjZNVStHTk8rRTNm?= =?utf-8?B?ZVhDQVA4a2gzY3NObVFrVTFXc3dsaVFLRkNvQzRUSWVnc2tvZU5HZmt0SXA1?= =?utf-8?B?ZGtHSHNmdXRVR0krdFJmWlJGeXJla1FvbjRXcVE3NGxFRlcvT2tCV3o1MTVE?= =?utf-8?B?Nm0zeDhMU2dueFh5Rmlta2pNcUJ5M0pOWmVtcDBpM21saWhDQ1luOTVNTkFF?= =?utf-8?B?NS8yMEhmejFLYTQvUlNhUkRKdHBGbVJJS2loRUx5MElhaFE5dE14ajgzWTVC?= =?utf-8?B?K1grcUtUeWg1NHFWaU9zYWFBTVgrSjVudXJ2ZEt2MWtEbEVrK1kwZ3ZiL1BE?= =?utf-8?B?QlJKSkZiMXVLb1NaSEw4Vm1iVWpUeGltblRpR1pnSWV2Sm1HV0xUQXNicEV1?= =?utf-8?B?a2RLUVYvVUhKeWluVy94djRpUGloSVg1NUFlaFVjVXVGSzd0S3NnS2duZnNp?= =?utf-8?B?SjdYOG9CbGxRN1lkN1VVUWtvanNJL0t6aWNxSlZxK1QvZWIzUHVEM3BxZlFU?= =?utf-8?B?SXIxQldiVzB1N0hNb3pWTHVDMDIzdlBEV3NEYVhmampuUDlpaEZSQy9VRXdR?= =?utf-8?B?OGUrUXpMNEloL0xaZ3FKYlZzOUNWTjJ2bjFCYXlFbzk3R3pJYlBwanVjS1Uz?= =?utf-8?B?dTFkSlJlM1BVS1VFQWJzOG5ML0x6SDU5eVc0MFpJWUx6cDRDZ1Q2WDNTMDdS?= =?utf-8?B?TWltYko0WTJUWktSRFhQeWl3Q0FBTU10cGFGZzh6MnJTYUFKQ0pybCs4N1I5?= =?utf-8?B?TFZib1dWaDBlSVRnMkVNRDI2ZlE5RlhIYllRL0c5dVNUcVM2Rms1SWZnRzVR?= =?utf-8?B?SXFUSUJzR1ZsWmdXb2NPWDVhaE5ZbUptUVhiZU9Db2RsTlo4Ky9mKzFaUWd2?= =?utf-8?B?dEljdldmcDdUZUNtYTZkZVdkNHd2ZVRDenVwTzE2MlR6WHIzVW1MdnAxUzhV?= =?utf-8?B?bkFuZGthL254Z0U2K3VJRXdjeDRmM0VOWEtDdWgrL0JKcjJzQUFnVldMRnpt?= =?utf-8?B?MGNoeDhzZS95bms4SW9BREFwZzkwV3hJa3N0TDdHU1FCNk5Hdll5U2gySUZN?= =?utf-8?B?NWk5bHc1ZHIwU1AreXpVRGFkT0FnU2VPaW91NnBkZEJrSHc2dVkzYjlmOUpX?= =?utf-8?B?MG5XcUVjZ3VHWU1IRnY4eSs4Wng5SWYxaENlNEF2YVJ2MCs3c0tVaWxNbm1R?= =?utf-8?B?Smg2SzFhczZwUlRMSXU5a2FscUtkTlpKSG4zdzhrUnhUR2QwbnNoWTBnTEJQ?= =?utf-8?B?cXlDNDBBNWoyM1ZWNmpvUjA4ditxVDNKOHc3cTNLRTBqa3hOdGtxNEphOVUr?= =?utf-8?B?ZkF5YUJ0cFBIZEV4YndGQmNKMHNCcFE2SVc3NFF6dVplaHNmd2dGQzVXZWMw?= =?utf-8?B?dG1maXF4c2kwZEVhMWdmOTJpbDBTWTE0ZFc0dFczTm9mVTZTYWNEajdLeDVo?= =?utf-8?B?RStRMHhDMlpzckFJK2xOQklMYWc1MmtKMEVyWmtOOFVzZlVhNWp3UEw4K2RJ?= =?utf-8?B?Vi92Z0hmeVY2Ykx4QzY3SEtLUEg0VkUzU0FGZ0owckptWUI5YWdsd0UyZTcx?= =?utf-8?B?dGxCaEh5dHZPOUNEWGJTYklRMCtMd29ORXJjdVRaMjJyN0FLZ0U1Z1ZRYS9o?= =?utf-8?B?aFZXaUhQclkxZjhwNFgwUXJESkJnYnA4Z2JxMDJyWkxhcHpjN3VsYlp2ZHBT?= =?utf-8?B?SEFPOU9rbEk5dXdlTktzYUxLelFmemh6NWI4aGVPK3B1MzRPUk5jRm9hM1Fy?= =?utf-8?B?TG53dkVmeThkcm1sdnQwNVZCYnRkMExBRmZyMXd6d2xGMk04dlVtTWJ3OHZ6?= =?utf-8?B?bjcyQW1MTThKMzNjdi9qM1FZME9Mdm1uZkhxR1JSa3FFeXh4RDk4R3R5VGw2?= =?utf-8?B?MHdIN0JNN1k3NW9YeXhZMmhMVmJrYmZleTZtV0VXN2tCb3crSmlMc3dZSm9V?= =?utf-8?B?TzloTUQvVXZva0RvUjMwQXI2b1dPUWJwMjgxRTllQ2xEeTFmcWl2MW1sUDJl?= =?utf-8?B?MWFuVW9Cc2M4NjY3VnV6cVlzQjdQTWRaaHk1emtCZjh6RFFtb2RoVEc0YXF0?= =?utf-8?B?OXhQbmZKS1NVTmlKajhWK3RENEY0Tnl1WDNQRDZhQy9QUDUwZDhQNERscFpS?= =?utf-8?Q?kLjFwyqeddC/FLsx7zpMt3Bqw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed4a6eb1-09d2-44a7-967e-08dca7e365a8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2024 11:10:28.7123 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nCq/GCNm2ElrT7TbCr4UZNrzj9N7FkuytpQaZ4P+27jN4yyzsgv5S+lUhKJ73pJp X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4311 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/19/2024 10:57 AM, Bruce Richardson wrote: > On Fri, Jul 19, 2024 at 09:59:50AM +0100, Ferruh Yigit wrote: >> On 7/11/2024 1:35 PM, Bruce Richardson wrote: >>> When allocating memory for an ethdev, the rte_malloc_socket call used >>> only allocates memory on the NUMA node/socket local to the device. This >>> means that even if the user wanted to, they could never use a remote NIC >>> without also having memory on that NIC's socket. >>> >>> For example, if we change examples/skeleton/basicfwd.c to have >>> SOCKET_ID_ANY as the socket_id parameter for Rx and Tx rings, we should >>> be able to run the app cross-numa e.g. as below, where the two PCI >>> devices are on socket 1, and core 1 is on socket 0: >>> >>> ./build/examples/dpdk-skeleton -l 1 --legacy-mem --socket-mem=1024,0 \ >>> -a a8:00.0 -a b8:00.0 >>> >>> This fails however, with the error: >>> >>> ETHDEV: failed to allocate private data >>> PCI_BUS: Requested device 0000:a8:00.0 cannot be used >>> >>> We can remove this restriction by doing a fallback call to general >>> rte_malloc after a call to rte_malloc_socket fails. This should be safe >>> to do because the later ethdev calls to setup Rx/Tx queues all take a >>> socket_id parameter, which can be used by applications to enforce the >>> requirement for local-only memory for a device, if so desired. [If >>> device-local memory is present it will be used as before, while if not >>> present the rte_eth_dev_configure call will now pass, but the subsequent >>> queue setup calls requesting local memory will fail]. >>> >>> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs") >>> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Bruce Richardson >>> Signed-off-by: Padraig Connolly >>> >> >> Hi Bruce, >> >> If device-local memory is present, behavior will be same, so I agree >> this is low impact. >> >> But for the case device-local memory is NOT present, should we enforce >> the HW setup is the question. This can be beneficial for users new to DPDK. >> > > No we should not do so, because if we do, there is no way for the user to > allow using remote memory - the probe/init and even configure call has NO > socket_id parameter in it, so the enforcement of local memory is an > internal assumption on the part of the API which is not documented > anywhere, and is not possible for the user to override. > >> Probably 'dev_private' on its own has small impact on the performance >> (although it may depend if these fields used in datapath), but it may be >> vehicle to enforce local memory. >> > > As I explain above in the cover letter, there are already other ways to > enforce local memory - we don't need another one. If the user only wants to > use local memory for a port, they can do so by setting the socket_id > parameter of the rx and tx queues. Enforcing local memory in probe > doesn't add anything to that, and just prevents other use-cases. > >> What is enabled by enabling app to run on cross-numa memory, since on a >> production I expect users would like to use device-local memory for >> performance reasons anyway? >> > > Mostly users want socket-local memory, but with increasing speeds of NICs > we are already seeing cases where users want to run cross-NUMA. For > example, a multi-port NIC may have some ports in use on each socket. > Ack. >> >> Also I am not sure if this is a fix, or change of a intentional behavior. >> > > I suppose it can be viewed either way. However, for me this is a fix, > because right now it is impossible for many users to run their applications > with memory on a different socket to the ports. Nowhere is it documented in > DPDK that there is a hard restriction that ports must have local memory, so > any enforcement of such a policy is wrong. > Although it seems this is done intentionally in the API, I agree that this is not documented in the API, or this restriction is not part of the API definition. > Turning things the other way around - I can't see how anything will break > or even slow down with this patch applied. As I point out above, the user > can already enforce local memory by passing the required socket id when > allocating rx and tx rings - this patch only pushed the failure for > non-local memory a bit later in the initialization sequence, where the user > can actually specify the desired NUMA behaviour. Is there some > case I'm missing where you forsee this causing problems? > A new user may not know that allocating memory from cross-numa impacts performance negatively and have this configuration unintentionally, current failure enforces the ideal configuration. One option can be adding a warning log to the fallback case, saying that memory allocated from non-local socket and performance will be less. Although this message may not mean much to a new user, it may still help via a support engineer or internet search...