From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <SRS0+jceo=SZ=ericsson.com=mattias.ronnblom@lysator.liu.se> Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 573A47CDA for <dev@dpdk.org>; Tue, 23 Apr 2019 19:17:08 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id F34EF40021 for <dev@dpdk.org>; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id DD77A40020; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 170A540016; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) To: Stephen Hemminger <stephen@networkplumber.org> Cc: Neil Horman <nhorman@tuxdriver.com>, dev@dpdk.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> <20190423083124.53481256@hermes.lan> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com> Message-ID: <57db6e4d-6883-5b71-0ba2-654cfec6f9c9@ericsson.com> Date: Tue, 23 Apr 2019 19:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423083124.53481256@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 23 Apr 2019 17:17:08 -0000 On 2019-04-23 17:31, Stephen Hemminger wrote: > On Mon, 22 Apr 2019 19:44:39 +0200 > Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote: > >> On 2019-04-22 17:52, Mattias Rönnblom wrote: >>> On 2019-04-22 13:34, Neil Horman wrote: >>> >>>>> +uint64_t __rte_experimental >>>>> +rte_rand(void) >>>> Do you really want to mark this as experimental? I know it will >>>> trigger the >>>> symbol checker with a warning if you don't, but this function already >>>> existed >>>> previously and was accepted as part of the ABI. Given that the >>>> prototype hasn't >>>> changed, I think you just need to accept it as a non-experimental >>>> function >>>> >>> >>> I'll remove the experimental tag and move it into the 19_05 section >>> (without suggesting it should go into 19.05). That maneuver seems not to >>> trigger any build warnings/errors. >>> >> >> OK, so that wasn't true. It does trigger a build error, courtesy of >> buildtools/check-experimental-syms.sh. >> >> I can't see any obvious way around it. Ideas, anyone? > > Ignore the error, the build tool is not smart enough for this kind of change. > It stops the build. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D9025A05D3 for <public@inbox.dpdk.org>; Tue, 23 Apr 2019 19:17:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD1311B0F8; Tue, 23 Apr 2019 19:17:09 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id 573A47CDA for <dev@dpdk.org>; Tue, 23 Apr 2019 19:17:08 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id F34EF40021 for <dev@dpdk.org>; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id DD77A40020; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 170A540016; Tue, 23 Apr 2019 19:17:07 +0200 (CEST) To: Stephen Hemminger <stephen@networkplumber.org> Cc: Neil Horman <nhorman@tuxdriver.com>, dev@dpdk.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> <20190423083124.53481256@hermes.lan> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com> Message-ID: <57db6e4d-6883-5b71-0ba2-654cfec6f9c9@ericsson.com> Date: Tue, 23 Apr 2019 19:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423083124.53481256@hermes.lan> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190423171706.ga5AsVP2GNKqB11q9q_5KccgS9uIM73tfEjuycvZXcI@z> On 2019-04-23 17:31, Stephen Hemminger wrote: > On Mon, 22 Apr 2019 19:44:39 +0200 > Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote: > >> On 2019-04-22 17:52, Mattias Rönnblom wrote: >>> On 2019-04-22 13:34, Neil Horman wrote: >>> >>>>> +uint64_t __rte_experimental >>>>> +rte_rand(void) >>>> Do you really want to mark this as experimental? I know it will >>>> trigger the >>>> symbol checker with a warning if you don't, but this function already >>>> existed >>>> previously and was accepted as part of the ABI. Given that the >>>> prototype hasn't >>>> changed, I think you just need to accept it as a non-experimental >>>> function >>>> >>> >>> I'll remove the experimental tag and move it into the 19_05 section >>> (without suggesting it should go into 19.05). That maneuver seems not to >>> trigger any build warnings/errors. >>> >> >> OK, so that wasn't true. It does trigger a build error, courtesy of >> buildtools/check-experimental-syms.sh. >> >> I can't see any obvious way around it. Ideas, anyone? > > Ignore the error, the build tool is not smart enough for this kind of change. > It stops the build.