From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66E4648942; Wed, 15 Oct 2025 13:10:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3850A4042E; Wed, 15 Oct 2025 13:10:32 +0200 (CEST) Received: from canpmsgout11.his.huawei.com (canpmsgout11.his.huawei.com [113.46.200.226]) by mails.dpdk.org (Postfix) with ESMTP id 1EC2640276 for ; Wed, 15 Oct 2025 13:10:29 +0200 (CEST) dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=JZ1TYAID4x2q2RJHXHoE3TObvSPjIh2Sggfhcc4gRIY=; b=rYU7LAfFYxOyvUkwHHcgzXxFKS259jphHX7YTFlrZl0e9rmKvJoJEZVC265ujrCsFfPecdVf1 xG0KNdYm9PDyuBFHuqUozBjtNix9Zi/HDxwz2FUNt0h8IK9GgyHZ/fLA8978Qw95vBjcdqzbRYe OAdYTrqYJESmj+GEeO23AD0= Received: from mail.maildlp.com (unknown [172.19.163.44]) by canpmsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4cmpJv1rMfzKm6m; Wed, 15 Oct 2025 19:10:07 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 79B4A140295; Wed, 15 Oct 2025 19:10:27 +0800 (CST) Received: from [10.82.20.40] (10.82.20.40) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 15 Oct 2025 19:10:23 +0800 Message-ID: <57df6dc3-aa82-3c2d-3980-7c5ef7b900fb@huawei.com> Date: Wed, 15 Oct 2025 19:10:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v4 4/4] dma/acc: add doc To: Thomas Monjalon CC: , References: <20250827092729.10719-1-fengchengwen@huawei.com> <20251013091157.1145-1-fengchengwen@huawei.com> <20251013091157.1145-5-fengchengwen@huawei.com> <4548489.fW5hKsROvD@thomas> Content-Language: en-US From: fengchengwen In-Reply-To: <4548489.fW5hKsROvD@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.82.20.40] X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2025/10/15 18:05, Thomas Monjalon wrote: > 13/10/2025 11:11, Chengwen Feng: >> +HISILICON Accelerator DMA Driver >> +================================ >> + >> +Kunpeng SoC has an internal accelerator unit which includes zip function, and >> +the zip also supports data copy and fill. This driver exposes this capability to >> +DPDK application. > How is it different of drivers/dma/hisilicon/ ? > > " > Kunpeng SoC has an internal DMA unit which can be used by application > to accelerate data copies. > " > > If it is the same hardware (Kunpeng), > I recommend having a single driver, or a single directory. > Also we already have a driver named "acc" in baseband. they belong to different hardware IP of Kunpeng platform, /dma/hisilicon is the PCIE subsystem DMA's driver, while this acc is the Accelerator(ZIP) subsystem DMA's driver.  they don't exist in the same specific Kunpeng Soc. a single driver will add complex. as for a single directory, should we do for all vendor?  I see there are  dpaa and dpaa2, ioat and idxd both belong to vendor platform. if there are no rule to have same name with different subsystem driver, I prefer keep it. > >