From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1734A04B1; Mon, 23 Nov 2020 10:52:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00737C8FA; Mon, 23 Nov 2020 10:52:10 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1CF15C8F4 for ; Mon, 23 Nov 2020 10:52:06 +0100 (CET) IronPort-SDR: 9vUzSuj+rwFVKh5LtcS+MESbDIBT7KvRvFEq9ZPoe+ZCAObsKeB2b7HBFsGesVFfpCYwALD4eG xP1Udf9cRWoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="189848170" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="189848170" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 01:52:05 -0800 IronPort-SDR: Lt/QeVG8ttRI522W6kqcKySCUe1YGNDByyu37clx3wRJ/XVM2Rc3LBsBWfPxH3F1rl9BJbffj4 mfrL2DwUPv1g== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="327140369" Received: from tcherepa-mobl.ccr.corp.intel.com (HELO [10.252.20.15]) ([10.252.20.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 01:52:03 -0800 To: Stephen Hemminger Cc: "Min Hu (Connor)" , dev@dpdk.org, bruce.richardson@intel.com, thomas.monjalon@6wind.com, lihuisong@huawei.com References: <531504ce-0547-48c2-4e34-c2ed6cb12e57@intel.com> <1605873002-51934-1-git-send-email-humin29@huawei.com> <94a17751-c71a-a1c0-7cfd-d7990ff265e5@intel.com> <20201120152137.37d11e99@hermes.local> <9dca1ddf-1842-7087-7f04-98604536340e@intel.com> <20201120202928.126217ad@hermes.local> From: Ferruh Yigit Message-ID: <57e36a8a-f868-c449-2c43-347107b994d6@intel.com> Date: Mon, 23 Nov 2020 09:51:59 +0000 MIME-Version: 1.0 In-Reply-To: <20201120202928.126217ad@hermes.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/21/2020 4:29 AM, Stephen Hemminger wrote: > On Fri, 20 Nov 2020 23:33:40 +0000 > Ferruh Yigit wrote: > >> On 11/20/2020 11:21 PM, Stephen Hemminger wrote: >>> On Fri, 20 Nov 2020 17:26:55 +0000 >>> Ferruh Yigit wrote: >>> >>>> On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: >>>>> From: Huisong Li >>>>> >>>>> Currently, the queue stats mapping has the following problems: >>>>> 1) Many PMD drivers don't support queue stats mapping. But there is no >>>>> failure message after executing the command "set stat_qmap rx 0 2 2". >>>>> 2) Once queue mapping is set, unrelated and unmapped queues are also >>>>> displayed. >>>>> 3) The configuration result does not take effect or can not be queried >>>>> in real time. >>>>> 4) The mapping arrays, "tx_queue_stats_mappings_array" & >>>>> "rx_queue_stats_mappings_array" are global and their sizes are based on >>>>> fixed max port and queue size assumptions. >>>>> 5) These record structures, 'map_port_queue_stats_mapping_registers()' >>>>> and its sub functions are redundant for majority of drivers. >>>>> 6) The display of the queue stats and queue stats mapping is mixed >>>>> together. >>>>> >>>>> Since xstats is used to obtain queue statistics, we have made the following >>>>> simplifications and adjustments: >>>>> 1) If PMD requires and supports queue stats mapping, configure to driver in >>>>> real time by calling ethdev API after executing the command >>>>> "set stat_qmap rx/tx ...". If not, the command can not be accepted. >>>>> 2) Based on the above adjustments, these record structures, >>>>> 'map_port_queue_stats_mapping_registers()' and its sub functions can be >>>>> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, >>>>> and 'parse_queue_stats_mapping_config()' can be removed too. >>>>> 3) remove display of queue stats mapping in 'fwd_stats_display()' & >>>>> 'nic_stats_display()', and obtain queue stats by xstats. >>>>> Since the record structures are removed, 'nic_stats_mapping_display()' >>>>> can be deleted. >>>>> >>>>> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error") >>>>> Fixes: 013af9b6b64f6 ("app/testpmd: various updates") >>>>> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue") >>>>> >>>>> Signed-off-by: Huisong Li >>>> >>>> Overall looks good to me. >>>> I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info' >>>> app still can be used to get queue stats and "set stat_qmap ..." is working as >>>> expected. >>>> >>>> But it is a little late for this release cycle, would you be OK to get this at >>>> the beginning of next release? >>> >>> Could we plan to deprecate queue stats mapping in future when xstats work is done? >>> >> >> Even queue stats moved to xstats, a few PMDs still need this configuration and API. >> And this patch already cleans the queue stats mapping noise from testpmd. >> >> What is the benefit/motivation to deprecate the queue stats mapping API? > > Mostly because so few drivers implement it, that any application using it > is going to be non-portable. > 'rte_eth_dev_set_.*_queue_stats_mapping()' APIs return '-ENOTSUP' if underlying PMD doesn't support it, applications can check this for portable code.