From: Thomas Monjalon <thomas@monjalon.net>
To: Hongzhi Guo <guohongzhi1@huawei.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org,
konstantin.ananyev@intel.com, ferruh.yigit@intel.com,
nicolas.chautru@intel.com, zhoujingbin@huawei.com,
chenchanghu@huawei.com, jerry.lilijun@huawei.com,
haifeng.lin@huawei.com, "Olivier Matz" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum
Date: Fri, 10 Jul 2020 23:03:25 +0200 [thread overview]
Message-ID: <5800181.0yhA9BG2Ld@thomas> (raw)
In-Reply-To: <20200710144059.GF5869@platinum>
10/07/2020 16:40, Olivier Matz:
> > > > > > > On Fri, Jul 10, 2020 at 02:55:51PM +0800, Hongzhi Guo wrote:
> > > > > > > > Per RFC768:
> > > > > > > > If the computed checksum is zero, it is transmitted as all
> > > ones.
> > > > > > > > An all zero transmitted checksum value means that the
> > > transmitter
> > > > > > > > generated no checksum.
> > > > > > > >
> > > > > > > > RFC793 for TCP has no such special treatment for the checksum
> > > of
> > > > > > > zero.
> > > > > > > >
> > > > > > > > Fixes: 6006818cfb26 ("net: new checksum functions")
> > > > > > > > Cc: stable@dpdk.org
> > > > > > > >
> > > > > > > > Signed-off-by: Hongzhi Guo <guohongzhi1@huawei.com>
[...]
> After reading again your arguments, I think I prefer your first
> proposal, which was also Hongzhi's initial submission:
>
> - * The complemented checksum to set in the IP packet
> - * or 0 on error
> + * The complemented checksum to set in the IP packet.
>
> Thomas, do you want to to resubmit with this change?
Applied with all changes in comments.
prev parent reply other threads:[~2020-07-10 21:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 6:55 Hongzhi Guo
2020-07-10 12:41 ` Olivier Matz
2020-07-10 13:10 ` Morten Brørup
2020-07-10 13:16 ` Olivier Matz
2020-07-10 13:29 ` Morten Brørup
2020-07-10 13:41 ` Olivier Matz
2020-07-10 13:56 ` Morten Brørup
2020-07-10 14:40 ` Olivier Matz
2020-07-10 14:52 ` Olivier Matz
2020-07-10 21:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5800181.0yhA9BG2Ld@thomas \
--to=thomas@monjalon.net \
--cc=chenchanghu@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guohongzhi1@huawei.com \
--cc=haifeng.lin@huawei.com \
--cc=jerry.lilijun@huawei.com \
--cc=konstantin.ananyev@intel.com \
--cc=mb@smartsharesystems.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=zhoujingbin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).