From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 946B5A0543; Tue, 21 Jun 2022 09:04:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B77E4069C; Tue, 21 Jun 2022 09:04:31 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id A5B6340151 for ; Tue, 21 Jun 2022 09:04:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id ECA7A5C01F2; Tue, 21 Jun 2022 03:04:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 21 Jun 2022 03:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655795067; x= 1655881467; bh=2WuQDjaJWVk7n4Ktrl1Mh8YuFhaNwRvYeElopbIiN4A=; b=s 8X+D66tsoCLd3LS9BGcyyy/IrqPxWD2yE0rcfhJelN5nmx0AJLQsg/jZtfkRoe3w qhxvhlxmJeBIuZVdRjVLyr2H4ESwquSCp2NOxZdWKfqfmgUub332QJqmE799goJ2 eV7VJUKB2q0Pns1B39cQgXnSZ1Ekz84GDuGj5ICl/MJyQfO+jtJDiH0s6ZYq2KKE Qd547MPKqQp9SVXjqckm1FgFgOaYDjx0MRRsXW7xXF3KHQ/LUzRYHmpJVpwnXIcy HBfJ6V+pygDov1bAdGeVRX3Y7crlZvXPFurU9pdo4jAO86AU6R94tvEK5wYT9V+J 6EqlFiEo2JxwIGR6+mMMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655795067; x= 1655881467; bh=2WuQDjaJWVk7n4Ktrl1Mh8YuFhaNwRvYeElopbIiN4A=; b=W nw87hL9OAr3r9FZfR47ZgjOgKSNOqLMkUK2wJ9HzVYm+KEAt3al5EMCkqaXMasl6 kii1HEd6iXwmnZMKlnDraWD1kCngVSyWw97zByQ7wFxdtSBqvSt1Qi/FOeW+hMJb 0tdLf6ER84v8a3PKwi1esVlgyyf0WVruA29s25C6+4cjjzIme2hK+PIvdBUzPn+b U9herPV70cY7L7tqzJuTT0VgBlZOB8R+QNErOH1BOK6rkIcghNz6f0UiqbgL7l3F V+lPnOd20kdB0EjHZZuAT5wEo3EjN30P50CNXf+LJz6D9Ela8laOBRVIXjDTrGSr ok/X4J39TD6c7bQgskHiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefvddgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesth furedttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtff fgvdelteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghloh hnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Jun 2022 03:04:26 -0400 (EDT) From: Thomas Monjalon To: fengchengwen Cc: ferruh.yigit@xilinx.com, dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, ajit.khaparde@broadcom.com, mdr@ashroe.eu, Andrew.Rybchenko@oktetlabs.ru Subject: Re: [PATCH v8 1/4] ethdev: support device error recovery notification Date: Tue, 21 Jun 2022 09:04:24 +0200 Message-ID: <5806582.CvnuH1ECHv@thomas> In-Reply-To: <5676fdec-6c1b-c968-5a46-e487ad315939@huawei.com> References: <20220128124830.427-1-kalesh-anakkur.purayil@broadcom.com> <9930820.VV5PYv0bhD@thomas> <5676fdec-6c1b-c968-5a46-e487ad315939@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/06/2022 03:38, fengchengwen: > Hi Thomas, > > On 2022/6/21 1:42, Thomas Monjalon wrote: > > 16/06/2022 11:41, Chengwen Feng: > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -3928,6 +3928,12 @@ enum rte_eth_event_type { > >> * @see rte_eth_rx_avail_thresh_set() > >> */ > >> RTE_ETH_EVENT_RX_AVAIL_THRESH, > >> + /** Port recovering from a hardware or firmware error */ > >> + RTE_ETH_EVENT_ERR_RECOVERING, > >> + /** Port recovers successful from the error */ > >> + RTE_ETH_EVENT_RECOVER_SUCCESS, > >> + /** Port recovers failed from the error */ > >> + RTE_ETH_EVENT_RECOVER_FAILED, > >> RTE_ETH_EVENT_MAX /**< max value of this enum */ > >> }; > > > > The descriptions here are not enough. > > We cannot understand what has changed on the port, > > and which action must be taken. > > There are detail descriptions in /doc/guides/prog_guide/poll_mode_drv.rst, > I will add your review in poll_mode_drv.rst. > > Another question: do we need to add a detail description here as well? I think the poll_mode_drv.rst is enough. It is the opposite: the RST guide is to give the overview, while the doxygen comments are the precise API documentation. You need to explain what is the state of the device. Is it the same as after a call to rte_eth_dev_stop() ? The application needs to know what must be reconfigured.