From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AE33A0503; Thu, 19 May 2022 01:25:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A438540140; Thu, 19 May 2022 01:25:26 +0200 (CEST) Received: from forward500p.mail.yandex.net (forward500p.mail.yandex.net [77.88.28.110]) by mails.dpdk.org (Postfix) with ESMTP id 24C94400D6 for ; Thu, 19 May 2022 01:25:25 +0200 (CEST) Received: from iva1-b95cb40edbfe.qloud-c.yandex.net (iva1-b95cb40edbfe.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:3080:0:640:b95c:b40e]) by forward500p.mail.yandex.net (Yandex) with ESMTP id 7EBD2F01493; Thu, 19 May 2022 02:25:24 +0300 (MSK) Received: from iva6-2d18925256a6.qloud-c.yandex.net (iva6-2d18925256a6.qloud-c.yandex.net [2a02:6b8:c0c:7594:0:640:2d18:9252]) by iva1-b95cb40edbfe.qloud-c.yandex.net (mxback/Yandex) with ESMTP id 50Rnb7gUGt-PNfmZQRo; Thu, 19 May 2022 02:25:24 +0300 X-Yandex-Fwd: 2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1652916324; bh=VUMcJyknSSDblQgv62lxaXxMha4L+izA5Suyl8DSUZg=; h=In-Reply-To:From:Subject:Cc:References:Date:Message-ID:To; b=M1wCJgrSmQA7xoLmlHJE0I5+NFY66rOJ5vKT/YSOlGIK9gXM/SlYueWcaSP1QKFuZ UEQZvfwGkl2uymW6R9tCFxDfN2jRDODqP0XET0r66iyEKNXR37X+J3YB6bJlDmIAa2 Bcrh14AwHIpyHDGbCL8N8fQNJjpoSkDVMfF2ZVfg= Authentication-Results: iva1-b95cb40edbfe.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by iva6-2d18925256a6.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id tz5Hzoagx5-PM9Gn35f; Thu, 19 May 2022 02:25:23 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Message-ID: <581f038e-a50a-175e-8336-c82f617954f5@yandex.ru> Date: Thu, 19 May 2022 00:25:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH 2/4] net/bonding: move testpmd commands Content-Language: en-US To: David Marchand , "Min Hu (Connor)" Cc: dev , Thomas Monjalon , Xiaoyun Li , Aman Singh , Yuying Zhang , Chas Williams References: <20220513075718.18674-1-david.marchand@redhat.com> <20220513075718.18674-3-david.marchand@redhat.com> From: Konstantin Ananyev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 18/05/2022 18:24, David Marchand пишет: > On Fri, May 13, 2022 at 12:10 PM Min Hu (Connor) wrote: >> >> I think net/bonding offer 'API' for APP to use the bonding. >> and use the specific PMD as slave device. >> The software framwork is like: >> APP >> ethdev >> bonding PMD >> PMD >> hardware >> >> so, I think cmdlines for testpmd should not put in net/bonding.be Actually, I feel the same. I do understand the intention, and I do realize it is just location, but still doesn't look right for me. can't we have a special sub-folder in testpmd instead? Something like app/testpmd/driver_specific/(ixgbe)|(i40e)|(bonding)... > > Sorry, but the distinction is vague. > > Those commands are specific to this driver/library. > I don't see the problem with hosting the commands in the bonding driver/library. > > This is still a RFC, I don't mind dropping this patch (in the end) if > others think it does not make sense. > For now I'll keep it in a v2 series fixing the registering issue in patch 1. > >