From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id B8D8F3257
for <dev@dpdk.org>; Wed, 17 Jan 2018 17:02:17 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
17 Jan 2018 08:02:16 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="10984909"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
([10.237.220.48])
by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2018 08:02:15 -0800
To: dev@dpdk.org, declan.doherty@intel.com
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
References: <20171129145349.43448-1-tomaszx.kulasek@intel.com>
<20171129154200.14436-1-tomaszx.kulasek@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <581f7aef-7dc6-22dc-f177-049e9384c051@intel.com>
Date: Wed, 17 Jan 2018 16:02:15 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20171129154200.14436-1-tomaszx.kulasek@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jan 2018 16:02:18 -0000
On 11/29/2017 3:42 PM, Tomasz Kulasek wrote:
> Some devices needs more time to initialize and bring interface up. When
> link is down the link properties are not valid, e.g. link_speed is
> reported as 0 and this is not a valid speed for slave as well as for whole
> bonding.
>
> During NIC (and bonding) initialization there's concurrency between
> updating link status and adding slave to the bonding.
>
> This patch:
>
> - adds delay before configuring bonding (if link is down) to be sure that
> link status of new slave is valid,
> - propagates information about link status from first slave with link up
> instead of first slave at all, to be sure that link speed is valid.
>
> Fixes: 6abd94d72ab5 ("net/bonding: fix check slaves link properties")
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
> v2 changes:
> - Checkpatch warnings,
> - Improved code style
Hi Declan,
Any comment on this patch?
Thanks,
ferruh