From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79B47A0613 for ; Sat, 31 Aug 2019 11:17:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4232D1EACD; Sat, 31 Aug 2019 11:17:13 +0200 (CEST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by dpdk.org (Postfix) with ESMTP id 24A7D1EAC9 for ; Sat, 31 Aug 2019 11:17:10 +0200 (CEST) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 6D87BF8208FD0AE7A266; Sat, 31 Aug 2019 17:16:59 +0800 (CST) Received: from [127.0.0.1] (10.57.115.182) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Sat, 31 Aug 2019 17:16:52 +0800 To: Ferruh Yigit , References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-11-git-send-email-xavier.huwei@huawei.com> CC: , , , , Thomas Monjalon From: "Wei Hu (Xavier)" Message-ID: <5821182d-e25c-ac83-59ff-38d1354dfeb1@huawei.com> Date: Sat, 31 Aug 2019 17:16:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.115.182] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS of hns3 PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh Yigit On 2019/8/30 23:07, Ferruh Yigit wrote: > On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote: >> This patch adds support for RSS of hns3 PMD driver. >> It included the following functions in file hns3_rss.c: >> 1) Set/query hash key, rss_hf by .rss_hash_update/.rss_hash_conf_get ops >> callback functions. >> 2) Set/query redirection table by .reta_update/.reta_query. ops callback >> functions. >> 3) Set/query hash algorithm by .filter_ctrl ops callback function when >> the 'filter_type' is RTE_ETH_FILTER_HASH. > Legacy filter API is deprecated, there is a recent patch from Thomas to > deprecate documenting this as feature: > Commit 030febb6642c ("doc: remove deprecated ethdev features") We will remove some related feature, and send patch V2. Thanks >> And it included the following functions in file hns3_flow.c: >> 1) Set hash key, rss_hf, redirection table and algorithm by .create ops >> callback function. >> 2) Disable RSS by .destroy or .flush ops callback function. >> 3) Check the effectiveness of the RSS's configuration by .validate ops >> callback function. >> >> Signed-off-by: Hao Chen >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Huisong Li > <...> > >> @@ -2744,6 +2748,10 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { >> .mac_addr_set = hns3_set_default_mac_addr, >> .set_mc_addr_list = hns3_set_mc_mac_addr_list, >> .link_update = hns3_dev_link_update, >> + .rss_hash_update = hns3_dev_rss_hash_update, >> + .rss_hash_conf_get = hns3_dev_rss_hash_conf_get, >> + .reta_update = hns3_dev_rss_reta_update, >> + .reta_query = hns3_dev_rss_reta_query, > Can you please update .ini file in this patch and mark following features as > supported: > RSS key update > RSS reta update > > For 'RSS hash' datapath update is also required, I am not sure in which patch > that support it added. > OK, will fix it in patch V2. Regards Xavier