From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79419A0C45; Fri, 3 Dec 2021 15:05:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1945B4014F; Fri, 3 Dec 2021 15:05:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BA61240041 for ; Fri, 3 Dec 2021 15:05:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638540303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5RUEivvbLBABbMXMblOvgRTMj/1IulDXV5WxVpOWXnk=; b=I0jmspBsus1xfjCzNmntpVLymZwaJ0hPo4AYHvn1zRM8kr09BR/egSl0heJpYoMTCyJC6B 7uSB4CdowQ7hGQqY46e7mSWtyh3lKwV8lcVXe8HWBKRmq5SS1TDJf0eufEn94zcHhMMt09 FY/KvHIQ5s2Ftm2XsMBVJ9YEf1WLdAM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-Aeqj4CH7NqunWvV4wFlpxw-1; Fri, 03 Dec 2021 09:05:02 -0500 X-MC-Unique: Aeqj4CH7NqunWvV4wFlpxw-1 Received: by mail-wm1-f71.google.com with SMTP id ay17-20020a05600c1e1100b0033f27b76819so1569438wmb.4 for ; Fri, 03 Dec 2021 06:05:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=5RUEivvbLBABbMXMblOvgRTMj/1IulDXV5WxVpOWXnk=; b=B6hEpuWEEHmLu+tzKDX9uMsQ7OLcdznv6M+BroGemfuCRv5ZDi4M430MYf7N20Nl1F pIjbgB3KSSkcRaqUCZOAxx8UkgNbIU0v1tI0wKv4T1va29yNPZ+YizyQ8eKVfGVZodpa O/U18NAs/BzR4XAwjG5WG7t614iYUd+9ifGGggGfhtfGyH8C2XkzhV6g9MEQAyx50r99 pbvSOGWdpTuEff3/ZKbA6XfHu943VGkxH3PXFbNDneUvmwT9T/IFX6TS8Tr5cPPf349j 7RtsYNAPwRWSNbSCmtybY7EgRvansU++pnjmqZsZe7fNSMKAgBqWDo/ST79h7wn2OnNk QiXA== X-Gm-Message-State: AOAM531rrAEr6NE/cnGxTQwIamIlQ797ITz3mcZcASOhOZ9s36DuKNNI +e98GBWHVcM7IPZG7OvPAQX7VtHVsdZn5L76fRdpT12gnai4IVOCca0fwszEUSeITZgGDpHgY0Y 6FwI= X-Received: by 2002:a05:6000:1841:: with SMTP id c1mr22191034wri.425.1638540301085; Fri, 03 Dec 2021 06:05:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKJpUDJMEgV+2ew1qgGk6ly0dYhn5hDzBDclXb3TzHU6JOEAOpcBO5biO80Yz6NB6SPYMqUA== X-Received: by 2002:a05:6000:1841:: with SMTP id c1mr22190994wri.425.1638540300764; Fri, 03 Dec 2021 06:05:00 -0800 (PST) Received: from [192.168.0.36] ([78.18.26.230]) by smtp.gmail.com with ESMTPSA id p12sm2997176wro.33.2021.12.03.06.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Dec 2021 06:05:00 -0800 (PST) Message-ID: <5824d156-0bd8-3b61-38aa-d34c551b342c@redhat.com> Date: Fri, 3 Dec 2021 14:04:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: christian.ehrhardt@canonical.com, dev , Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand , Maxime Coquelin References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> From: Kevin Traynor Subject: Re: [PATCH v2 1/2] devtools: don't include headline "fix" in backports In-Reply-To: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 03/12/2021 07:54, christian.ehrhardt@canonical.com wrote: > From: Christian Ehrhardt > > It was important in the past to select anything with "fix" in the > headline, but recently more often created false positives and work > to sort tihngs out than identifying many helpful patches. > > The community and processes aroudn DPDK matured enough that developers > (rightfully) expect to rely on "Fixes:" and "stable@" marking for > backprots. nit: several typos here and i think it should say "or" stable@ > > Therefore do no more include patches that just include the word fix > in the backport candidate list. > > Signed-off-by: Christian Ehrhardt > --- > devtools/git-log-fixes.sh | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 210c8dcf25..27ec9088d4 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -13,7 +13,7 @@ print_help () > cat <<- END_OF_HELP > > Find fixes to backport on previous versions. > - It looks for the word "fix" in the headline or a tag "Fixes" or "Reverts". > + It looks for a tag "Fixes" or "Reverts" and for recipient stable@dpdk.org. "..or for recipient stable@dpdk.org." Good idea, thanks. With minor fixes, Acked-by: Kevin Traynor > The oldest bug origin is printed as well as partially fixed versions. > END_OF_HELP > } > @@ -109,8 +109,7 @@ while read id headline ; do > origins=$(origin_filter $id) > stable=$(stable_tag $id) > fixes=$(fixes_tag $id) > - [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || \ > - echo "$headline" | grep -q fix || continue > + [ "$stable" = "S" ] || [ "$fixes" = "F" ] || [ -n "$origins" ] || continue > version=$(commit_version $id) > if [ -n "$origins" ] ; then > origver="$(origin_version $origins)" >