From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A09CA00C5; Thu, 15 Sep 2022 12:16:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E7B740A80; Thu, 15 Sep 2022 12:16:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C55BC40A80 for ; Thu, 15 Sep 2022 12:16:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663236961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hp9V55nxrZ1Ox3qXk4UzyNbGyLP59Q4TGPbEN2EdZuw=; b=ebpLQVAb6Jxu76F32I1wHGuH96PvIrNE41SohxXRHgSRlzvndvC6hswCoIHvsI1qbWgKRg vUUaQimqZvu7Eia+GVsOnvwnLYxp6OhX98lmlZnDvLEQefQwMr+zQ5QKdiQv9VALBqe+1s hGR4dNOufK88/BTBvni1aYxwu85dNUo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-IaQaOhMhNKWRmZhaKFmH5Q-1; Thu, 15 Sep 2022 06:15:58 -0400 X-MC-Unique: IaQaOhMhNKWRmZhaKFmH5Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0965B185A79C; Thu, 15 Sep 2022 10:15:58 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C068910EB8; Thu, 15 Sep 2022 10:15:56 +0000 (UTC) Message-ID: <583084bd-3d31-cd65-13ca-5c9bcaf3698d@redhat.com> Date: Thu, 15 Sep 2022 12:15:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 26/37] baseband/acc100: allocate ring/queue mem when NULL To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-27-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-27-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Allocate info ring, tail pointers and HARQ layout memory for a device > only if it hasn't already been allocated. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 8898147239..36455d5338 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -582,7 +582,8 @@ allocate_info_ring(struct rte_bbdev *dev) > else > reg_addr = &vf_reg_addr; > /* Allocate InfoRing */ > - d->info_ring = rte_zmalloc_socket("Info Ring", > + if (d->info_ring == NULL) > + d->info_ring = rte_zmalloc_socket("Info Ring", > ACC100_INFO_RING_NUM_ENTRIES * > sizeof(*d->info_ring), RTE_CACHE_LINE_SIZE, > dev->data->socket_id); > @@ -679,7 +680,8 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id) > acc100_reg_write(d, reg_addr->ring_size, value); > > /* Configure tail pointer for use when SDONE enabled */ > - d->tail_ptrs = rte_zmalloc_socket( > + if (d->tail_ptrs == NULL) > + d->tail_ptrs = rte_zmalloc_socket( > dev->device->driver->name, > ACC100_NUM_QGRPS * ACC100_NUM_AQS * sizeof(uint32_t), > RTE_CACHE_LINE_SIZE, socket_id); > @@ -711,7 +713,8 @@ acc100_setup_queues(struct rte_bbdev *dev, uint16_t num_queues, int socket_id) > /* Continue */ > } > > - d->harq_layout = rte_zmalloc_socket("HARQ Layout", > + if (d->harq_layout == NULL) > + d->harq_layout = rte_zmalloc_socket("HARQ Layout", > ACC100_HARQ_LAYOUT * sizeof(*d->harq_layout), > RTE_CACHE_LINE_SIZE, dev->data->socket_id); > if (d->harq_layout == NULL) { It looks like a fix (memory leak without this patch). Please mark it as so.