From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 452BD1B05
 for <dev@dpdk.org>; Tue, 22 May 2018 21:47:30 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id D1D0021B90;
 Tue, 22 May 2018 15:47:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 22 May 2018 15:47:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=SoMgbmYkE4cbwMbdOQa24bI9GP
 1HKwZ3p/BK52QzcrM=; b=Tc10uUEGHGWx8Bu1Q5JfEyfgIg/gr1HEAfMJtDESar
 zO05aSVz50PacbIoessNtpw8z4sXGUbcxV1D59nBvk6tcNoeY55L3W6ULZxWwc+O
 frQfPsfzq9auVhdiirnL3QY4YwmbWyEkhr6ePUepX+yEdknCV1KVU8qY6N/tnanD
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SoMgbm
 YkE4cbwMbdOQa24bI9GP1HKwZ3p/BK52QzcrM=; b=UOv7ZXkLgWPEtFb7FMmVnf
 HGD/YszegaS4N5J+JSWXeIDBkgiDcfE+SOkfsWouI+t9PqUIXwYpHAnvfPaNM3Ua
 t4fh6hEEnif/S+UvEeKzfbUlB/yVcJvJmFbExJvJszCQsnWvCrNVBjJqVuCsir43
 XV5z8aNxy3ectB25ugjotWuYJAMQ9oRjDNt0hFezp2eFipL6FMrBZCW0+v3p98fa
 nl3Dyz8+JG0HUdQPb6eJbjawDC+TGCDp/Ztb6kWOR02tVF17EzbbJzw7/kxKoNcH
 sbv3fMg9hjsSn8g0uPqhHmtx3YfMJZ6mlvDZNAIIudLKVDPY9FXpw7f4LMfEiZdg
 ==
X-ME-Proxy: <xmx:0XMEW58rcuwwC_qN8Y9u-XdWOBDnqHRg6XSKTwIQT20-10Lbd0YRcg>
X-ME-Proxy: <xmx:0XMEW-dwKdt4pe6D_kUpCZ22tE-fKrdILKZbHlKfoW4ZkIxW5wXUdw>
X-ME-Proxy: <xmx:0XMEW2qteUVSW8_L__P2-f4hGNWFsQ0Qu3OG2qbtbS6FjvJk4tktNQ>
X-ME-Proxy: <xmx:0XMEW2qZwK9mIhZ_hMGpKPSktXT3koKTSXdeuivr_K3gWgG_n9ILWQ>
X-ME-Proxy: <xmx:0XMEW_hCyeqzeZ0WXNZmwA1JuEyrK5PHRq4PVV_rd84ep1uAmAaurg>
X-ME-Proxy: <xmx:0XMEWxAMq8KYT_Ej7ccajmdUNsCXN7QDaRml_IYi5r6wo69H28SqAQ>
X-ME-Sender: <xms:0XMEWwffkW7Ec9OAx9BKi3TK5rAmp0s4WpbBIKUGAsJjT1mkgCNPhw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id E0DADE465C;
 Tue, 22 May 2018 15:47:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 dev@dpdk.org, Zhiyong Yang <zhiyong.yang@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
Date: Tue, 22 May 2018 21:47:28 +0200
Message-ID: <5833665.TREZe9cROF@xps>
In-Reply-To: <20180522183509.66644-1-ferruh.yigit@intel.com>
References: <20180522183509.66644-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2018 19:47:30 -0000

22/05/2018 20:35, Ferruh Yigit:
> vdevs detach on testpmd exit implemented as workaround to fix
> a virtio-user issue. The issue was virtio-user cleanup is not
> called and existing socket file not cleaned up which will fail
> next run.
> 
> The vdev cleanup causing problems in failsafe PMD.
> 
> Reduce the cleanup to only virtio-user and add a comment that this
> workaround should be converted to a proper cleanup, not something
> specific to virtio-user, and not something specific to vdev and
> testpmd.
> 
> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

OK to squash it with above patch.
Thanks for the update.

Note: this patch is not related to failsafe.
There was a deadlock introduced in 18.05-rc1 when detaching failsafe,
but it is fixed by using a recursive lock in vdev.