From: Olivier Matz <olivier.matz@6wind.com>
To: "Kuusisaari, Juhamatti" <Juhamatti.Kuusisaari@coriant.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct location
Date: Mon, 11 Jul 2016 13:40:20 +0200 [thread overview]
Message-ID: <5837bceb-070e-76d4-d548-8d5e9f1cce32@6wind.com> (raw)
In-Reply-To: <HE1PR04MB1337E26DB33E9E9F8196FF0B9D3F0@HE1PR04MB1337.eurprd04.prod.outlook.com>
Hi,
On 07/11/2016 01:22 PM, Kuusisaari, Juhamatti wrote:
>
> Hi,
>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Juhamatti
>>> Kuusisaari
>>> Sent: Monday, July 11, 2016 11:21 AM
>>> To: dev@dpdk.org
>>> Subject: [dpdk-dev] [PATCH] lib: move rte_ring read barrier to correct
>>> location
>>>
>>> Fix the location of the rte_ring data dependency read barrier.
>>> It needs to be called before accessing indexed data to ensure that the
>>> data itself is guaranteed to be correctly updated.
>>>
>>> See more details at kernel/Documentation/memory-barriers.txt
>>> section 'Data dependency barriers'.
>>
>>
>> Any explanation why?
>> From my point smp_rmb()s are on the proper places here :) Konstantin
>
> The problem here is that on a weak memory model system the CPU is
> allowed to load the address data out-of-order in advance.
> If the read barrier is after the DEQUEUE, you might end up having the old
> data there on a race situation when the buffer is continuously full.
> Having it before the DEQUEUE guarantees that the load is not done
> in advance.
>
> On Intel, it should not matter due to different memory model, so this is
> limited to weak memory model systems.
I agree with Juhamatti. To me, the reading of consumer_head must occur
before the reading of objects ptrs.
That was the case before, and this is something I already noticed when I
sent that mail:
http://dpdk.org/ml/archives/dev/2014-March/001742.html
At that time, only Intel CPUs were supported, so it did not make any
difference.
Juhamatti, do you have a setup where you can trigger the issue or is it
something you've seen by code review?
Thanks,
Olivier
next prev parent reply other threads:[~2016-07-11 11:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 10:20 Juhamatti Kuusisaari
2016-07-11 10:41 ` Ananyev, Konstantin
2016-07-11 11:22 ` Kuusisaari, Juhamatti
2016-07-11 11:40 ` Olivier Matz [this message]
2016-07-12 4:10 ` Kuusisaari, Juhamatti
2016-07-11 12:34 ` Ananyev, Konstantin
2016-07-12 5:27 ` Kuusisaari, Juhamatti
2016-07-12 11:01 ` Ananyev, Konstantin
2016-07-12 17:58 ` Ananyev, Konstantin
2016-07-13 5:27 ` Kuusisaari, Juhamatti
2016-07-13 13:00 ` Ananyev, Konstantin
2016-07-14 4:17 ` Kuusisaari, Juhamatti
2016-07-14 12:56 ` Ananyev, Konstantin
2016-07-15 5:40 ` Kuusisaari, Juhamatti
2016-07-15 6:29 ` Jerin Jacob
2016-07-15 10:34 ` Ananyev, Konstantin
2016-07-18 2:47 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5837bceb-070e-76d4-d548-8d5e9f1cce32@6wind.com \
--to=olivier.matz@6wind.com \
--cc=Juhamatti.Kuusisaari@coriant.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).