From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ophir Munk <ophirmu@mellanox.com>,
dev@dpdk.org, Moti Haimovsky <motih@mellanox.com>,
Olga Shern <olgas@mellanox.com>, Matan Azrad <matan@mellanox.com>,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations
Date: Mon, 12 Feb 2018 14:58:31 +0100 [thread overview]
Message-ID: <5845713.HXRxCIfSL1@xps> (raw)
In-Reply-To: <20180212112307.GH4256@6wind.com>
12/02/2018 12:23, Adrien Mazarguil:
> On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote:
> > I think it's better to have some random thoughts than nothing.
> > All the comments you gave in this thread deserve to be written in
> > the documentation as soon as possible.
>
> Right, but as a side note in the meantime, more complete documentation is
> already available in Doxygen format in mlx4_flow.c. *All* limitations are
> also returned in plain text through error messages (rte_flow_error.message)
> in the same file (git grep 'msg =' drivers/net/mlx4/mlx4_flow.c).
OK, so we can just point to this file in the documentation and we are done.
[...]
> > Do you plan to provide a template or an example?
>
> I certainly would like to submit something with the plan I suggested,
> unfortunately I don't have time to work on that at the moment.
Is it worth the effort, given it is already documented in code?
next prev parent reply other threads:[~2018-02-12 13:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:55 Ophir Munk
2018-02-08 18:06 ` Mcnamara, John
2018-02-09 16:21 ` Adrien Mazarguil
2018-02-09 16:39 ` Thomas Monjalon
2018-02-12 11:23 ` Adrien Mazarguil
2018-02-12 13:58 ` Thomas Monjalon [this message]
2018-02-12 14:19 ` Adrien Mazarguil
2018-02-12 16:23 ` Thomas Monjalon
2018-02-11 19:30 ` Marcelo Ricardo Leitner
2018-02-12 7:41 ` Shahaf Shuler
2018-02-12 12:45 ` Marcelo Ricardo Leitner
2018-02-12 13:44 ` Shahaf Shuler
2018-02-24 22:36 ` [dpdk-dev] [PATCH v2] " Ophir Munk
2018-03-13 14:25 ` Adrien Mazarguil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5845713.HXRxCIfSL1@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=motih@mellanox.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).