From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C68AA1B350
 for <dev@dpdk.org>; Mon, 12 Feb 2018 14:58:41 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5B1EB21497;
 Mon, 12 Feb 2018 08:58:41 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Mon, 12 Feb 2018 08:58:41 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=d1waOdD09O2uqYwgqa9PngRpyu
 KjZNr6iWoz5qDUMP0=; b=WnQiNdP87ARJ/8Bh2YLQPJn6wdL4WsHTpm1VxHJykK
 TBIrJsfNAma+urVefGkYkluNT+oedlQ0WWiGCRbpKr4Ihkw8DzNssVrUc0lM0psG
 JSOCezliinCA4EjgSbmh1S9PbpgMfH+W/KcKw3L62z3pVcrxAaZsiYTUfVIT4Ful
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=d1waOd
 D09O2uqYwgqa9PngRpyuKjZNr6iWoz5qDUMP0=; b=dPcigRS3xKxN++SryDWdPh
 Q/3+KvwrK5exsK8X1K2/XPlG7N4Jt4tYA4IhxAFEqzFna0PctUZs8hdtUp3HMfLc
 n9I4QDEm5EjcM0DZQ0cu+vziFLvYdEXunBtUCysbDL0P/eKzcZKAqvXhIsi7Z55o
 8Ad6hMURh7LDRfl5iCRhmTeuyVlggZdZJSRARxBFG32EVhahRO9R2fpCE/8HE/Zk
 FiZGh9sv6/6ADunepTE0CHOiuTTPvoBJ9qCYMfyJCOjQ7wr2ZqbkHZuefaZwq4F+
 e8oq9Vk2ecVJ8UpPwABqNo+A4z6ExTwiBVIpwiPUjqDzBEElzYw/elYIFxC8I3fg
 ==
X-ME-Sender: <xms:kZ2BWvo3mO-gQl5YJ4kGKvBgmk1CeETQvi9dbRDRBADV8Td2fayGmw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 07D0F2460B;
 Mon, 12 Feb 2018 08:58:41 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ophir Munk <ophirmu@mellanox.com>, dev@dpdk.org,
 Moti Haimovsky <motih@mellanox.com>, Olga Shern <olgas@mellanox.com>,
 Matan Azrad <matan@mellanox.com>, ferruh.yigit@intel.com
Date: Mon, 12 Feb 2018 14:58:31 +0100
Message-ID: <5845713.HXRxCIfSL1@xps>
In-Reply-To: <20180212112307.GH4256@6wind.com>
References: <1518072954-19082-1-git-send-email-ophirmu@mellanox.com>
 <1944833.dayHpbUbTZ@xps> <20180212112307.GH4256@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2018 13:58:41 -0000

12/02/2018 12:23, Adrien Mazarguil:
> On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote:
> > I think it's better to have some random thoughts than nothing.
> > All the comments you gave in this thread deserve to be written in
> > the documentation as soon as possible.
> 
> Right, but as a side note in the meantime, more complete documentation is
> already available in Doxygen format in mlx4_flow.c. *All* limitations are
> also returned in plain text through error messages (rte_flow_error.message)
> in the same file (git grep 'msg =' drivers/net/mlx4/mlx4_flow.c).

OK, so we can just point to this file in the documentation and we are done.

[...]
> > Do you plan to provide a template or an example?
> 
> I certainly would like to submit something with the plan I suggested,
> unfortunately I don't have time to work on that at the moment.

Is it worth the effort, given it is already documented in code?