From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A64D5A0547; Thu, 28 Oct 2021 14:40:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F12741100; Thu, 28 Oct 2021 14:40:40 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 1C5B740DF4 for ; Thu, 28 Oct 2021 14:40:38 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="230249731" X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="230249731" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 05:40:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="573735274" Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2021 05:40:37 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by irsmsx601.ger.corp.intel.com (163.33.146.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 13:40:35 +0100 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.2242.012; Thu, 28 Oct 2021 20:40:32 +0800 From: "Hu, Jiayu" To: Maxime Coquelin , "dev@dpdk.org" , "Xia, Chenbo" , "Wang, YuanX" , "Ma, WenwuX" , "Richardson, Bruce" , "Mcnamara, John" Thread-Topic: [PATCH v2 00/15] vhost: clean-up and simplify async implementation Thread-Index: AQHXyoazyInNZIzF9EaO8qb5TW61K6voW9uA Date: Thu, 28 Oct 2021 12:40:32 +0000 Message-ID: <584e0d92370e485e9114fc75471ed0d1@intel.com> References: <20211026162904.482987-1-maxime.coquelin@redhat.com> In-Reply-To: <20211026162904.482987-1-maxime.coquelin@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 00/15] vhost: clean-up and simplify async implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, October 27, 2021 12:29 AM > To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu > ; Wang, YuanX ; Ma, > WenwuX ; Richardson, Bruce > ; Mcnamara, John > > Cc: Maxime Coquelin > Subject: [PATCH v2 00/15] vhost: clean-up and simplify async implementati= on >=20 > This series aims at cleaning and simplifying the async enqueue path. I th= ink it > makes the code easier to understand, and is necessary before integrating > new changes. >=20 > I may have more reworks to propose in next revisions, but I wanted to sha= re > my current status early so that you have time to review/test it. >=20 > It is only compile-tested, as I don't have HW with IOAT support to test i= t. >=20 > Changes in v2: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Print once when max number of iovec is reached (Jiayu) > - Increase number of IOVECs from 512 to 2048 (Jiayu) > - Fix Vhost example build when raw/ioat is disabled >=20 > Changes in v1: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Fix missing iovec index increment (Jiayu) > - Remove unneeded sanity check on IOV iter index (Jiayu) > - Fix async->pkts_info allocation check (Jiayu) > - Prevent NULL pointer dereference on async metadata cleanup (Jiayu) >=20 > *** BLURB HERE *** >=20 > Maxime Coquelin (15): > vhost: move async data in a dedicated structure > vhost: hide inflight async structure > vhost: simplify async IO vectors > vhost: simplify async IO vectors iterators > vhost: remove async batch threshold > vhost: introduce specific iovec structure > vhost: remove useless fields in async iterator struct > vhost: improve IO vector logic > vhost: remove notion of async descriptor > vhost: simplify async enqueue completion > vhost: simplify getting the first in-flight index > vhost: prepare async for mbuf to desc refactoring > vhost: prepare sync for mbuf to desc refactoring > vhost: merge sync and async mbuf to desc filling > vhost: increase number of async IO vectors >=20 > examples/vhost/ioat.c | 30 +- > examples/vhost/ioat.h | 4 +- > lib/vhost/rte_vhost_async.h | 42 +-- > lib/vhost/vhost.c | 130 +++---- > lib/vhost/vhost.h | 67 ++-- > lib/vhost/vhost_user.c | 4 +- > lib/vhost/virtio_net.c | 697 ++++++++++++++---------------------- > 7 files changed, 382 insertions(+), 592 deletions(-) >=20 > -- > 2.31.1 Reviewed-by: Jiayu Hu for this serial.