From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD4A0A0C43; Mon, 15 Nov 2021 11:25:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA7394113C; Mon, 15 Nov 2021 11:25:01 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9010940E25 for ; Mon, 15 Nov 2021 11:24:59 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="233254714" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="233254714" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 02:24:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="471862078" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 15 Nov 2021 02:24:58 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:24:58 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 02:24:57 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 02:24:57 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 02:24:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXlMKajxio28fNFbfN4v9Fl0r01Sfi3x2JntLkTqcbWTeFM3+W4xzl0zHZxnNNT0C+OuprWaaHm3e5fmPDHucoO0AZP5BOZS2fdiSQdQsuhp5+tGSELA/pEBL1fvaXj/Z8nLldewti6+EuI9PRCDIHJ5ySoPKJ6xw4HaPfTaxq6HaI1kkRzzMZ6WWhhaiLT/aZkEV/yJWMRxayl1Xhx8I1Dj4bztzk3eMTW1re5zDwgui72kIZcKt1+PIp7+EFJmJSKqPCMF5CWkKcYE7HKHYUrfYug9bKjxTdyRZNsVRey6SETw+dyzd3Uf1kSSufZ9lm4Bf2pbvVPgTrgdp8qNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a80x9PWzTtCQUuajnCAEkfdIHyiRRAKIzgtDdPLeZlU=; b=bGHBiE0pZKaBP5j/WFXv4KmasLiie/vb1hI4BWeNid0+3kQsjET7pg42Crb3ZVk/pd7P5ZEmsbEDo/ydT6Egzjq1efxg/ak4HxiHo7KwUQnHZLrCuFR88Lg9msTbgdW5kVxZDeubAepvK2vBtMqO5cwby2RJx+fAx4D/A7r8MJxgobCPrQcPf0Cl7QoYgu8Vx/FS5HiFTD75QWWxFlxC+PI766WW538CSzdaQCK9mv13YF6Fq7M2l9F6VBN6R6jBediB++BkyGAl3/UROFUwK7LWbDs4tJxcWNuOXqTbdCrSrF+AGApU0mH7KpW+6J/LSlYxGgB3EnNLRaZPbteQdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a80x9PWzTtCQUuajnCAEkfdIHyiRRAKIzgtDdPLeZlU=; b=yLEirerGrDSNpW6cXp61aPqJiaUUqqYjZBeVzprvfspLNgfseTi/6mb7Ly74FTT812Jr5PFyVFkRJLwIiOWB2MbxVUJtoJzGs2rst2zQKQfghiPuGdEFlO8o1/PlM9gn+5dZig7mFC4jvVXxqy6Zn+8x1Ui+Tc8eLSrZM2sBqvY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5110.namprd11.prod.outlook.com (2603:10b6:510:3f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 15 Nov 2021 10:24:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 10:24:56 +0000 Message-ID: <584e322e-3a8c-68d2-7e0d-a243f1f56909@intel.com> Date: Mon, 15 Nov 2021 10:24:50 +0000 Subject: Re: [PATCH v11 3/5] net/enetfec: support queue configuration Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , CC: , , , , References: <20211113043141.18888-2-apeksha.gupta@nxp.com> <20211115071940.12942-1-apeksha.gupta@nxp.com> <20211115071940.12942-4-apeksha.gupta@nxp.com> X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6P191CA0003.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.19 via Frontend Transport; Mon, 15 Nov 2021 10:24:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad97717e-2554-4975-7f3f-08d9a8222b8d X-MS-TrafficTypeDiagnostic: PH0PR11MB5110: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VFGhPKw6TdfjZdPFOiWN8I/oVLUl0mBmTvINV55UXoHRdgsbywdU83QAsOqAmnx0uiOSlQrCmkor5x/f3dxtJ6nbQ6RRd40tXoqfz9szaNeIk+U1NuNZQUz1tb2z+rx+ddavoCRWIqiW+hujBQuLSUi7PPevs38i/ThdXGTM1GkuKtDP0ou9P1E6dtRQ2Iqt3lNCKdYjTeCpynuFpdD7RM9Q7xMvN80iNuwznCKTp+OQkDBsiQ58ar6fwz1tLNSiaHZ7GlvVdsmyUiUCTRdn9CJ7M9DEHq9QF2XQ15TLEuB2xdmFpDlrU3rRvfMhw/vhC3I96aRg7iAm+SID7N63HrIOp3CtvVYTXZMHk5bqgD+F76OaBLVSv5LKek0cMVjU2Rsb4ndAmcz9c2lg5KVpTziOwd8aeA6FV4BuPuNo4Kpwexywa/tD66RPQXv8A1NI8M89pzJzufAU9Asg2i/qANdpAwtyfI6ZeqWvZEqq2mJqtBiyNvuDuon962hMcxfUmOuqGEj/F3ShQkGdH/qYzlB+jhsQmzuKj1X3GPpQgB0/WtJ7upVRf43430yzKyG50NloZbjkYCSqPDgVw4dHbpicmmKWBf0Tg2TJHA+zyyt03tcoPalJM76+YxTdrp/phXIJxZUVVYQqQICoRpZUdehOWpBJjYH5OvCA8v3kqz2kGnn6SaHDMq6vAiuZ+b4TWYBLNckIblR7Ms9CfFlMZw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(8936002)(6486002)(5660300002)(6666004)(2616005)(82960400001)(186003)(38100700002)(316002)(4744005)(26005)(66476007)(31686004)(8676002)(44832011)(86362001)(66556008)(66946007)(53546011)(2906002)(4326008)(508600001)(16576012)(956004)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGMvQ29FQk9NbFlWV2tPRVNLVlNWMld4MldsVXkrVGtSbFp3LzI1eDJURFg0?= =?utf-8?B?WkdsYkhPZEZjRHVETlBnR2FDVVdCOTFxYUdyTHQrNEpZdUJLREVsSjg3dnVX?= =?utf-8?B?VFVXaXdVTGM3a2J4b2ZVaDgzSVhCb2FGV2YxeW1LbVFIempUSTVNTzJmRkZC?= =?utf-8?B?VmUyek13d1RaRFVrZWhOWXY4eFBmZlVnT0xCSyt6emJEQTcycHlhYWpwU2VF?= =?utf-8?B?SzlEUFg3Tjlya1g0QWlpU1BML0Y4R3FJcnpGdTFGUVltNG5SY1pUNktYZ0xR?= =?utf-8?B?TVpESEp4R2xMVTNXU1hjK0E0VmdSWDZxYzNFNVgzL3U5TmI2L1doVkJhUHdo?= =?utf-8?B?Vm5JanNQVlVmZEpyOVdySjFBandzTmFBU1BzRDFGL2ZSbnlKRG5uL3lEYUNH?= =?utf-8?B?TGtSejJxNTRiUkhVc2lEdkdmU0haVWVPSmM0TC9NcHh2eDFjanNkTUxqaWt0?= =?utf-8?B?Y2RObks1YUdjUzZKK0ZZOG5lSzdObTgwSUZ3cUhCdEgzZVhUQ2lvcVpCbUVX?= =?utf-8?B?OGNzdE9KdUNNcVV6NTdpMHd4aHdLUUdWNUprSjRyaEJSN3gvRkZjRVdPcnNX?= =?utf-8?B?aXg1clVWdXBySHdzTTV0ZXFHKzUzU1ZEUnhtbDRIMVR2ZHVHeWtnbWtTdVVz?= =?utf-8?B?UjMxMk5vRTgrQ3JOYThsUmN0V3BQYXp2K05wbmpuVE9vbklmM1RYZUcyalNO?= =?utf-8?B?N283THVsak5ldU1GK0p5Yjh2bkFrbXFXaXJmSDNHQVZRWk9BampVcEJkbUZv?= =?utf-8?B?QlN1WG80bVNXbUhRd3p0bnh5S29yT25SNkdtcllZUjVHakRYQndETTBXRFAz?= =?utf-8?B?QnFiVlh5MTB5eVk5S29LZWlkalNKMy9sZkt0MkFIaGF6dDl2cW9pR3NQTzF2?= =?utf-8?B?VysvNkZQSTFNWXJuWjBQWTNDR2cwZlpuaU9aRi9JZ3RzUUszc0VmejBFK01J?= =?utf-8?B?Smk1S0V5bGFwem83K3VWM1pXcDBreW1CWmRqNkpERUNGM1lPcEVQMDFMaExO?= =?utf-8?B?T0Q5dVZkRzRlYnBIQldSQUVuV2VmMDJSTjhuWk5UT05aTXVPRktUTFdMMWR2?= =?utf-8?B?UUdYemNnVFJIQ0ExZnBlcTd1azRoZ3k2L3BBa01sM0VOS0ZQMVdGTlJKNkoz?= =?utf-8?B?ZkxiTXMvS1ZWOGRWVWpCYlBXMExSWm95bWxDbnpzSnVrZEIzWHVtaXR3eC9R?= =?utf-8?B?RlpNNXhLamFtblVuL29sYTBvd2RMQmg3RitZSk8xU0Q3NEZseVd4ekhGcTZ2?= =?utf-8?B?UlY0RElubW1vTTN0ZEJ6bzZUdHp4ampjaUVQeWxOUVJvNzl0anJEdENSRHhM?= =?utf-8?B?elBHYjVQNlFuMno0T21PZXZiTlJ2VVA0enFselJFSmw2RkVOSGJ0UGpmRm1o?= =?utf-8?B?MVpJZlNYMkd1ejYvK21HWkhKMTNQNlVzTy82Z2RnT3BOTTZoc1lzVTIyWXJh?= =?utf-8?B?eUxXZ1lLNUM4S3JTWW9BMWpoVGZsbGZEMVVJcUk5Qjlyb2w4b1NEUWtWWGU1?= =?utf-8?B?NGRuYlIxTXhSdnpOWlVjUlFRK2x0N3hRa2ZZTDIxaE5FS1htaDV6UytxQUFa?= =?utf-8?B?Wnp4cnRXL05udFh3RjJXb3FGdGRMSlNCWWJPSmk3aDJ3Ry9xaUdOeHF6TytQ?= =?utf-8?B?SjZOd2FxZlhlNUY0dDI0VGhTM0hhR1BzTkVCNE43VWRjdVlZUGlvQno3L05X?= =?utf-8?B?bVkxenViVDRBWlFUQWpmY2xFOERhWXl3d0NQSXBXMFBKMXFKUUhjZjZnY2J3?= =?utf-8?B?T2I5TGRJRDBUbExGV0Y1aTRGMEtRMHgzOExSajFsZ0drMitTQ1dmZzhSQzRR?= =?utf-8?B?MEtXdXM2djduYUdqb25KRlRubnRUS0NIbWV1eUFCYTdFNFNoZDc3cUlhVWk0?= =?utf-8?B?dlBpSHRnZlZzZ2xzQko4NjgyanppMkdZemk5S3h4OGp2ZndxaGgvaEpSL3VP?= =?utf-8?B?MWwwR1k4bHFMMTFWRVU2T0o4cmlqTWlJRGpuS24xRWJSMUFHVUxla0p6SzNP?= =?utf-8?B?WkpwTHNFZElybHBUQktJWDhzMEIrNzJPTWNsMGRyODZBRWs5N011eVo3aUtT?= =?utf-8?B?NDk4cVBmRXZtSTN1dm8veXBRdHhFWTRvekdVNjJ1SjJUZlVib1U1b2srRjFk?= =?utf-8?B?SzhYREJDdUc0cGRvN2FhcE1tc2picUN3dkd1SXM2ZW42eXRjQU45SDBTMXU0?= =?utf-8?Q?mypplGxAgmeFGMgLOMNo5A8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad97717e-2554-4975-7f3f-08d9a8222b8d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 10:24:56.4893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cxYij5nFlZZCHfWdDxs+BbHrXYUb1PcbvAtivY+cJArzfaAyBTg/vIevg2SuBTGQMi/siTSabayCFvQeqBGUDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5110 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 10:11 AM, Ferruh Yigit wrote: > On 11/15/2021 7:19 AM, Apeksha Gupta wrote: >> This patch adds Rx/Tx queue configuration setup operations. >> On packet reception the respective BD Ring status bit is set >> which is then used for packet processing. >> >> Signed-off-by: Sachin Saxena >> Signed-off-by: Apeksha Gupta >> Acked-by: Hemant Agrawal > > I put a comment to v9 on using 'fep->bd_addr_p_r[queue_idx]' & > 'fep->bd_addr_p_t[queue_idx])' 64 bit variables as 32 bit, can you please > check it? hmm, 'fep->bd_addr_p_r[queue_idx]' & 'fep->bd_addr_p_t[queue_idx])' are no more 64-bit variables. Not sure why gcc12 complains about it, can we follow it on the v9 comment?