From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0651A034F; Fri, 8 Oct 2021 12:34:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C2EA41121; Fri, 8 Oct 2021 12:34:04 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2D7BD41137 for ; Fri, 8 Oct 2021 12:34:03 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D429F5C0143; Fri, 8 Oct 2021 06:34:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 08 Oct 2021 06:34:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= xV6wS/U6FsjW/XLtvBMS9ALQhLusigAGjuFV2peIHM4=; b=C05NWOQiTdMUhbGu +agj1k0JF2JCQaCc7CcF354NrGX+D+LjWRA0TeqWg+F+EAg8dyF9UOB10y9ADvOt 9Tirhf6HYCpjEKlCFQv5wIkm+tWm1njChnTcaklZgDYMQn0m19xxcdzTeuGhQVGF htPs740LZLXy/Ni//bYn7wTI0irhVQ4UHeNKJHa4QDtjCfpZmgGzfVCyPkevtVZl KIE888lOeAhzWriB3GApaClLXN9GJkW256tuGYWOFDjl2/3qYgR5YVjqoSHhWFCd 8Jo3lFwdsu92aKiQLOgQ4HG2bH8cQ8T66i+gnm0JKlWHxBUS3mRsJeZRwjcBEzfp yK2PSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=xV6wS/U6FsjW/XLtvBMS9ALQhLusigAGjuFV2peIH M4=; b=J5V6QQ5uQ8DLGFC8etxM3Wt1A4YrIUg+z6bq9szrpVvhCXLRj4KVTHdJv pPEeJXc1o3xzhp5Z1SydXv952/nhjYi0feD6ayKVkWIQPXeL+elZONlFMzWYzYUx rtw81ac1Af8Gg7XukdZlLbogusJqw9PRZZuQ1xt3HZfWnwzaS3euTOJi+b0hnx2M J3uwDa4NzBAH7JIEpulL/ISwfDsLUmRSHGDP41xqFsHB/pDvS21yQaGCAPwuPMQx 19BfbbMcAiOzmRwrrhsG/CZFHLqVMeiBqnEbvxRwtdLVikxevEwjU8n0R0Yo1uhO miRCYMc19t1zoFc08XHM65mYd/jSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddttddgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Oct 2021 06:34:01 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Date: Fri, 08 Oct 2021 12:04:40 +0200 Message-ID: <5857742.MVTgjyL6ng@thomas> In-Reply-To: References: <20210922033630.41130-1-humin29@huawei.com> <2236789.hR5l6LFQDr@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/10/2021 09:02, Min Hu (Connor): > Hi, Thomas, >=20 > =E5=9C=A8 2021/10/6 3:21, Thomas Monjalon =E5=86=99=E9=81=93: > > 22/09/2021 05:36, Min Hu (Connor): > >> From: Huisong Li > >> > >> Use the testpmd to perform the following operations: > >> 1) mac_addr add 0 00:18:2D:00:00:90 > >> 2) mac_addr add 0 00:18:2D:00:00:91 > >> 3) mac_addr add 0 00:18:2D:00:00:92 > >> 4) mac_addr set 0 00:18:2D:00:00:91 > >> 5) show port 0 macs > >> Number of MAC address added: 4 > >> 00:18:2D:00:00:91 > >> 00:18:2D:00:00:90 > >> 00:18:2D:00:00:91 > >> 00:18:2D:00:00:92 > >=20 > > Please describe with words. > > Reading similar MAC addresses is not a fun game. >=20 > I do not catch you, could you please be > more detailed, thanks. Me too, I don't catch you. Please explain the problem in the commit log so we can understand without the example. > >> This is due to the reason that if the address has been added as a > >> non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't re= move > >> from dev->data->mac_addrs[] when set default MAC address with the same > >> address. > >> > >> Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Huisong Li > >> Signed-off-by: Min Hu (Connor)