From: Thomas Monjalon <thomas@monjalon.net>
To: Markos Chandras <mchandras@suse.de>
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>,
Timothy Redaelli <tredaelli@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix link with ixgbe shared lib
Date: Mon, 01 May 2017 22:12:03 +0200 [thread overview]
Message-ID: <5858218.OA5nERF2Hd@xps> (raw)
In-Reply-To: <20170501201032.24028-1-thomas@monjalon.net>
01/05/2017 22:10, Thomas Monjalon:
> From: Markos Chandras <mchandras@suse.de>
>
> When RTE_DEVEL_BUILD is unset, -rpath is unset.
> So the ethtool app cannot link with ixgbe shared library
> which is required by ethtool lib:
>
> warning: librte_pmd_ixgbe.so.1, needed by
> examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/librte_ethtool.so,
> not found (try using -rpath or -rpath-link)
>
> It is fixed by adding the library in the application link.
>
> The library link is also improved to specify that this explicit link
> to ixgbe is needed only in the shared lib mode.
>
> Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function")
>
> Signed-off-by: Markos Chandras <mchandras@suse.de>
> Acked-by: Remy Horton <remy.horton@intel.com>
> Acked-by: Timothy Redaelli <tredaelli@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: add condition on CONFIG_RTE_BUILD_SHARED_LIB
Applied, thanks
prev parent reply other threads:[~2017-05-01 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:17 [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary Markos Chandras
2017-02-17 16:11 ` Remy Horton
2017-02-17 16:27 ` Markos Chandras
2017-02-20 14:06 ` Remy Horton
2017-04-07 13:15 ` Timothy M. Redaelli
2017-02-20 14:06 ` Remy Horton
2017-03-09 20:13 ` Thomas Monjalon
2017-04-04 10:15 ` Thomas Monjalon
2017-04-04 11:12 ` Remy Horton
2017-05-01 20:10 ` [dpdk-dev] [PATCH v2] examples/ethtool: fix link with ixgbe shared lib Thomas Monjalon
2017-05-01 20:12 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5858218.OA5nERF2Hd@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=mchandras@suse.de \
--cc=remy.horton@intel.com \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).