From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 23DC65A44 for ; Mon, 1 May 2017 22:12:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C0FCE20852; Mon, 1 May 2017 16:12:04 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 01 May 2017 16:12:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=WRzwlM8hsmwkdro uNbpE1seRzcGOGicNQ8hE5iVlgzE=; b=TeQeCVhlecowYgN2e4ws6SWYk7qwAgz 50LJkpsx4PGJk8LAKJvVlv1gyWXW6nUWqb2P6lCZoCuG9cY/dgKnNLgPpp2f8NMf Qg5YOhe1N5goaCJY6xQKAZ44BPk0wa5RpEnzIfl1fkZUPP23ioUhOwfBPISmKbd5 snqBzkxtuRW8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=WRzwlM8hsmwkdrouNbpE1seRzcGOGicNQ8hE5iVlgzE=; b=PsbcisLl ScO3864ztZ6gEIIMm9pJ0QQXWC0VJVKN/En0w93qVxLGuYdplfadNZHC2FDRxkKy +bKAiUA+xc9Qa1smfrhJTTBpHgIwzm43ARacoE5rHe3VzpMuSMebGH/i8mLDo1kG yJJnTamBtCXJalqyC7CLRF2q4P6A1dEnuHFJDCojLCdj15L1mQ0A1jGk9+DTc9nr /gtcewB+q1f34I5JxL++hTSETvCT9Ns0JZoNxgCMkGKWYrWJjS6LY7/xnBphBt7v +N87InBREi5NgkBpCGUTDYY1We+bQCxcHEXRsfyem8XCi5CTvhdZAFZ1MInpQswk u7Td2US2CloUwQ== X-ME-Sender: X-Sasl-enc: TuRjQGjzPVAiXBPoWDd2e3prihGGDx4vPRODW+kN3fmT 1493669524 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 710A57E267; Mon, 1 May 2017 16:12:04 -0400 (EDT) From: Thomas Monjalon To: Markos Chandras Cc: dev@dpdk.org, Remy Horton , Timothy Redaelli Date: Mon, 01 May 2017 22:12:03 +0200 Message-ID: <5858218.OA5nERF2Hd@xps> In-Reply-To: <20170501201032.24028-1-thomas@monjalon.net> References: <20170216161731.4590-1-mchandras@suse.de> <20170501201032.24028-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/ethtool: fix link with ixgbe shared lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 20:12:05 -0000 01/05/2017 22:10, Thomas Monjalon: > From: Markos Chandras > > When RTE_DEVEL_BUILD is unset, -rpath is unset. > So the ethtool app cannot link with ixgbe shared library > which is required by ethtool lib: > > warning: librte_pmd_ixgbe.so.1, needed by > examples/ethtool/lib/x86_64-native-linuxapp-gcc/lib/librte_ethtool.so, > not found (try using -rpath or -rpath-link) > > It is fixed by adding the library in the application link. > > The library link is also improved to specify that this explicit link > to ixgbe is needed only in the shared lib mode. > > Fixes: 077d223e25c3 ("examples/ethtool: use ixgbe public function") > > Signed-off-by: Markos Chandras > Acked-by: Remy Horton > Acked-by: Timothy Redaelli > Signed-off-by: Thomas Monjalon > --- > v2: add condition on CONFIG_RTE_BUILD_SHARED_LIB Applied, thanks